From: Jean-Francois Moine <moinejf@free.fr>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: tda998x: Change cec_write address type
Date: Fri, 9 Jan 2015 18:24:03 +0100 [thread overview]
Message-ID: <20150109182403.1b214074@armhf> (raw)
In-Reply-To: <20150109165630.GX12302@n2100.arm.linux.org.uk>
On Fri, 9 Jan 2015 16:56:30 +0000
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> > diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
> > index d476279..70658af 100644
> > --- a/drivers/gpu/drm/i2c/tda998x_drv.c
> > +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
> > @@ -342,7 +342,7 @@ struct tda998x_priv {
> > #define TDA19988 0x0301
> >
> > static void
> > -cec_write(struct tda998x_priv *priv, uint16_t addr, uint8_t val)
> > +cec_write(struct tda998x_priv *priv, uint8_t addr, uint8_t val)
>
> I'm not bothered by this change - is there a pressing reason to make it?
>
> Looking at the generated code, this change will be a no-op, so it's purely
> cosmetic from what I can determine.
Yes. It is just to have the same addr type in cec_read and cec_write.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-01-09 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150107084851.41B9DCA92D4@smtpfb2-g21.free.fr>
2015-01-09 16:56 ` [PATCH] drm: tda998x: Change cec_write address type Russell King - ARM Linux
2015-01-09 17:24 ` Jean-Francois Moine [this message]
2015-01-07 8:42 Jean-Francois Moine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150109182403.1b214074@armhf \
--to=moinejf@free.fr \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox