From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/rockchip: vop use is_enabled instead of dpms mode Date: Thu, 22 Jan 2015 08:33:34 +0100 Message-ID: <20150122073334.GU10113@phenom.ffwll.local> References: <1421910333-5576-1-git-send-email-mark.yao@rock-chips.com> <1421910333-5576-2-git-send-email-mark.yao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by gabe.freedesktop.org (Postfix) with ESMTP id 7DF366E7C5 for ; Wed, 21 Jan 2015 23:33:39 -0800 (PST) Received: by mail-wi0-f179.google.com with SMTP id l15so1251518wiw.0 for ; Wed, 21 Jan 2015 23:33:38 -0800 (PST) Content-Disposition: inline In-Reply-To: <1421910333-5576-2-git-send-email-mark.yao@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark Yao Cc: linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKYW4gMjIsIDIwMTUgYXQgMDM6MDU6MzJQTSArMDgwMCwgTWFyayBZYW8gd3JvdGU6 Cj4gZHJtIGRwbXMgaGF2ZSBtYW55IHBvd2VyIG1vZGVzOiBPTixPRkYsU1VTUEVORCxTVEFOREJZ LCBldGMuCj4gYnV0IHZvcCBvbmx5IGhhdmUgZW5hYmxlL2Rpc2FibGUgbW9kZSwgbWF5YmUgY2Fz ZSBzdWNoIGJ1ZzoKPiAgLS0+IERSTV9EUE1TX09OOiBwb3dlciBvbiB2b3AKPiAgLS0+IERSTV9E UE1TX1NVU1BFTkQ6IHBvd2VyIG9mZiB2b3AKPiAgLS0+IERSTV9EUE1TX09GRjogYWxyZWFkeSBw b3dlciBvZmYgYXQgU1VTUEVORCwgY3Jhc2gKPiBzbyB1c2UgYSBib29sIHZhbCBpcyBtb3JlIHN1 aXRhYmxlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hcmsgWWFvIDxtYXJrLnlhb0Byb2NrLWNoaXBz LmNvbT4KCkxvbmcgdGVybSBJIGhpZ2hseSBzdWdnZXN0IHlvdSBzd2l0Y2ggdG8gYXRvbWljLCBz aW5jZSB3aXRoIGF0b21pYyBhbGwgdGhlCmxlZ2FjeSBkcG1zIG1vZGVzIGFyZSByZW1hcHBlZCB0 byBhIHNpbXBsZSBvbi9vZmYuIEFsc28gdGhlIG5ldyBhdG9taWMKaGVscGVycyBtYWtlIHN1cmUg dGhhdCB5b3VyIGJhY2tlbmQgaXNuJ3QgY2FsbGVkIG11bHRpcGxlIHRpbWVzLCBzbyB5b3UKY2Fu IGRpdGNoIGFsbCB5b3VyIGlzX2VuYWJsZWQgdHJhY2tpbmcgd2l0aCB0aGF0LgotRGFuaWVsCgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5jIHwgICAz NCArKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE4IGluc2Vy dGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5jIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlw L3JvY2tjaGlwX2RybV92b3AuYwo+IGluZGV4IDlhNWM1NzEuLmYyNzhjMDkgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmMKPiBAQCAtODEsNyArODEs NyBAQCBzdHJ1Y3Qgdm9wIHsKPiAgCXN0cnVjdCBkcm1fY3J0YyBjcnRjOwo+ICAJc3RydWN0IGRl dmljZSAqZGV2Owo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRybV9kZXY7Cj4gLQl1bnNpZ25lZCBp bnQgZHBtczsKPiArCWJvb2wgaXNfZW5hYmxlZDsKPiAgCj4gIAlpbnQgY29ubmVjdG9yX3R5cGU7 Cj4gIAlpbnQgY29ubmVjdG9yX291dF9tb2RlOwo+IEBAIC0zODcsNiArMzg3LDkgQEAgc3RhdGlj IHZvaWQgdm9wX2VuYWJsZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gIAlzdHJ1Y3Qgdm9wICp2 b3AgPSB0b192b3AoY3J0Yyk7Cj4gIAlpbnQgcmV0Owo+ICAKPiArCWlmICh2b3AtPmlzX2VuYWJs ZWQpCj4gKwkJcmV0dXJuOwo+ICsKPiAgCXJldCA9IGNsa19lbmFibGUodm9wLT5oY2xrKTsKPiAg CWlmIChyZXQgPCAwKSB7Cj4gIAkJZGV2X2Vycih2b3AtPmRldiwgImZhaWxlZCB0byBlbmFibGUg aGNsayAtICVkXG4iLCByZXQpOwo+IEBAIC00MjcsNiArNDMwLDggQEAgc3RhdGljIHZvaWQgdm9w X2VuYWJsZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gIAo+ICAJZHJtX3ZibGFua19vbih2b3At PmRybV9kZXYsIHZvcC0+cGlwZSk7Cj4gIAo+ICsJdm9wLT5pc19lbmFibGVkID0gZmFsc2U7Cj4g Kwo+ICAJcmV0dXJuOwo+ICAKPiAgZXJyX2Rpc2FibGVfYWNsazoKPiBAQCAtNDQxLDYgKzQ0Niw5 IEBAIHN0YXRpYyB2b2lkIHZvcF9kaXNhYmxlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiAgewo+ ICAJc3RydWN0IHZvcCAqdm9wID0gdG9fdm9wKGNydGMpOwo+ICAKPiArCWlmICh2b3AtPmlzX2Vu YWJsZWQpCj4gKwkJcmV0dXJuOwo+ICsKPiAgCWRybV92Ymxhbmtfb2ZmKGNydGMtPmRldiwgdm9w LT5waXBlKTsKPiAgCj4gIAlkaXNhYmxlX2lycSh2b3AtPmlycSk7Cj4gQEAgLTQ2Myw2ICs0NzEs OCBAQCBzdGF0aWMgdm9pZCB2b3BfZGlzYWJsZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gIAo+ ICAJY2xrX2Rpc2FibGUodm9wLT5hY2xrKTsKPiAgCWNsa19kaXNhYmxlKHZvcC0+aGNsayk7Cj4g Kwo+ICsJdm9wLT5pc19lbmFibGVkID0gZmFsc2U7Cj4gIH0KPiAgCj4gIC8qCj4gQEAgLTc0Miw3 ICs3NTIsNyBAQCBzdGF0aWMgaW50IHZvcF9jcnRjX2VuYWJsZV92Ymxhbmsoc3RydWN0IGRybV9j cnRjICpjcnRjKQo+ICAJc3RydWN0IHZvcCAqdm9wID0gdG9fdm9wKGNydGMpOwo+ICAJdW5zaWdu ZWQgbG9uZyBmbGFnczsKPiAgCj4gLQlpZiAodm9wLT5kcG1zICE9IERSTV9NT0RFX0RQTVNfT04p Cj4gKwlpZiAoIXZvcC0+aXNfZW5hYmxlZCkKPiAgCQlyZXR1cm4gLUVQRVJNOwo+ICAKPiAgCXNw aW5fbG9ja19pcnFzYXZlKCZ2b3AtPmlycV9sb2NrLCBmbGFncyk7Cj4gQEAgLTc1OSw4ICs3Njks OSBAQCBzdGF0aWMgdm9pZCB2b3BfY3J0Y19kaXNhYmxlX3ZibGFuayhzdHJ1Y3QgZHJtX2NydGMg KmNydGMpCj4gIAlzdHJ1Y3Qgdm9wICp2b3AgPSB0b192b3AoY3J0Yyk7Cj4gIAl1bnNpZ25lZCBs b25nIGZsYWdzOwo+ICAKPiAtCWlmICh2b3AtPmRwbXMgIT0gRFJNX01PREVfRFBNU19PTikKPiAr CWlmICghdm9wLT5pc19lbmFibGVkKQo+ICAJCXJldHVybjsKPiArCj4gIAlzcGluX2xvY2tfaXJx c2F2ZSgmdm9wLT5pcnFfbG9jaywgZmxhZ3MpOwo+ICAJdm9wX21hc2tfd3JpdGUodm9wLCBJTlRS X0NUUkwwLCBGU19JTlRSX01BU0ssIEZTX0lOVFJfRU4oMCkpOwo+ICAJc3Bpbl91bmxvY2tfaXJx cmVzdG9yZSgmdm9wLT5pcnFfbG9jaywgZmxhZ3MpOwo+IEBAIC03NzMsMTUgKzc4NCw4IEBAIHN0 YXRpYyBjb25zdCBzdHJ1Y3Qgcm9ja2NoaXBfY3J0Y19mdW5jcyBwcml2YXRlX2NydGNfZnVuY3Mg PSB7Cj4gIAo+ICBzdGF0aWMgdm9pZCB2b3BfY3J0Y19kcG1zKHN0cnVjdCBkcm1fY3J0YyAqY3J0 YywgaW50IG1vZGUpCj4gIHsKPiAtCXN0cnVjdCB2b3AgKnZvcCA9IHRvX3ZvcChjcnRjKTsKPiAt Cj4gIAlEUk1fREVCVUdfS01TKCJjcnRjWyVkXSBtb2RlWyVkXVxuIiwgY3J0Yy0+YmFzZS5pZCwg bW9kZSk7Cj4gIAo+IC0JaWYgKHZvcC0+ZHBtcyA9PSBtb2RlKSB7Cj4gLQkJRFJNX0RFQlVHX0tN UygiZGVzaXJlZCBkcG1zIG1vZGUgaXMgc2FtZSBhcyBwcmV2aW91cyBvbmUuXG4iKTsKPiAtCQly ZXR1cm47Cj4gLQl9Cj4gLQo+ICAJc3dpdGNoIChtb2RlKSB7Cj4gIAljYXNlIERSTV9NT0RFX0RQ TVNfT046Cj4gIAkJdm9wX2VuYWJsZShjcnRjKTsKPiBAQCAtNzk1LDggKzc5OSw2IEBAIHN0YXRp YyB2b2lkIHZvcF9jcnRjX2RwbXMoc3RydWN0IGRybV9jcnRjICpjcnRjLCBpbnQgbW9kZSkKPiAg CQlEUk1fREVCVUdfS01TKCJ1bnNwZWNpZmllZCBtb2RlICVkXG4iLCBtb2RlKTsKPiAgCQlicmVh azsKPiAgCX0KPiAtCj4gLQl2b3AtPmRwbXMgPSBtb2RlOwo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9p ZCB2b3BfY3J0Y19wcmVwYXJlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiBAQCAtOTM0LDkgKzkz Niw5IEBAIHN0YXRpYyBpbnQgdm9wX2NydGNfcGFnZV9mbGlwKHN0cnVjdCBkcm1fY3J0YyAqY3J0 YywKPiAgCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKm9sZF9mYiA9IGNydGMtPnByaW1hcnktPmZi Owo+ICAJaW50IHJldDsKPiAgCj4gLQkvKiB3aGVuIHRoZSBwYWdlIGZsaXAgaXMgcmVxdWVzdGVk LCBjcnRjJ3MgZHBtcyBzaG91bGQgYmUgb24gKi8KPiAtCWlmICh2b3AtPmRwbXMgPiBEUk1fTU9E RV9EUE1TX09OKSB7Cj4gLQkJRFJNX0RFQlVHKCJmYWlsZWQgcGFnZSBmbGlwIHJlcXVlc3QgYXQg ZHBtc1slZF0uXG4iLCB2b3AtPmRwbXMpOwo+ICsJLyogd2hlbiB0aGUgcGFnZSBmbGlwIGlzIHJl cXVlc3RlZCwgY3J0YyBzaG91bGQgYmUgb24gKi8KPiArCWlmICghdm9wLT5pc19lbmFibGVkKSB7 Cj4gKwkJRFJNX0RFQlVHKCJwYWdlIGZsaXAgcmVxdWVzdCByZWplY3RlZCBiZWNhdXNlIGNydGMg aXMgb2ZmLlxuIik7Cj4gIAkJcmV0dXJuIDA7Cj4gIAl9Cj4gIAo+IEBAIC0xMzAyLDcgKzEzMDQs NyBAQCBzdGF0aWMgaW50IHZvcF9pbml0aWFsKHN0cnVjdCB2b3AgKnZvcCkKPiAgCj4gIAljbGtf ZGlzYWJsZSh2b3AtPmhjbGspOwo+ICAKPiAtCXZvcC0+ZHBtcyA9IERSTV9NT0RFX0RQTVNfT0ZG Owo+ICsJdm9wLT5pc19lbmFibGVkID0gZmFsc2U7Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gIAo+IC0t IAo+IDEuNy45LjUKPiAKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJ bnRlbCBDb3Jwb3JhdGlvbgorNDEgKDApIDc5IDM2NSA1NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xs LmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==