From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/atomic: Fix potential use of state after free Date: Fri, 23 Jan 2015 08:55:07 +0100 Message-ID: <20150123075507.GX10113@phenom.ffwll.local> References: <1421998079-22945-1-git-send-email-ander.conselvan.de.oliveira@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by gabe.freedesktop.org (Postfix) with ESMTP id 9BF286E3F7 for ; Thu, 22 Jan 2015 23:55:11 -0800 (PST) Received: by mail-wg0-f53.google.com with SMTP id a1so5920196wgh.12 for ; Thu, 22 Jan 2015 23:55:10 -0800 (PST) Content-Disposition: inline In-Reply-To: <1421998079-22945-1-git-send-email-ander.conselvan.de.oliveira@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ander Conselvan de Oliveira Cc: daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKYW4gMjMsIDIwMTUgYXQgMDk6Mjc6NTlBTSArMDIwMCwgQW5kZXIgQ29uc2VsdmFu IGRlIE9saXZlaXJhIHdyb3RlOgo+IFRoZSBhdG9taWMgaGVscGVycyByZWx5IG9uIGRybV9hdG9t aWNfc3RhdGVfY2xlYXIoKSB0byByZXNldCBhbiBhdG9taWMKPiBzdGF0ZSBpZiBhIHJldHJ5IGlz IG5lZWRlZCBkdWUgdG8gdGhlIHcvdyBtdXRleGVzLiBUaGUgc3Vic2VxdWVudCBjYWxscwo+IHRv IGRybV9hdG9taWNfZ2V0X3tjcnRjLHBsYW5lLC4uLn1fc3RhdGUoKSB3b3VsZCB0aGVuIHJldHVy biB0aGUgc3RhbGUKPiBwb2ludGVycyBpbiBzdGF0ZS0+e2NydGMscGxhbmUsLi4ufV9zdGF0ZXMu Cj4gCj4gU2lnbmVkLW9mZi1ieTogQW5kZXIgQ29uc2VsdmFuIGRlIE9saXZlaXJhIDxhbmRlci5j b25zZWx2YW4uZGUub2xpdmVpcmFAaW50ZWwuY29tPgoKT29wcywgcHJldHR5IGJhZCBvdmVyc2ln aHQuIEtpbmRhIHdvbmRlciB3aHkgdGhhdCBoYXNuJ3QgYmxvd24gdXAKYW55d2hlcmUgeWV0IC0g cGxhaW4gbGVnYWN5IHBhdGhzIGNhbid0IHJlYWxseSBmYWlsIHdpdGggcmV0cmllcyB5ZXQgc2lu Y2UKd2UgdXN1YWxseSBncmFiIGFsbCB0aGUgbG9ja3MuIEJ1dCByZWFsIGF0b21pY19pb2N0bCBz aG91bGQgaGF2ZSBmYWxsZW4Kb3ZlciB3aXRoIHd3IG11dGV4IGRlYnVnZ2luZyAuLi4KCkFueXdh eSwgdGhhbmtzIGZvciB0aGUgcGF0Y2gsIGFwcGxpZWQgdG8gbXkgYXRvbWljIGJyYW5jaC4KLURh bmllbAoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyB8IDMgKysrCj4gIDEg ZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2RybV9hdG9taWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiBpbmRl eCAxYjMxOTgyLi45ZDE2ZmE0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRv bWljLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gQEAgLTEzNCw2ICsx MzQsNyBAQCB2b2lkIGRybV9hdG9taWNfc3RhdGVfY2xlYXIoc3RydWN0IGRybV9hdG9taWNfc3Rh dGUgKnN0YXRlKQo+ICAKPiAgCQljb25uZWN0b3ItPmZ1bmNzLT5hdG9taWNfZGVzdHJveV9zdGF0 ZShjb25uZWN0b3IsCj4gIAkJCQkJCSAgICAgICBzdGF0ZS0+Y29ubmVjdG9yX3N0YXRlc1tpXSk7 Cj4gKwkJc3RhdGUtPmNvbm5lY3Rvcl9zdGF0ZXNbaV0gPSBOVUxMOwo+ICAJfQo+ICAKPiAgCWZv ciAoaSA9IDA7IGkgPCBjb25maWctPm51bV9jcnRjOyBpKyspIHsKPiBAQCAtMTQ0LDYgKzE0NSw3 IEBAIHZvaWQgZHJtX2F0b21pY19zdGF0ZV9jbGVhcihzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAq c3RhdGUpCj4gIAo+ICAJCWNydGMtPmZ1bmNzLT5hdG9taWNfZGVzdHJveV9zdGF0ZShjcnRjLAo+ ICAJCQkJCQkgIHN0YXRlLT5jcnRjX3N0YXRlc1tpXSk7Cj4gKwkJc3RhdGUtPmNydGNfc3RhdGVz W2ldID0gTlVMTDsKPiAgCX0KPiAgCj4gIAlmb3IgKGkgPSAwOyBpIDwgY29uZmlnLT5udW1fdG90 YWxfcGxhbmU7IGkrKykgewo+IEBAIC0xNTQsNiArMTU2LDcgQEAgdm9pZCBkcm1fYXRvbWljX3N0 YXRlX2NsZWFyKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAgCj4gIAkJcGxhbmUt PmZ1bmNzLT5hdG9taWNfZGVzdHJveV9zdGF0ZShwbGFuZSwKPiAgCQkJCQkJICAgc3RhdGUtPnBs YW5lX3N0YXRlc1tpXSk7Cj4gKwkJc3RhdGUtPnBsYW5lX3N0YXRlc1tpXSA9IE5VTEw7Cj4gIAl9 Cj4gIH0KPiAgRVhQT1JUX1NZTUJPTChkcm1fYXRvbWljX3N0YXRlX2NsZWFyKTsKPiAtLSAKPiAx LjkuMQo+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBv cmF0aW9uCis0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK