From: Dan Carpenter <dan.carpenter@oracle.com>
To: benjamin.gaignard@linaro.org
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
dri-devel@lists.freedesktop.org
Subject: re: drm: sti: add DVO output connector
Date: Wed, 4 Feb 2015 12:08:11 +0300 [thread overview]
Message-ID: <20150204090811.GA10824@mwanda> (raw)
Hello Benjamin Gaignard,
The patch f32c4c506f9b: "drm: sti: add DVO output connector" from Dec
30, 2014, leads to the following static checker warning:
drivers/gpu/drm/sti/sti_awg_utils.c:63 awg_generate_instr()
warn: no-op. '(arg << 24) >> 24'
drivers/gpu/drm/sti/sti_awg_utils.c
46 switch (opcode) {
47 case SKIP:
48 /* leave 'arg' + 1 pixel elapsing without changing
49 * output bus */
50 arg--; /* pixel adjustment */
51 arg_tmp--;
52
53 if (arg < 0) {
54 /* SKIP instruction not needed */
55 return 0;
56 }
57
58 if (arg == 0) {
59 /* SKIP 0 not permitted but we want to skip 1
60 * pixel. So we transform SKIP into SET
61 * instruction */
62 opcode = SET;
63 arg = (arg << 24) >> 24;
^^^^^^^^^^^^^^^^^^^^^^^^
64 arg &= (0x0ff);
^^^^^^^^^^^^^^^
Since "arg" is zero then the shift/mask operations are a no-op. I'm not
sure what was intented.
65 break;
66 }
67
68 mux = 0;
69 data_enable = 0;
70 arg = (arg << 22) >> 22;
71 arg &= (0x3ff);
72 break;
73 case REPEAT:
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
reply other threads:[~2015-02-04 9:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150204090811.GA10824@mwanda \
--to=dan.carpenter@oracle.com \
--cc=benjamin.gaignard@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox