From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH] drm: atmel-hlcdc: Atomic mode-setting conversion Date: Thu, 5 Feb 2015 16:37:56 +0100 Message-ID: <20150205163756.74a1bde0@bbrezillon> References: <1423081251-11062-1-git-send-email-boris.brezillon@free-electrons.com> <20150205130832.GU14009@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150205130832.GU14009@phenom.ffwll.local> Sender: linux-kernel-owner@vger.kernel.org To: Daniel Vetter Cc: David Airlie , dri-devel@lists.freedesktop.org, Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org On Thu, 5 Feb 2015 14:08:32 +0100 Daniel Vetter wrote: > On Wed, Feb 04, 2015 at 09:20:51PM +0100, Boris Brezillon wrote: > > Convert the HLCDC driver to atomic mode-setting. > > > > Signed-off-by: Boris Brezillon > > Just a quick comment: dpms isn't yet converted over, and from experience > with tegra/msm that probably will yield some surprises. Since only with > dpms will it be obvious how strict the added requirements from the atomic > helpers are ;-) Yes, I noticed I was not using the appropriate dpms helper in the connector funcs just after sending this patch. Would this patch [1] address what you're talking about, or am I still missing something ? Thanks, Boris [1]http://code.bulix.org/l70xf4-87827 -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com