From: Damien Lespiau <damien.lespiau@intel.com>
To: Ian Romanick <idr@freedesktop.org>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 09/12] intel: Provide IS_GENX() macros taking a drm_intel_device as argument
Date: Thu, 5 Mar 2015 18:45:20 +0000 [thread overview]
Message-ID: <20150305184520.GB16358@strange.ger.corp.intel.com> (raw)
In-Reply-To: <54F8A34F.5060304@freedesktop.org>
On Thu, Mar 05, 2015 at 10:41:19AM -0800, Ian Romanick wrote:
> On 03/05/2015 08:20 AM, Damien Lespiau wrote:
> > Time to switch over all the IS_GENX() macros to the new device object.
> > Nothing more than a mechanical search & replace here.
>
> Hmm... why not just do the comparisons directly? The macros seem
> superfluous.
I asked myself the same question as well and then went for the solution
that wasn't going to change what was already there too much. I really
have no opinion either way.
--
Damien
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-03-05 18:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 16:20 [PATCH libdrm 00/12] Introduce drm_intel_device and use i915_pciid.h Damien Lespiau
2015-03-05 16:20 ` [PATCH 01/12] intel: Remove unused define IS_MOBILE() Damien Lespiau
2015-03-05 16:20 ` [PATCH 02/12] intel: Introduce an drm_intel_device object Damien Lespiau
2015-03-05 16:20 ` [PATCH 03/12] intel: Use drm_intel_device in the gem buffer manager Damien Lespiau
2015-03-05 16:20 ` [PATCH 04/12] intel: Make drm_intel_decode use a drm_intel_device Damien Lespiau
2015-03-05 16:20 ` [PATCH 05/12] intel: Use '||' for the boolean or Damien Lespiau
2015-03-05 16:20 ` [PATCH 06/12] intel: Kill the IS_9XX() macro Damien Lespiau
2015-03-05 16:20 ` [PATCH 07/12] intel: Kill the IS_GEN4() macro Damien Lespiau
2015-03-05 16:20 ` [PATCH 08/12] intel: Remove direct usage of IS_915() Damien Lespiau
2015-03-05 16:20 ` [PATCH 09/12] intel: Provide IS_GENX() macros taking a drm_intel_device as argument Damien Lespiau
2015-03-05 18:41 ` Ian Romanick
2015-03-05 18:45 ` Damien Lespiau [this message]
2015-03-05 16:20 ` [PATCH 10/12] intel: Make test_decode fail gracefully the decode context is NULL Damien Lespiau
2015-03-05 16:20 ` [PATCH 11/12] intel: Make test_decode not depend on intel_chipset.h Damien Lespiau
2015-03-05 16:20 ` [PATCH 12/12] intel: Remove intel_chipset.h Damien Lespiau
2015-03-05 18:44 ` [PATCH libdrm 00/12] Introduce drm_intel_device and use i915_pciid.h Ian Romanick
2015-03-06 14:10 ` Emil Velikov
2015-03-06 14:35 ` Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305184520.GB16358@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=idr@freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox