From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm: Only warn about an invalid EDID block prior to rejection
Date: Mon, 9 Mar 2015 18:08:25 +0100 [thread overview]
Message-ID: <20150309170825.GV24485@phenom.ffwll.local> (raw)
In-Reply-To: <20150309152944.GV11371@intel.com>
On Mon, Mar 09, 2015 at 05:29:44PM +0200, Ville Syrjälä wrote:
> On Mon, Mar 09, 2015 at 11:44:05AM +0000, Chris Wilson wrote:
> > On a noisy link, we may retry the EDID reads multiple times per block
> > and still succeed. In such cases, we don't want to flood the kernel logs
> > with *ERROR* messages as we then succeed. Refactor the EDID dumping and
> > push it into the caller rather than the validator so we can suppress the
> > warnings from transient failures. In the process, we want to refactor
> > drm_load_edid_firmware() to use the common drm_do_get_edid() to share
> > the same logic (since it already duplicates it).
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=89454
>
> Could we get it to dump the number of retries it had to make to get a
> valid EDID? The retries could be due to driver bugs so we may want to
> know that they in fact occured. Otherwise we might end up with eg.
> large delays during resume without any indication what caused them.
Just aside I'm hacking around on latencytop stuff so that edid reads show
up as latency sources. Often they're done as cpu spinning (so don't show
up at all). And if not there's huge issues with piles of retries (like
here) or just very short sleeps (gmbus can only transfer 4 bytes a time).
But that would just augment whatever other debug information we dump into
dmesg.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-03-09 17:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 11:44 [PATCH] drm: Only warn about an invalid EDID block prior to rejection Chris Wilson
2015-03-09 15:29 ` Ville Syrjälä
2015-03-09 15:39 ` Chris Wilson
2015-03-09 16:04 ` Ville Syrjälä
2015-03-09 16:22 ` Chris Wilson
2015-03-09 17:08 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309170825.GV24485@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox