From: Dan Carpenter <dan.carpenter@oracle.com>
To: laurent.pinchart@ideasonboard.com
Cc: dri-devel@lists.freedesktop.org
Subject: re: drm: Check in setcrtc if the primary plane supports the fb pixel format
Date: Tue, 10 Mar 2015 23:30:45 +0300 [thread overview]
Message-ID: <20150310203045.GA7162@mwanda> (raw)
Hello Laurent Pinchart,
The patch eca93e28c256: "drm: Check in setcrtc if the primary plane
supports the fb pixel format" from Mar 9, 2015, leads to the
following static checker warning:
drivers/gpu/drm/drm_plane_helper.c:360 create_primary_plane()
info: ignoring unreachable code.
drivers/gpu/drm/drm_plane_helper.c
347 static struct drm_plane *create_primary_plane(struct drm_device *dev)
348 {
349 struct drm_plane *primary;
350 int ret;
351
352 primary = kzalloc(sizeof(*primary), GFP_KERNEL);
353 if (primary == NULL) {
354 DRM_DEBUG_KMS("Failed to allocate primary plane\n");
355 return NULL;
^^^^^^^^^^^^
356 /*
357 * Remove the format_default field from drm_plane when dropping
358 * this helper.
359 */
360 primary->format_default = true;
361 }
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2015-03-10 20:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 20:30 Dan Carpenter [this message]
2015-03-11 1:54 ` drm: Check in setcrtc if the primary plane supports the fb pixel format Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310203045.GA7162@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).