From: Daniel Vetter <daniel@ffwll.ch>
To: Zhigang Gong <zhigang.gong@linux.intel.com>
Cc: beignet@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Subject: Re: [Beignet] [PATCH] drm/i915: Export total subslice and EU counts
Date: Fri, 13 Mar 2015 18:03:02 +0100 [thread overview]
Message-ID: <20150313170302.GJ3800@phenom.ffwll.local> (raw)
In-Reply-To: <016001d059fd$66ef9680$34cec380$@linux.intel.com>
On Mon, Mar 09, 2015 at 08:10:06AM +0800, Zhigang Gong wrote:
> > -----Original Message-----
> > From: Beignet [mailto:beignet-bounces@lists.freedesktop.org] On Behalf Of
> > Jeff McGee
> > Sent: Saturday, March 7, 2015 2:44 AM
> > To: Zhigang Gong
> > Cc: daniel@ffwll.ch; intel-gfx@lists.freedesktop.org;
> > beignet@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> > Subject: Re: [Beignet] [PATCH] drm/i915: Export total subslice and EU counts
> >
> > On Thu, Mar 05, 2015 at 12:35:55PM +0800, Zhigang Gong wrote:
> > > There is one minor conflict when apply the KMD patch to latest
> > > drm-intel-nightly branch. It should be easy to fix.
> > >
> > > Another issue is that IMO, we should bump libdrm's version number when
> > > increase these new APIs. Then in Beignet, we can check the libdrm
> > > version at build time and determine whether we will use these new
> > > interfaces. Thus, we can avoid breaking beignet on those systems which
> > > have previous libdrm/kernel installed.
> > >
> > Right. I can append a libdrm patch to bump the version. And then I suppose I
> > will follow the process to make a new release. Not sure right now how that
> > works. First time going through it.
> >
> > Also, how should we test for the libdrm version and conditionally use the API?
> We can check the libdrm version at configuration time and define a macro to
> indicate whether we can use these new APIs in beignet.
> > Is there a previous example of this in Beignet that I could follow?
> Yes, one example is userptr. You can check the usage of DRM_INTEL_USERPTR and HAS_USERPTR
> In beignet.
Ok, applied the kernel patch. Please go ahead with libdrm&beignet parts.
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-13 17:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 23:37 [PATCH] drm/i915: Export total subslice and EU counts jeff.mcgee
2015-03-03 1:26 ` Jeff McGee
2015-03-03 8:54 ` Daniel Vetter
2015-03-03 8:56 ` Daniel Vetter
2015-03-05 4:35 ` Zhigang Gong
2015-03-06 18:44 ` [Beignet] " Jeff McGee
2015-03-09 0:10 ` Zhigang Gong
2015-03-13 17:03 ` Daniel Vetter [this message]
2015-03-06 19:23 ` [Beignet] " Jeff McGee
2015-03-09 23:06 ` [PATCH v2] " jeff.mcgee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150313170302.GJ3800@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=beignet@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=zhigang.gong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox