From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC PATCH 17/37] DRM: Atomic: Use pointer for mode in CRTC state Date: Fri, 20 Mar 2015 17:16:22 +0100 Message-ID: <20150320161622.GZ1349@phenom.ffwll.local> References: <1426739556-10429-1-git-send-email-daniels@collabora.com> <1426739616-10635-1-git-send-email-daniels@collabora.com> <1426739616-10635-17-git-send-email-daniels@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-we0-f176.google.com (mail-we0-f176.google.com [74.125.82.176]) by gabe.freedesktop.org (Postfix) with ESMTP id 588946EC78 for ; Fri, 20 Mar 2015 09:15:11 -0700 (PDT) Received: by weop45 with SMTP id p45so85914315weo.0 for ; Fri, 20 Mar 2015 09:15:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1426739616-10635-17-git-send-email-daniels@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Stone Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBNYXIgMTksIDIwMTUgYXQgMDQ6MzM6MTZBTSArMDAwMCwgRGFuaWVsIFN0b25lIHdy b3RlOgo+IEhvbGRpbmcgYSBwb2ludGVyIHRvIHRoZSBtb2RlLCByYXRoZXIgdGhhbiBhbiBlbWJl ZCwgYWxsb3dzIHVzIHRvIGdldAo+IHRvd2FyZHMgc2hhcmluZyByZWZjb3VudGVkIG1vZGVzLgo+ IAo+IFhYWDogYXRvbWljX2Rlc3Ryb3lfc3RhdGUgZG9lcyBfbm90XyBzZWVtIHRvIGJlIG9wdGlv bmFsIC0gc28gd2Ugc2hvdWxkCj4gICAgICByZW1vdmUgYW55IGZhbGxiYWNrIHBhdGhzIHdoaWNo IGNvbXBlbnNhdGUgZm9yIGl0cyBsYWNrIQo+ICAgICAgdGhlIGNydGNfc3RhdGUtPm1vZGUgaGFu ZGxpbmcgaXMgcGFydGljdWxhcmx5IHVnbHkgaGVyZSA6XAoKZHVwbGljYXRlL2Rlc3Ryb3kgY2Fs bGJhY2tzIGFyZSBvcHRpb25hbCBpbiB0aGUgdHJhbnNpdGlvbmFsIGhlbHBlcnMuIEFuZAp0aGF0 J3MgZmFpcmx5IGludGVudGlvbmFsIHRvIGF2b2lkIHRoZSBuZWVkIGZvciBzd2l0Y2hpbmcgdG8g dGhlIGZ1bGwKc3RhdGUgc2NhZmZvbGRpbmcgYXQgb25jZS4KCkZvciB0aGVzZSBjb3VsZG4ndCB3 ZSBpbnN0ZWFkIGp1c3Qgc3RvcmUgYSBwb2ludGVyIHRvIGNydGMtPm1vZGUgaW5zdGVhZD8KTGlm ZXRpbWVzIHNob3VsZCBiZSBmdWxseSBpbiBzeW5jLgoKPiBAQCAtMjA1OCwxMSArMjA1OCwyMiBA QCBFWFBPUlRfU1lNQk9MKGRybV9hdG9taWNfaGVscGVyX2Nvbm5lY3Rvcl9kcG1zKTsKPiAgICov Cj4gIHZvaWQgZHJtX2F0b21pY19oZWxwZXJfY3J0Y19yZXNldChzdHJ1Y3QgZHJtX2NydGMgKmNy dGMpCj4gIHsKPiArCWlmIChjcnRjLT5zdGF0ZSkKPiArCQlrZnJlZShjcnRjLT5zdGF0ZS0+bW9k ZSk7Cj4gKwo+ICAJa2ZyZWUoY3J0Yy0+c3RhdGUpOwo+ICAJY3J0Yy0+c3RhdGUgPSBremFsbG9j KHNpemVvZigqY3J0Yy0+c3RhdGUpLCBHRlBfS0VSTkVMKTsKPiAgCj4gLQlpZiAoY3J0Yy0+c3Rh dGUpCj4gKwlpZiAoY3J0Yy0+c3RhdGUpIHsKPiAgCQljcnRjLT5zdGF0ZS0+Y3J0YyA9IGNydGM7 Cj4gKwkJY3J0Yy0+c3RhdGUtPm1vZGUgPQo+ICsJCQlremFsbG9jKHNpemVvZigqY3J0Yy0+c3Rh dGUtPm1vZGUpLCBHRlBfS0VSTkVMKTsKCkFsbG9jYXRpbmcgYW4gZW1wdHkgbW9kZSBvYmplY3Qg c2VlbXMgc3VwZXJmbG91cy4gV2h5IGRvIHdlIG5lZWQgdGhpcz8KCj4gKwl9Cj4gKwo+ICsJaWYg KGNydGMtPnN0YXRlICYmICFjcnRjLT5zdGF0ZS0+bW9kZSkgewo+ICsJCWtmcmVlKGNydGMtPnN0 YXRlKTsKPiArCQljcnRjLT5zdGF0ZSA9IE5VTEw7Cj4gKwl9Cj4gIH0KPiAgRVhQT1JUX1NZTUJP TChkcm1fYXRvbWljX2hlbHBlcl9jcnRjX3Jlc2V0KTsKPiAgCj4gQEAgLTIwODgsNiArMjA5OSwx MSBAQCBkcm1fYXRvbWljX2hlbHBlcl9jcnRjX2R1cGxpY2F0ZV9zdGF0ZShzdHJ1Y3QgZHJtX2Ny dGMgKmNydGMpCj4gIAkJc3RhdGUtPmFjdGl2ZV9jaGFuZ2VkID0gZmFsc2U7Cj4gIAkJc3RhdGUt PnBsYW5lc19jaGFuZ2VkID0gZmFsc2U7Cj4gIAkJc3RhdGUtPmV2ZW50ID0gTlVMTDsKPiArCQlz dGF0ZS0+bW9kZSA9IGRybV9tb2RlX2R1cGxpY2F0ZShjcnRjLT5kZXYsIGNydGMtPnN0YXRlLT5t b2RlKTsKPiArCQlpZiAoIXN0YXRlLT5tb2RlKSB7Cj4gKwkJCWtmcmVlKHN0YXRlKTsKPiArCQkJ c3RhdGUgPSBOVUxMOwo+ICsJCX0KPiAgCX0KPiAgCj4gIAlyZXR1cm4gc3RhdGU7Cj4gQEAgLTIx MDUsNiArMjEyMSw3IEBAIEVYUE9SVF9TWU1CT0woZHJtX2F0b21pY19oZWxwZXJfY3J0Y19kdXBs aWNhdGVfc3RhdGUpOwo+ICB2b2lkIGRybV9hdG9taWNfaGVscGVyX2NydGNfZGVzdHJveV9zdGF0 ZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAkJCQkJICBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUg KnN0YXRlKQo+ICB7Cj4gKwlrZnJlZShzdGF0ZS0+bW9kZSk7Cj4gIAlrZnJlZShzdGF0ZSk7Cj4g IH0KPiAgRVhQT1JUX1NZTUJPTChkcm1fYXRvbWljX2hlbHBlcl9jcnRjX2Rlc3Ryb3lfc3RhdGUp Owo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYyBiL2RyaXZlcnMvZ3B1 L2RybS9kcm1fY3J0Yy5jCj4gaW5kZXggNTc4NTMzNi4uNjAyMzg1MSAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0 Yy5jCj4gQEAgLTIwMDgsNyArMjAwOCw3IEBAIGludCBkcm1fbW9kZV9nZXRjcnRjKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYsCj4gIAkJY3J0Y19yZXNwLT54ID0gY3J0Yy0+cHJpbWFyeS0+c3RhdGUt PnNyY194ID4+IDE2Owo+ICAJCWNydGNfcmVzcC0+eSA9IGNydGMtPnByaW1hcnktPnN0YXRlLT5z cmNfeSA+PiAxNjsKPiAgCQlpZiAoY3J0Yy0+c3RhdGUtPmVuYWJsZSkgewo+IC0JCQlkcm1fY3J0 Y19jb252ZXJ0X3RvX3Vtb2RlKCZjcnRjX3Jlc3AtPm1vZGUsICZjcnRjLT5zdGF0ZS0+bW9kZSk7 Cj4gKwkJCWRybV9jcnRjX2NvbnZlcnRfdG9fdW1vZGUoJmNydGNfcmVzcC0+bW9kZSwgY3J0Yy0+ c3RhdGUtPm1vZGUpOwo+ICAJCQljcnRjX3Jlc3AtPm1vZGVfdmFsaWQgPSAxOwo+ICAKPiAgCQl9 IGVsc2Ugewo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGNfaGVscGVyLmMg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGNfaGVscGVyLmMKPiBpbmRleCBjNjA2M2ZmLi44YTlh MDQ1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Y19oZWxwZXIuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Y19oZWxwZXIuYwo+IEBAIC05NDMsMTEgKzk0Mywz MiBAQCBpbnQgZHJtX2hlbHBlcl9jcnRjX21vZGVfc2V0KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywK PiAgCj4gIAlpZiAoY3J0Yy0+ZnVuY3MtPmF0b21pY19kdXBsaWNhdGVfc3RhdGUpCj4gIAkJY3J0 Y19zdGF0ZSA9IGNydGMtPmZ1bmNzLT5hdG9taWNfZHVwbGljYXRlX3N0YXRlKGNydGMpOwo+IC0J ZWxzZSBpZiAoY3J0Yy0+c3RhdGUpCj4gKwllbHNlIGlmIChjcnRjLT5zdGF0ZSkgewo+ICAJCWNy dGNfc3RhdGUgPSBrbWVtZHVwKGNydGMtPnN0YXRlLCBzaXplb2YoKmNydGNfc3RhdGUpLAo+ICAJ CQkJICAgICBHRlBfS0VSTkVMKTsKPiAtCWVsc2UKPiArCQkvKiBYWFg6IHRoaXMgaXMgdW5wbGVh c2FudDogd2Ugc2hvdWxkIG1hbmRhdGUgZHVwIGluc3RlYWQgKi8KPiArCQlpZiAoY3J0Y19zdGF0 ZSkgewo+ICsJCQljcnRjX3N0YXRlLT5tb2RlID0KPiArCQkJCWRybV9tb2RlX2R1cGxpY2F0ZShj cnRjLT5kZXYsCj4gKwkJCQkgICAgICAgICAgICAgICAgICAgY3J0Yy0+c3RhdGUtPm1vZGUpOwo+ ICsJCQlpZiAoIWNydGNfc3RhdGUtPm1vZGUpIHsKPiArCQkJCWtmcmVlKGNydGNfc3RhdGUpOwo+ ICsJCQkJY3J0Y19zdGF0ZSA9IE5VTEw7Cj4gKwkJCX0KPiArCQl9Cj4gKwl9Cj4gKwllbHNlIHsK PiAgCQljcnRjX3N0YXRlID0ga3phbGxvYyhzaXplb2YoKmNydGNfc3RhdGUpLCBHRlBfS0VSTkVM KTsKPiArCQlpZiAoY3J0Y19zdGF0ZSkgewo+ICsJCQljcnRjX3N0YXRlLT5tb2RlID0ga3phbGxv YyhzaXplb2YoKmNydGNfc3RhdGUtPm1vZGUpLAo+ICsJCQkgICAgICAgICAgICAgICAgICAgICAg ICAgICBHRlBfS0VSTkVMKTsKPiArCQkJLyogWFhYOiBhcyBhYm92ZSwgYnV0IG1hbmRhdGUgYSBu ZXdfc3RhdGUgKi8KPiArCQkJaWYgKCFjcnRjX3N0YXRlLT5tb2RlKSB7Cj4gKwkJCQlrZnJlZShj cnRjX3N0YXRlKTsKPiArCQkJCWNydGNfc3RhdGUgPSBOVUxMOwo+ICsJCQl9Cj4gKwkJfQo+ICsJ fQoKSSB0aGluayBmb3IgdHJhbnNpdGlvbmFsIGhlbHBlcnMgaWYgd2UganVzdCBkbyBhIGNydGNf c3RhdGUtPm1vZGUgPQpjcnRjLT5tb2RlIHRoYXQgc2hvdWxkIGJlIGFsbCB0aGF0J3MgbmVlZGVk LgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jw b3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=