From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v4 14/15] ASoC: rockchip/rockchip-hdmi-audio: add sound driver for hdmi audio Date: Thu, 26 Mar 2015 11:16:20 -0700 Message-ID: <20150326181620.GZ3572@sirena.org.uk> References: <1425175834-24661-1-git-send-email-ykk@rock-chips.com> <1425179070-2736-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3574320421423367378==" Return-path: In-Reply-To: <1425179070-2736-1-git-send-email-ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Yakir Yang Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, David Airlie , djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Max Filippov , Bard Liao , mmind00-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org, Lars-Peter Clausen , Axel Lin , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Takashi Iwai , Russell King , Sean Cross , Oder Chiou , Arnd Bergmann , Jyri Sarha , Ben Zhang , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, marcheu-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Jaroslav Kysela , mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, Fabio Estevam , Brian Austin , Greg Kroah-Hartman , Liam Girdwood , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Philipp Zabel List-Id: dri-devel@lists.freedesktop.org --===============3574320421423367378== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NJ3GtppTlf/130kA" Content-Disposition: inline --NJ3GtppTlf/130kA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Feb 28, 2015 at 10:04:30PM -0500, Yakir Yang wrote: > + ret = snd_soc_dai_set_fmt(cpu_dai, dai_fmt); > + if (ret < 0) { > + dev_err(cpu_dai->dev, "failed to set cpu_dai fmt.\n"); > + return ret; > + } You've already set this in the dai_link, no need to do it again. > + dev_info(&pdev->dev, "hdmi audio init success.\n"); Please remove noisy prints like this. > +free_cpu_of_node: > + hdmi_audio_dai.cpu_of_node = NULL; > + hdmi_audio_dai.platform_of_node = NULL; > +free_priv_data: > + snd_soc_card_set_drvdata(card, NULL); > + platform_set_drvdata(pdev, NULL); > + card->dev = NULL; If any of these assignments is doing anything there's a problem with the code. > +{ > + struct snd_soc_card *card = platform_get_drvdata(pdev); > + > + snd_soc_unregister_card(card); devm_snd_soc_register_card() and you can remove this function entirely. > +static const struct of_device_id rockchip_hdmi_audio_of_match[] = { > + { .compatible = "rockchip,rk3288-hdmi-audio", }, > + {}, > +}; There is no documentation for this binding, binding documentation is mandatory. Based on the compatible string this looks like it's specific to the SoC rather than a design for a board - is the whole card part of the SoC? --NJ3GtppTlf/130kA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVFEzzAAoJECTWi3JdVIfQDHoH/1e/8agSVnWGgaEMc0obh/dg 6AHcHMbXlJJ+df8MK4p/pIdgkq8an4KWXmSHY/tbQ0Z8ylVEImUq5eZi42ZU+P/v PWPLwkYoant5d+QryNF61Gze0PkImIWvbI7pzEAhrXUVfyi9VAXazxTpDotCHWGl G2A6CBMDTgRUEuz4/yIDpBxTxEm0E7ymg5OQvad1eKJvMlIdoaKoLryOeJ+tIQ7q 8D20Kj2gHJDgFT+SFLmD//XgLpnFTO3ELHdrJq8k4bMzlPVxkkPpTjTG0tvfxAOd e4j3dDI0tDTd1IGrCeQoCLQ964wMGKiUNcvELk4DNLPPZ/MYqd+72/jFKF6z2bQ= =ipGX -----END PGP SIGNATURE----- --NJ3GtppTlf/130kA-- --===============3574320421423367378== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-rockchip mailing list Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org http://lists.infradead.org/mailman/listinfo/linux-rockchip --===============3574320421423367378==--