dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: Hyungwon Hwang <human.hwang@samsung.com>
Cc: cw00.choi@samsung.com, sw0312.kim@samsung.com,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/exynos: fimd: check whether exynos_drm_crtc_create succeed or not
Date: Wed, 1 Apr 2015 12:31:40 -0300	[thread overview]
Message-ID: <20150401153140.GC7013@joana> (raw)
In-Reply-To: <1427861696-4961-1-git-send-email-human.hwang@samsung.com>

Hi Hyungwon,

2015-04-01 Hyungwon Hwang <human.hwang@samsung.com>:

> From the commit "drm/exynos: fix the execution order in FIMD
> initialization" (598285bfdce46d7c47632a2ba4b980f60be4a677), the error
> checking code is removed improperly. This patch fix the regression.
> 
> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> index 31dfa80..15cee94 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -1060,6 +1060,8 @@ static int fimd_bind(struct device *dev, struct device *master, void *data)
>  	ctx->crtc = exynos_drm_crtc_create(drm_dev, ctx->pipe,
>  					   EXYNOS_DISPLAY_TYPE_LCD,
>  					   &fimd_crtc_ops, ctx);
> +	if (IS_ERR(ctx->crtc))
> +		return PTR_ERR(ctx->crtc);

My current clean up patch set fixes this and I hope it will be merged soon.
It is part of "drm/exynos: remove struct *_win_data abstraction on planes"
patch.

	Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-04-01 15:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01  4:14 [PATCH] drm/exynos: fimd: check whether exynos_drm_crtc_create succeed or not Hyungwon Hwang
2015-04-01 15:31 ` Gustavo Padovan [this message]
2015-04-07 13:32 ` Inki Dae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150401153140.GC7013@joana \
    --to=gustavo@padovan.org \
    --cc=cw00.choi@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=human.hwang@samsung.com \
    --cc=sw0312.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox