From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: Add integer overflow checking to transitional plane helpers Date: Tue, 7 Apr 2015 08:12:39 +0200 Message-ID: <20150407061239.GL6354@phenom.ffwll.local> References: <1428096466-27622-1-git-send-email-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by gabe.freedesktop.org (Postfix) with ESMTP id D93456E3E4 for ; Mon, 6 Apr 2015 23:10:42 -0700 (PDT) Received: by wgin8 with SMTP id n8so45035522wgi.0 for ; Mon, 06 Apr 2015 23:10:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1428096466-27622-1-git-send-email-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBBcHIgMDMsIDIwMTUgYXQgMDI6Mjc6NDZQTSAtMDcwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBBZGQgdGVzdHMgZm9yIGRlc3RpbmF0aW9uIHJlY3RhbmdsZSBpbnRlZ2VyIG92ZXJmbG93 IGJlZm9yZSBjYWxsaW5nIHRoZQo+IGRyaXZlcidzIGNoZWNrIGZ1bmN0aW9uLiAgVGhpcyB3aWxs IGVuc3VyZSB0aGF0IHRoZSB0cmFuc2l0aW9uYWwgcGxhbmUKPiBoZWxwZXJzIG1hdGNoIHRoZSBi ZWhhdmlvciBvZiB0aGUgZnVsbCBhdG9taWMgaGVscGVycyBieSBhbHdheXMKPiByZXR1cm5pbmcg LUVSQU5HRSBmb3IgcGxhbmVzIHBvc2l0aW9uZWQgYmV5b25kIElOVF9NQVguCj4gCj4gTm90ZSB0 aGF0IHRoZSBsZWdhY3kgU2V0UGxhbmUgaW9jdGwgaXRzZWxmIGFsc28gaW5jbHVkZXMgc2ltaWxh ciB0ZXN0cwo+IGZvciBpbnRlZ2VyIG92ZXJmbG93LCBzbyB0aGUgb25seSBjYXNlIHdoZXJlIHRo aXMgY2hlY2sgcmVhbGx5IG1hdHRlcnMKPiBpcyB3aGVuIGxlZ2FjeSBjdXJzb3Igb3BlcmF0aW9u cyBnZXQgcm91dGVkIHRocm91Z2ggdGhlIHVuaXZlcnNhbCBwbGFuZQo+IGludGVyZmFjZSBpbnRl cm5hbGx5Lgo+IAo+IFRoaXMgaXNzdWUgd2FzIGZpcnN0IG5vdGljZWQgd2l0aCBpOTE1IGNvbW1p dDoKPiAKPiAgICAgICAgIGNvbW1pdCBmZjQyZTA5M2U5YzljMTdhNmUxZDZhYWIyNDg3NWEzNjc5 NWY5MjZlCj4gICAgICAgICBBdXRob3I6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3 bGwuY2g+Cj4gICAgICAgICBEYXRlOiAgIE1vbiBNYXIgMiAxNjozNToyMCAyMDE1ICswMTAwCj4g Cj4gICAgICAgICAgICAgUmV2ZXJ0ICJkcm0vaTkxNTogU3dpdGNoIHBsYW5lcyBmcm9tIHRyYW5z aXRpb25hbCBoZWxwZXJzIHRvIGZ1bGwKPiAgICAgICAgICAgICBhdG9taWMgaGVscGVycyIKPiAK PiBUaGUgYWJvdmUgcmV2ZXJ0IHN3aXRjaGVkIHVzIGZyb20gZnVsbCBhdG9taWMgaGVscGVycyBi YWNrIHRvIHRoZQo+IHRyYW5zaXRpb25hbCBoZWxwZXJzLCBhbmQgaW4gZG9pbmcgc28gd2UgbG9z dCB0aGUgb3ZlcmZsb3cgY2hlY2tpbmcgaGVyZQo+IGZvciB1bml2ZXJzYWwgY3Vyc29yIHVwZGF0 ZXMuICBFdmVuIHRob3VnaCBzdWNoIGV4dHJlbWUgY3Vyc29yIHBvc2l0aW9ucwo+IGFyZSB1bmxp a2VseSB0byBhY3R1YWxseSBoYXBwZW4gaW4gdGhlIHdpbGQsIHdlIHN0aWxsIGRvbid0IHdhbnQg dGhlcmUKPiB0byBiZSBhIGNoYW5nZSBvZiBiZWhhdmlvciB3aGVuIGRyaXZlcnMgc3dpdGNoIGZy b20gdHJhbnNpdGlvbmFsIGhlbHBlcnMKPiB0byBmdWxsIGhlbHBlcnMuCj4gCj4gQnVnemlsbGE6 IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTg0MjY5Cj4gU2ln bmVkLW9mZi1ieTogTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KClNpbmNl IHRoaXMgaXMganVzdCBmb3IgdGhlIGN1cnNvciBpb2N0bCAuLi4gc2hvdWxkbid0IHdlIGluc3Rl YWQgbW92ZQp0aGVzZSBjaGVja3MgZnJvbSBkcm1fbW9kZV9zZXRwbGFuZSB0byBfX3NldHBsYW5l X2ludGVybmFsPyBUaGF0IHdheSBvdGhlcgpkcml2ZXJzIGFsc28gY2FuIHJlbHkgdXBvbiB0aGVz ZSBndWFyYW50ZWVzIHdoZW4gaW1wbGVtZW50aW5nIHVuaXZlcnNhbApjdXJzb3Igc3VwcG9ydCBh bmQgd2Ugd29uJ3QgaGF2ZSBhIG1pc21hdGNoIGluIHdoYXQga2luZCBvZiBwbGFuZQpwcm9wZXJ0 aWVzIGNhbiBzbmVhayB0aHJvdWdoIHRvIGRyaXZlcnMuCi1EYW5pZWwKCj4gLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9kcm1fcGxhbmVfaGVscGVyLmMgfCAxNCArKysrKysrKysrKysrKwo+ICAxIGZp bGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vZHJtX3BsYW5lX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZV9oZWxw ZXIuYwo+IGluZGV4IDMzODA3ZTAuLjFlOWUxMDUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2RybV9wbGFuZV9oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fcGxhbmVf aGVscGVyLmMKPiBAQCAtNDE3LDYgKzQxNywyMCBAQCBpbnQgZHJtX3BsYW5lX2hlbHBlcl9jb21t aXQoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gIAlmb3IgKGkgPSAwOyBpIDwgMjsgaSsrKQo+ ICAJCWNydGNfZnVuY3NbaV0gPSBjcnRjW2ldID8gY3J0Y1tpXS0+aGVscGVyX3ByaXZhdGUgOiBO VUxMOwo+ICAKPiArCS8qCj4gKwkgKiBHaXZlIGRyaXZlcnMgc29tZSBoZWxwIGFnYWluc3QgaW50 ZWdlciBvdmVyZmxvd3MgKGFuZCBtYXRjaCB0aGUKPiArCSAqIGJlaGF2aW9yIG9mIHRoZSBmdWxs IGF0b21pYyBoZWxwZXJzKS4KPiArCSAqLwo+ICsJaWYgKHBsYW5lX3N0YXRlLT5jcnRjX3cgPiBJ TlRfTUFYIHx8Cj4gKwkgICAgcGxhbmVfc3RhdGUtPmNydGNfeCA+IElOVF9NQVggLSAoaW50MzJf dCkgcGxhbmVfc3RhdGUtPmNydGNfdyB8fAo+ICsJICAgIHBsYW5lX3N0YXRlLT5jcnRjX2ggPiBJ TlRfTUFYIHx8Cj4gKwkgICAgcGxhbmVfc3RhdGUtPmNydGNfeSA+IElOVF9NQVggLSAoaW50MzJf dCkgcGxhbmVfc3RhdGUtPmNydGNfaCkgewo+ICsJCURSTV9ERUJVR19BVE9NSUMoIkludmFsaWQg Q1JUQyBjb29yZGluYXRlcyAldXgldSslZCslZFxuIiwKPiArCQkJCSBwbGFuZV9zdGF0ZS0+Y3J0 Y193LCBwbGFuZV9zdGF0ZS0+Y3J0Y19oLAo+ICsJCQkJIHBsYW5lX3N0YXRlLT5jcnRjX3gsIHBs YW5lX3N0YXRlLT5jcnRjX3kpOwo+ICsJCXJldHVybiAtRVJBTkdFOwo+ICsJfQo+ICsKPiAgCWlm IChwbGFuZV9mdW5jcy0+YXRvbWljX2NoZWNrKSB7Cj4gIAkJcmV0ID0gcGxhbmVfZnVuY3MtPmF0 b21pY19jaGVjayhwbGFuZSwgcGxhbmVfc3RhdGUpOwo+ICAJCWlmIChyZXQpCj4gLS0gCj4gMS44 LjUuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRp b24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK