From: Lukas Wunner <lukas@wunner.de>
To: Chris Wilson <chris@chris-wilson.co.uk>,
dri-devel@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@intel.com>,
Seth Forshee <seth.forshee@canonical.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH 10/11] drm/i915: Reprobe connectors if vga_switcheroo handler registers late
Date: Tue, 21 Apr 2015 14:16:56 +0200 [thread overview]
Message-ID: <20150421121656.GA4325@wunner.de> (raw)
In-Reply-To: <20150421115010.GL17348@nuc-i3427.alporthouse.com>
Hi Chris,
On Tue, Apr 21, 2015 at 12:50:10PM +0100, Chris Wilson wrote:
> On Sun, Apr 19, 2015 at 05:01:17PM +0200, Lukas Wunner wrote:
> > +cleanup_gem:
> > + DRM_ERROR("failed to reinitialize fbdev\n");
> > + mutex_lock(&dev->struct_mutex);
> > + i915_gem_cleanup_ringbuffer(dev);
> > + i915_gem_context_fini(dev);
> > + mutex_unlock(&dev->struct_mutex);
>
> This is a bit random since you don't initialize GEM here and presumably
> the GPU is still available even if it has no outputs.
Hm, I copied this verbatim from i915_dma.c:i915_load_modeset_init(),
I was under the impression that this is required if fbdev initialization
failed. Am I missing something?
Thanks,
Lukas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-04-21 12:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 9:58 [PATCH 00/11] Enable gpu switching on the MacBook Pro Lukas Wunner
2012-09-07 15:22 ` [PATCH 01/11] vga_switcheroo: Add support for switching only the DDC Lukas Wunner
2012-09-07 15:22 ` [PATCH 02/11] vga_switcheroo: Add helper function to get the active client Lukas Wunner
2012-09-07 15:22 ` [PATCH 03/11] apple-gmux: Add switch_ddc support Lukas Wunner
2012-09-07 15:22 ` [PATCH 04/11] drm/edid: Switch DDC when reading the EDID Lukas Wunner
2012-12-22 2:52 ` [PATCH 05/11] vga_switcheroo: Lock/unlock DDC lines Lukas Wunner
2014-03-05 22:34 ` [PATCH 09/11] apple-gmux: Assign apple_gmux_data before registering Lukas Wunner
2015-03-27 11:29 ` [PATCH 06/11] vga_switcheroo: Lock/unlock DDC lines harder Lukas Wunner
2015-04-19 15:01 ` [PATCH 10/11] drm/i915: Reprobe connectors if vga_switcheroo handler registers late Lukas Wunner
2015-04-21 11:50 ` Chris Wilson
2015-04-21 12:16 ` Lukas Wunner [this message]
2015-04-21 12:37 ` Chris Wilson
2015-04-19 15:18 ` [PATCH 11/11] drm/nouveau: Pause between setting gpu to D3hot and cutting the power Lukas Wunner
2015-04-20 10:08 ` [PATCH 08/11] vga_switcheroo: Reprobe connectors if handler registers late Lukas Wunner
2015-04-21 8:39 ` [PATCH 07/11] Revert "vga_switcheroo: Add helper function to get the active client" Lukas Wunner
2015-04-21 19:49 ` [PATCH 00/11] Enable gpu switching on the MacBook Pro Matthew Garrett
2015-04-22 13:48 ` Lukas Wunner
2015-04-25 14:20 ` Lukas Wunner
2015-05-02 19:03 ` Lu, Ran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150421121656.GA4325@wunner.de \
--to=lukas@wunner.de \
--cc=airlied@redhat.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=mjg59@srcf.ucam.org \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox