From: Daniel Vetter <daniel@ffwll.ch>
To: Daniel Stone <daniels@collabora.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/7] drm/atomic: Early-exit from CRTC dup state
Date: Thu, 7 May 2015 11:05:57 +0200 [thread overview]
Message-ID: <20150507090557.GY30184@phenom.ffwll.local> (raw)
In-Reply-To: <1429554176-9865-3-git-send-email-daniels@collabora.com>
On Mon, Apr 20, 2015 at 07:22:51PM +0100, Daniel Stone wrote:
> Just change an if (success) branch to if (fail) return;
>
> Signed-off-by: Daniel Stone <daniels@collabora.com>
I dropped this one since the code already changed a bit.
-Daniel
> ---
> drivers/gpu/drm/drm_atomic_helper.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
> index d536817..60eb505 100644
> --- a/drivers/gpu/drm/drm_atomic_helper.c
> +++ b/drivers/gpu/drm/drm_atomic_helper.c
> @@ -1983,12 +1983,13 @@ drm_atomic_helper_crtc_duplicate_state(struct drm_crtc *crtc)
>
> state = kmemdup(crtc->state, sizeof(*crtc->state), GFP_KERNEL);
>
> - if (state) {
> - state->mode_changed = false;
> - state->active_changed = false;
> - state->planes_changed = false;
> - state->event = NULL;
> - }
> + if (!state)
> + return NULL;
> +
> + state->mode_changed = false;
> + state->active_changed = false;
> + state->planes_changed = false;
> + state->event = NULL;
>
> return state;
> }
> --
> 2.3.5
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-05-07 9:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 18:22 [PATCH 0/7] User-created blob properties Daniel Stone
2015-04-20 18:22 ` [PATCH 1/7] drm/atomic: Don't open-code CRTC state destroy Daniel Stone
2015-04-20 18:22 ` [PATCH 2/7] drm/atomic: Early-exit from CRTC dup state Daniel Stone
2015-05-07 9:05 ` Daniel Vetter [this message]
2015-04-20 18:22 ` [PATCH 3/7] drm: Don't leak path blob property when updating Daniel Stone
2015-04-20 18:22 ` [PATCH 4/7] drm: Introduce helper for replacing blob properties Daniel Stone
2015-04-20 18:22 ` [PATCH 5/7] drm: Introduce blob_lock Daniel Stone
2015-04-20 18:22 ` [PATCH 6/7] drm: Add reference counting to blob properties Daniel Stone
2015-05-07 9:14 ` Daniel Vetter
2015-04-20 18:22 ` [PATCH 7/7] drm/mode: Add user blob-creation ioctl Daniel Stone
2015-05-07 7:53 ` Maarten Lankhorst
2015-05-07 8:34 ` [PATCH 0/7] User-created blob properties Daniel Vetter
2015-05-07 9:15 ` Daniel Stone
2015-05-09 14:52 ` [PATCH v2] " Daniel Stone
2015-05-09 14:52 ` [PATCH 1/4] drm: Remove extraneous parameter from kerneldoc Daniel Stone
2015-05-11 9:09 ` Daniel Vetter
2015-05-11 22:49 ` Daniel Stone
2015-05-09 14:52 ` [PATCH 2/4] drm: Allow creating blob properties without copy Daniel Stone
2015-05-09 14:52 ` [PATCH 3/4] drm: Return error value from blob creation Daniel Stone
2015-05-09 14:52 ` [PATCH 4/4] drm/mode: Add user blob-creation ioctl Daniel Stone
2015-05-11 9:11 ` Daniel Vetter
2015-05-11 22:46 ` [PATCH 7/7] " Daniel Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150507090557.GY30184@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox