From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Sonika Jindal <sonika.jindal@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] Documentation/drm: Update rotation property with 90/270 and description
Date: Tue, 12 May 2015 15:50:25 +0300 [thread overview]
Message-ID: <20150512125025.GA18908@intel.com> (raw)
In-Reply-To: <1429094119-15590-1-git-send-email-sonika.jindal@intel.com>
On Wed, Apr 15, 2015 at 04:05:19PM +0530, Sonika Jindal wrote:
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> ---
> Documentation/DocBook/drm.tmpl | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
> index f4976cd..266d50a 100644
> --- a/Documentation/DocBook/drm.tmpl
> +++ b/Documentation/DocBook/drm.tmpl
> @@ -2853,9 +2853,12 @@ void intel_crt_init(struct drm_device *dev)
> <td rowspan="1" valign="top" >Plane</td>
> <td valign="top" >“rotation”</td>
> <td valign="top" >BITMASK</td>
> - <td valign="top" >{ 0, "rotate-0" }, { 2, "rotate-180" }</td>
> + <td valign="top" >{ 0, "rotate-0" }, { 1, "rotate-90" },
> + { 2, "rotate-180" }, { 3, "rotate-270" }</td>
> <td valign="top" >Plane</td>
> - <td valign="top" >TBD</td>
> + <td valign="top" >To set plane HW rotation. This rotation property does
> + the plane rotation in counter clockwise direction which is
> + inline with the way XRandr works.</td>
I would suggest moving the thing to the generci props section since we
have omap and i915 both supporting it.
As for the description, we should also document the reflect flags.
I might write it as something like this:
"rotate-0,rotate-90,rotate-180,rotate-270 rotate the image by the
specified amount in degrees in a counter clockwise direction.
reflect-x,reflect-y reflect the image along the specified axis,
prior to rotation."
> </tr>
> <tr>
> <td rowspan="17" valign="top" >SDVO-TV</td>
> --
> 1.7.10.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-05-12 12:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150415104236.GY6092@phenom.ffwll.local>
2015-04-15 10:35 ` [PATCH] Documentation/drm: Update rotation property with 90/270 and description Sonika Jindal
2015-05-12 12:50 ` Ville Syrjälä [this message]
2015-05-13 4:27 ` [Intel-gfx] " Jindal, Sonika
2015-05-20 6:39 ` Jindal, Sonika
2015-05-20 7:49 ` Jindal, Sonika
2015-05-20 14:03 ` Ville Syrjälä
2015-05-28 11:05 ` [PATCH] Documentation/drm: Update rotation property Sonika Jindal
2015-05-28 11:19 ` [Intel-gfx] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512125025.GA18908@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sonika.jindal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox