From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 10/11] drm/atomic: Add current-mode blob to CRTC state Date: Fri, 22 May 2015 16:30:50 +0200 Message-ID: <20150522143050.GV15256@phenom.ffwll.local> References: <1432298094-22239-1-git-send-email-daniels@collabora.com> <1432298094-22239-11-git-send-email-daniels@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by gabe.freedesktop.org (Postfix) with ESMTP id 128866EA67 for ; Fri, 22 May 2015 07:28:24 -0700 (PDT) Received: by wibt6 with SMTP id t6so49191003wib.0 for ; Fri, 22 May 2015 07:28:23 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1432298094-22239-11-git-send-email-daniels@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Stone Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBNYXkgMjIsIDIwMTUgYXQgMDE6MzQ6NTNQTSArMDEwMCwgRGFuaWVsIFN0b25lIHdy b3RlOgo+IEFkZCBhIGJsb2IgcHJvcGVydHkgdHJhY2tpbmcgdGhlIGN1cnJlbnQgbW9kZSB0byB0 aGUgQ1JUQyBzdGF0ZSwgYW5kCj4gZW5zdXJlIGl0IGlzIHByb3Blcmx5IHVwZGF0ZWQgYW5kIHJl ZmVyZW5jZWQuCj4gCj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFN0b25lIDxkYW5pZWxzQGNvbGxh Ym9yYS5jb20+Cj4gVGVzdGVkLWJ5OiBTZWFuIFBhdWwgPHNlYW5wYXVsQGNocm9taXVtLm9yZz4K PiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyAgICAgICAgfCA2MiArKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRv bWljX2hlbHBlci5jIHwgMTEgKysrKy0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYyAg ICAgICAgICB8ICAzICstCj4gIGluY2x1ZGUvZHJtL2RybV9jcnRjLmggICAgICAgICAgICAgIHwg IDMgKysKPiAgNCBmaWxlcyBjaGFuZ2VkLCA3MyBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygt KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jIGIvZHJpdmVy cy9ncHUvZHJtL2RybV9hdG9taWMuYwo+IGluZGV4IDY3YzI1MWYuLjYzZmM1OGEgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fYXRvbWljLmMKPiBAQCAtMzAxLDYgKzMwMSw4IEBAIEVYUE9SVF9TWU1CT0woZHJtX2F0 b21pY19nZXRfY3J0Y19zdGF0ZSk7Cj4gIGludCBkcm1fYXRvbWljX3NldF9tb2RlX2Zvcl9jcnRj KHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqc3RhdGUsCj4gIAkJCQkgc3RydWN0IGRybV9kaXNwbGF5 X21vZGUgKm1vZGUpCj4gIHsKPiArCXN0cnVjdCBkcm1fbW9kZV9tb2RlaW5mbyB1bW9kZTsKPiAr Cj4gIAkvKiBFYXJseSByZXR1cm4gZm9yIG5vIGNoYW5nZS4gKi8KPiAgCWlmICghbW9kZSAmJiAh c3RhdGUtPmVuYWJsZSkKPiAgCQlyZXR1cm4gMDsKPiBAQCAtMzA4LDkgKzMxMCwyMCBAQCBpbnQg ZHJtX2F0b21pY19zZXRfbW9kZV9mb3JfY3J0YyhzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKnN0YXRl LAo+ICAJICAgIG1lbWNtcCgmc3RhdGUtPm1vZGUsIG1vZGUsIHNpemVvZigqbW9kZSkpID09IDAp Cj4gIAkJcmV0dXJuIDA7Cj4gIAo+ICsJaWYgKHN0YXRlLT5tb2RlX2Jsb2IpCj4gKwkJZHJtX3By b3BlcnR5X3VucmVmZXJlbmNlX2Jsb2Ioc3RhdGUtPm1vZGVfYmxvYik7Cj4gKwlzdGF0ZS0+bW9k ZV9ibG9iID0gTlVMTDsKPiAgCXN0YXRlLT5tb2RlX2NoYW5nZWQgPSB0cnVlOwo+ICAKPiAgCWlm IChtb2RlKSB7Cj4gKwkJZHJtX21vZGVfY29udmVydF90b191bW9kZSgmdW1vZGUsIG1vZGUpOwo+ ICsJCXN0YXRlLT5tb2RlX2Jsb2IgPQo+ICsJCQlkcm1fcHJvcGVydHlfY3JlYXRlX2Jsb2Ioc3Rh dGUtPmNydGMtPmRldiwKPiArCQkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzaXpl b2YodW1vZGUpLAo+ICsJCSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZ1bW9kZSk7 Cj4gKwkJaWYgKCFzdGF0ZS0+bW9kZV9ibG9iKQo+ICsJCQlyZXR1cm4gLUVOT01FTTsKCklTX0VS UiBhbmQgUFRSX0VSUj8gRGFuIENhcnBlbnRlciB3aWxsIGNhdGNoIHRoaXMgYXMgc29vbiBhcyBJ J2xsIGFwcGx5CjstKQoKPiArCj4gIAkJZHJtX21vZGVfY29weSgmc3RhdGUtPm1vZGUsIG1vZGUp Owo+ICAJCXN0YXRlLT5lbmFibGUgPSB0cnVlOwo+ICAJfSBlbHNlIHsKPiBAQCAtMzMwLDYgKzM0 Myw1NSBAQCBpbnQgZHJtX2F0b21pY19zZXRfbW9kZV9mb3JfY3J0YyhzdHJ1Y3QgZHJtX2NydGNf c3RhdGUgKnN0YXRlLAo+ICB9Cj4gIEVYUE9SVF9TWU1CT0woZHJtX2F0b21pY19zZXRfbW9kZV9m b3JfY3J0Yyk7Cj4gIAo+ICsvKioKPiArICogZHJtX2F0b21pY19zZXRfbW9kZV9wcm9wX2Zvcl9j cnRjIC0gc2V0IG1vZGUgZm9yIENSVEMKPiArICogQHN0YXRlOiB0aGUgQ1JUQyB3aG9zZSBpbmNv bWluZyBzdGF0ZSB0byB1cGRhdGUKPiArICogQGJsb2I6IHBvaW50ZXIgdG8gYmxvYiBwcm9wZXJ0 eSB0byB1c2UgZm9yIG1vZGUKPiArICoKPiArICogU2V0IGEgbW9kZSAob3JpZ2luYXRpbmcgZnJv bSBhIGJsb2IgcHJvcGVydHkpIG9uIHRoZSBkZXNpcmVkIENSVEMgc3RhdGUuCj4gKyAqIFRoaXMg ZnVuY3Rpb24gd2lsbCB0YWtlIGEgcmVmZXJlbmNlIG9uIHRoZSBibG9iIHByb3BlcnR5IGZvciB0 aGUgQ1JUQyBzdGF0ZSwKPiArICogYW5kIHJlbGVhc2UgdGhlIHJlZmVyZW5jZSBoZWxkIG9uIHRo ZSBzdGF0ZSdzIGV4aXN0aW5nIG1vZGUgcHJvcGVydHksIGlmIGFueQo+ICsgKiB3YXMgc2V0Lgo+ ICsgKi8KPiAraW50IGRybV9hdG9taWNfc2V0X21vZGVfcHJvcF9mb3JfY3J0YyhzdHJ1Y3QgZHJt X2NydGNfc3RhdGUgKnN0YXRlLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHN0cnVjdCBkcm1fcHJvcGVydHlfYmxvYiAqYmxvYikKPiArewo+ICsJaWYgKGJsb2IgPT0g c3RhdGUtPm1vZGVfYmxvYikKPiArCQlyZXR1cm4gMDsKPiArCj4gKwlpZiAoc3RhdGUtPm1vZGVf YmxvYikKPiArCQlkcm1fcHJvcGVydHlfdW5yZWZlcmVuY2VfYmxvYihzdGF0ZS0+bW9kZV9ibG9i KTsKPiArCXN0YXRlLT5tb2RlX2Jsb2IgPSBOVUxMOwo+ICsKPiArCWlmIChibG9iKSB7Cj4gKwkJ aWYgKGJsb2ItPmxlbmd0aCAhPSBzaXplb2Yoc3RydWN0IGRybV9tb2RlX21vZGVpbmZvKSB8fAo+ ICsJCSAgICBkcm1fbW9kZV9jb252ZXJ0X3Vtb2RlKCZzdGF0ZS0+bW9kZSwKPiArCQkgICAgICAg ICAgICAgICAgICAgICAgICAgICAoY29uc3Qgc3RydWN0IGRybV9tb2RlX21vZGVpbmZvICopCj4g KwkJICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJsb2ItPmRhdGEpKQo+ICsJCQlyZXR1cm4g LUVJTlZBTDsKPiArCj4gKwkJc3RhdGUtPm1vZGVfYmxvYiA9IGRybV9wcm9wZXJ0eV9yZWZlcmVu Y2VfYmxvYihibG9iKTsKPiArCQlzdGF0ZS0+bW9kZV9jaGFuZ2VkID0gdHJ1ZTsKPiArCQlzdGF0 ZS0+ZW5hYmxlID0gdHJ1ZTsKPiArCX0gZWxzZSB7Cj4gKwkJbWVtc2V0KCZzdGF0ZS0+bW9kZSwg MCwgc2l6ZW9mKHN0YXRlLT5tb2RlKSk7Cj4gKwo+ICsJCWlmIChzdGF0ZS0+ZW5hYmxlKQo+ICsJ CQlzdGF0ZS0+bW9kZV9jaGFuZ2VkID0gdHJ1ZTsKClNhbWUgY29tbWVudCBhcyBpbiB0aGUgcHJl dmlvdXMgcGF0Y2g6IG1vZGVfY2hhbmdlZCBpc250JyB0aGUgY29yZSBhdG9taWMKY29kZSdzIGJ1 c2luZXNzLgoKPiArCQlzdGF0ZS0+ZW5hYmxlID0gZmFsc2U7Cj4gKwkJc3RhdGUtPmFjdGl2ZSA9 IGZhbHNlOwo+ICsJfQo+ICsKPiArCWlmIChzdGF0ZS0+ZW5hYmxlKQo+ICsJCURSTV9ERUJVR19B VE9NSUMoIlNldCBbTU9ERTolc10gZm9yIENSVEMgc3RhdGUgJXBcbiIsCj4gKwkJCQkgc3RhdGUt Pm1vZGUubmFtZSwgc3RhdGUpOwo+ICsJZWxzZQo+ICsJCURSTV9ERUJVR19BVE9NSUMoIlNldCBb Tk9NT0RFXSBmb3IgQ1JUQyBzdGF0ZSAlcFxuIiwKPiArCQkJCSBzdGF0ZSk7Cj4gKwo+ICsJcmV0 dXJuIDA7Cj4gK30KPiArRVhQT1JUX1NZTUJPTChkcm1fYXRvbWljX3NldF9tb2RlX3Byb3BfZm9y X2NydGMpOwo+ICAKPiAgLyoqCj4gICAqIGRybV9hdG9taWNfY3J0Y19zZXRfcHJvcGVydHkgLSBz ZXQgcHJvcGVydHkgb24gQ1JUQwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0 b21pY19oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gaW5k ZXggNzBjZTI0My4uNWQ1OTZkOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0 b21pY19oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5j Cj4gQEAgLTIwMjcsNiArMjAyNyw4IEBAIEVYUE9SVF9TWU1CT0woZHJtX2F0b21pY19oZWxwZXJf Y29ubmVjdG9yX2RwbXMpOwo+ICAgKi8KPiAgdm9pZCBkcm1fYXRvbWljX2hlbHBlcl9jcnRjX3Jl c2V0KHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiAgewo+ICsJaWYgKGNydGMtPnN0YXRlICYmIGNy dGMtPnN0YXRlLT5tb2RlX2Jsb2IpCj4gKwkJZHJtX3Byb3BlcnR5X3VucmVmZXJlbmNlX2Jsb2Io Y3J0Yy0+c3RhdGUtPm1vZGVfYmxvYik7Cj4gIAlrZnJlZShjcnRjLT5zdGF0ZSk7Cj4gIAljcnRj LT5zdGF0ZSA9IGt6YWxsb2Moc2l6ZW9mKCpjcnRjLT5zdGF0ZSksIEdGUF9LRVJORUwpOwo+ICAK PiBAQCAtMjA0OCw2ICsyMDUwLDggQEAgdm9pZCBfX2RybV9hdG9taWNfaGVscGVyX2NydGNfZHVw bGljYXRlX3N0YXRlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgewo+ICAJbWVtY3B5KHN0YXRl LCBjcnRjLT5zdGF0ZSwgc2l6ZW9mKCpzdGF0ZSkpOwo+ICAKPiArCWlmIChzdGF0ZS0+bW9kZV9i bG9iKQo+ICsJCWRybV9wcm9wZXJ0eV9yZWZlcmVuY2VfYmxvYihzdGF0ZS0+bW9kZV9ibG9iKTsK PiAgCXN0YXRlLT5tb2RlX2NoYW5nZWQgPSBmYWxzZTsKPiAgCXN0YXRlLT5hY3RpdmVfY2hhbmdl ZCA9IGZhbHNlOwo+ICAJc3RhdGUtPnBsYW5lc19jaGFuZ2VkID0gZmFsc2U7Cj4gQEAgLTIwOTAs MTEgKzIwOTQsOCBAQCBFWFBPUlRfU1lNQk9MKGRybV9hdG9taWNfaGVscGVyX2NydGNfZHVwbGlj YXRlX3N0YXRlKTsKPiAgdm9pZCBfX2RybV9hdG9taWNfaGVscGVyX2NydGNfZGVzdHJveV9zdGF0 ZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAkJCQkJICAgIHN0cnVjdCBkcm1fY3J0Y19zdGF0 ZSAqc3RhdGUpCj4gIHsKPiAtCS8qCj4gLQkgKiBUaGlzIGlzIGN1cnJlbnRseSBhIHBsYWNlaG9s ZGVyIHNvIHRoYXQgZHJpdmVycyB0aGF0IHN1YmNsYXNzIHRoZQo+IC0JICogc3RhdGUgd2lsbCBh dXRvbWF0aWNhbGx5IGRvIHRoZSByaWdodCB0aGluZyBpZiBjb2RlIGlzIGV2ZXIgYWRkZWQKPiAt CSAqIHRvIHRoaXMgZnVuY3Rpb24uCj4gLQkgKi8KPiArCWlmIChzdGF0ZS0+bW9kZV9ibG9iKQo+ ICsJCWRybV9wcm9wZXJ0eV91bnJlZmVyZW5jZV9ibG9iKHN0YXRlLT5tb2RlX2Jsb2IpOwo+ICB9 Cj4gIEVYUE9SVF9TWU1CT0woX19kcm1fYXRvbWljX2hlbHBlcl9jcnRjX2Rlc3Ryb3lfc3RhdGUp Owo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMgYi9kcml2ZXJz L2dwdS9kcm0vZHJtX2NydGMuYwo+IGluZGV4IDkyNjNiMjIuLmVlODcwNDUgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X2NydGMuYwo+IEBAIC0xOTYxLDcgKzE5NjEsOCBAQCBpbnQgZHJtX21vZGVfZ2V0Y3J0YyhzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJCWNydGNfcmVzcC0+eCA9IGNydGMtPnByaW1hcnktPnN0 YXRlLT5zcmNfeCA+PiAxNjsKPiAgCQljcnRjX3Jlc3AtPnkgPSBjcnRjLT5wcmltYXJ5LT5zdGF0 ZS0+c3JjX3kgPj4gMTY7Cj4gIAkJaWYgKGNydGMtPnN0YXRlLT5lbmFibGUpIHsKPiAtCQkJZHJt X21vZGVfY29udmVydF90b191bW9kZSgmY3J0Y19yZXNwLT5tb2RlLCAmY3J0Yy0+c3RhdGUtPm1v ZGUpOwo+ICsJCQltZW1jcHkoJmNydGNfcmVzcC0+bW9kZSwgJmNydGMtPnN0YXRlLT5tb2RlX2Js b2ItPmRhdGEsCj4gKwkJCSAgICAgICBzaXplb2YoY3J0Y19yZXNwLT5tb2RlKSk7CgpXaHkgdGhp cyBjaGFuZ2U/IFdoaWxlIHRyYW5zaXRpb25pbmcgSSdkIGV4cGVjdCB0aGF0IHNvbWUgZHJpdmVy IChwcm9iYWJseQp0aGUgb25lIHdpdGggaHcgc3RhdGUgcmVhZG91dCkgd2lsbCBnZXQgdGhpcyB3 cm9uZywgaW1vIHNhZmVyIHRvIGtlZXAKbG9va2luZyBhdCBjcnRjLT5zdGF0ZS0+bW9kZS4KCmxn dG0gb3RoZXJ3aXNlLgotRGFuaWVsCgo+ICAJCQljcnRjX3Jlc3AtPm1vZGVfdmFsaWQgPSAxOwo+ ICAKPiAgCQl9IGVsc2Ugewo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fY3J0Yy5oIGIv aW5jbHVkZS9kcm0vZHJtX2NydGMuaAo+IGluZGV4IDcyYjYwZGIuLmM1NGZhNGEgMTAwNjQ0Cj4g LS0tIGEvaW5jbHVkZS9kcm0vZHJtX2NydGMuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9jcnRj LmgKPiBAQCAtMjk5LDYgKzI5OSw5IEBAIHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSB7Cj4gIAo+ICAJ c3RydWN0IGRybV9kaXNwbGF5X21vZGUgbW9kZTsKPiAgCj4gKwkvKiBibG9iIHByb3BlcnR5IHRv IGV4cG9zZSBjdXJyZW50IG1vZGUgdG8gYXRvbWljIHVzZXJzcGFjZSAqLwo+ICsJc3RydWN0IGRy bV9wcm9wZXJ0eV9ibG9iICptb2RlX2Jsb2I7Cj4gKwo+ICAJc3RydWN0IGRybV9wZW5kaW5nX3Zi bGFua19ldmVudCAqZXZlbnQ7Cj4gIAo+ICAJc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRl Owo+IC0tIAo+IDIuNC4xCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRl bCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=