From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/3] drm/nouveau: Use drm_vblank_on/off consistently Date: Fri, 29 May 2015 19:35:22 +0200 Message-ID: <20150529173521.GY8341@phenom.ffwll.local> References: <1432717471-7879-1-git-send-email-daniel.vetter@ffwll.ch> <556898BE.4090108@gmail.com> <20150529171921.GT8341@phenom.ffwll.local> <5568A097.7020904@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by gabe.freedesktop.org (Postfix) with ESMTP id B1F216EE21 for ; Fri, 29 May 2015 10:32:53 -0700 (PDT) Received: by wgbgq6 with SMTP id gq6so68605795wgb.3 for ; Fri, 29 May 2015 10:32:53 -0700 (PDT) Content-Disposition: inline In-Reply-To: <5568A097.7020904@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mario Kleiner Cc: Daniel Vetter , Intel Graphics Development , DRI Development , Ben Skeggs , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBNYXkgMjksIDIwMTUgYXQgMDc6MjM6MzVQTSArMDIwMCwgTWFyaW8gS2xlaW5lciB3 cm90ZToKPiAKPiAKPiBPbiAwNS8yOS8yMDE1IDA3OjE5IFBNLCBEYW5pZWwgVmV0dGVyIHdyb3Rl Ogo+ID5PbiBGcmksIE1heSAyOSwgMjAxNSBhdCAwNjo1MDowNlBNICswMjAwLCBNYXJpbyBLbGVp bmVyIHdyb3RlOgo+ID4+T24gMDUvMjcvMjAxNSAxMTowNCBBTSwgRGFuaWVsIFZldHRlciB3cm90 ZToKPiA+Pj5Jbgo+ID4+Pgo+ID4+PmNvbW1pdCA5Y2JhNWVmYWI1YTgxNDVhZTZjNTJlYTI3MzU1 M2YwNjljMjk0NDgyCj4gPj4+QXV0aG9yOiBNYXJpbyBLbGVpbmVyIDxtYXJpby5rbGVpbmVyLmRl QGdtYWlsLmNvbT4KPiA+Pj5EYXRlOiAgIFR1ZSBKdWwgMjkgMDI6MzY6NDQgMjAxNCArMDIwMAo+ ID4+Pgo+ID4+PiAgICAgZHJtL25vdXZlYXU6IERpcy9FbmFibGUgdmJsYW5rIGlycXMgZHVyaW5n IHN1c3BlbmQvcmVzdW1lCj4gPj4+Cj4gPj4+ZHJtX3ZibGFua19vbi9vZmYgY2FsbHMgd2hlcmUg YWRkZWQgYXJvdW5kIHN1c3BlbmQvcmVzdW1lIHRvIG1ha2Ugc3VyZQo+ID4+PnZibGFuayBzdGF5 IGRvZXNuJ3QgZ28gYm9vbSBvdmVyIHRoYXQgdHJhbnNpdGlvbi4gQnV0IG5vdXZlYXUgYWxyZWFk eQo+ID4+PnVzZWQgZHJtX3ZibGFua19wcmUvcG9zdF9tb2Rlc2V0IG92ZXIgbW9kZXNldHMuIElu c3RlYWQgdXNlCj4gPj4+ZHJtX3ZibGFua19vbi9vZmYgZXZlcnlod2VyZS4gVGhlIHNsaWdodCBj aGFuZ2UgaGVyZSBpcyB0aGF0IGFmdGVyCj4gPj4+X29mZiBkcm1fdmJsYW5rX2dldCB3aWxsIHJl ZnVzZSB0byB3b3JrIHJpZ2h0IGF3YXksIGJ1dCBub3V2ZWF1Cj4gPj4+ZG9lc24ndCBzZWVtIHRv IGRlcGVuZCB1cG9uIHRoYXQgYW55d2hlcmUgb3V0c2lkZSBvZiB0aGUgcGFnZWZsaXAKPiA+Pj5w YXRocy4KPiA+Pj4KPiA+Pj5UaGUgbG9uZ2VyLXRlcm0gcGxhbiBoZXJlIGlzIHRvIHN3aXRjaCBh bGwga21zIGRyaXZlcnMgdG8KPiA+Pj5kcm1fdmJsYW5rX29uL29mZiBzbyB0aGF0IGNvbW1vbiBj b2RlIGxpa2UgcGVuZGluZyBldmVudCBjbGVhbnVwIGNhbgo+ID4+PmJlIGRvbmUgdGhlcmUsIHdo aWxlIGRybV92YmxhbmtfcHJlL3Bvc3RfbW9kZXNldCB3aWxsIGJlIHB1cmVseQo+ID4+PmRybSBp bnRlcm5hbCBmb3IgdGhlIG9sZCBVTVMgaW9jdGwuCj4gPj4+Cj4gPj4+Tm90ZSB0aGF0IHRoZSBk cm1fdmJsYW5rX29mZiBzdGlsbCBzZWVtcyByZXF1aXJlZCBpbiB0aGUgc3VzcGVuZCBwYXRoCj4g Pj4+c2luY2Ugbm91dmVhdSBkb2Vzbid0IGV4cGxpY2l0bHkgZGlzYWJsZSBjcnRjcy4gQnV0IG9u IHRoZSByZXN1bWUgc2lkZQo+ID4+PmRybV9oZWxwZXJfcmVzdW1lX2ZvcmNlX21vZGUgc2hvdWxk IGVuZCB1cCBjYWxsaW5nIGRybV92Ymxhbmtfb24KPiA+Pj50aHJvdWdoIHRoZSBub3V2ZWF1IGNy dGMgaG9va3MgYWxyZWFkeS4gSGVuY2UgcmVtb3ZlIHRoZSBjYWxsIGluIHRoZQo+ID4+PnJlc3Vt ZSBjb2RlLgo+ID4+Pgo+ID4+PkNjOiBNYXJpbyBLbGVpbmVyIDxtYXJpby5rbGVpbmVyLmRlQGdt YWlsLmNvbT4KPiA+Pj5DYzogQmVuIFNrZWdncyA8YnNrZWdnc0ByZWRoYXQuY29tPgo+ID4+PlNp Z25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+ID4+ Pi0tLQo+ID4+PiAgZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvZGlzcG52MDQvY3J0Yy5jICAgfCA0 ICsrLS0KPiA+Pj4gIGRyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZlYXVfZGlzcGxheS5jIHwg NCAtLS0tCj4gPj4+ICAyIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlv bnMoLSkKPiA+Pj4KPiA+Pj5kaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvZGlz cG52MDQvY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvZGlzcG52MDQvY3J0Yy5jCj4g Pj4+aW5kZXggM2Q5NmI0OWZlNjYyLi5kYWIyNDA2NmZhMjEgMTAwNjQ0Cj4gPj4+LS0tIGEvZHJp dmVycy9ncHUvZHJtL25vdXZlYXUvZGlzcG52MDQvY3J0Yy5jCj4gPj4+KysrIGIvZHJpdmVycy9n cHUvZHJtL25vdXZlYXUvZGlzcG52MDQvY3J0Yy5jCj4gPj4+QEAgLTcwOCw3ICs3MDgsNyBAQCBz dGF0aWMgdm9pZCBudl9jcnRjX3ByZXBhcmUoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ID4+PiAg CWlmIChudl90d29faGVhZHMoZGV2KSkKPiA+Pj4gIAkJTlZTZXRPd25lcihkZXYsIG52X2NydGMt PmluZGV4KTsKPiA+Pj4KPiA+Pj4tCWRybV92YmxhbmtfcHJlX21vZGVzZXQoZGV2LCBudl9jcnRj LT5pbmRleCk7Cj4gPj4+Kwlkcm1fdmJsYW5rX29mZihkZXYsIG52X2NydGMtPmluZGV4KTsKPiA+ Pj4gIAlmdW5jcy0+ZHBtcyhjcnRjLCBEUk1fTU9ERV9EUE1TX09GRik7Cj4gPj4+Cj4gPj4+ICAJ TlZCbGFua1NjcmVlbihkZXYsIG52X2NydGMtPmluZGV4LCB0cnVlKTsKPiA+Pj5AQCAtNzQwLDcg Kzc0MCw3IEBAIHN0YXRpYyB2b2lkIG52X2NydGNfY29tbWl0KHN0cnVjdCBkcm1fY3J0YyAqY3J0 YykKPiA+Pj4gICNlbmRpZgo+ID4+Pgo+ID4+PiAgCWZ1bmNzLT5kcG1zKGNydGMsIERSTV9NT0RF X0RQTVNfT04pOwo+ID4+Pi0JZHJtX3ZibGFua19wb3N0X21vZGVzZXQoZGV2LCBudl9jcnRjLT5p bmRleCk7Cj4gPj4+Kwlkcm1fdmJsYW5rX29uKGRldiwgbnZfY3J0Yy0+aW5kZXgpOwo+ID4+PiAg fQo+ID4+Cj4gPj5UaGUgYWJvdmUgaHVuayBpcyBwcm9iYWJseSBjb3JyZWN0LCBidXQgaSBjb3Vs ZG4ndCB0ZXN0IGl0IHdpdGhvdXQKPiA+PnN1ZmZpY2llbnRseSBvbGQgcHJlLW52IDUwIGhhcmR3 YXJlLgo+ID4+Cj4gPj4+Cj4gPj4+ICBzdGF0aWMgdm9pZCBudl9jcnRjX2Rlc3Ryb3koc3RydWN0 IGRybV9jcnRjICpjcnRjKQo+ID4+PmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbm91dmVh dS9ub3V2ZWF1X2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZlYXVfZGlz cGxheS5jCj4gPj4+aW5kZXggODY3MGQ5MGNkYzExLi5kODI0MDIzZjlmYzYgMTAwNjQ0Cj4gPj4+ LS0tIGEvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbm91dmVhdV9kaXNwbGF5LmMKPiA+Pj4rKysg Yi9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9ub3V2ZWF1X2Rpc3BsYXkuYwo+ID4+PkBAIC02MjAs MTAgKzYyMCw2IEBAIG5vdXZlYXVfZGlzcGxheV9yZXN1bWUoc3RydWN0IGRybV9kZXZpY2UgKmRl diwgYm9vbCBydW50aW1lKQo+ID4+PiAgCQludl9jcnRjLT5sdXQuZGVwdGggPSAwOwo+ID4+PiAg CX0KPiA+Pj4KPiA+Pj4tCS8qIE1ha2Ugc3VyZSB0aGF0IGRybSBhbmQgaHcgdmJsYW5rIGlycXMg Z2V0IHJlc3VtZWQgaWYgbmVlZGVkLiAqLwo+ID4+Pi0JZm9yIChoZWFkID0gMDsgaGVhZCA8IGRl di0+bW9kZV9jb25maWcubnVtX2NydGM7IGhlYWQrKykKPiA+Pj4tCQlkcm1fdmJsYW5rX29uKGRl diwgaGVhZCk7Cj4gPj4+LQo+ID4+PiAgCS8qIFRoaXMgc2hvdWxkIGVuc3VyZSB3ZSBkb24ndCBo aXQgYSBsb2NraW5nIHByb2JsZW0gd2hlbiBzb21lb25lCj4gPj4+ICAJICogd2FrZXMgdXMgdXAg dmlhIGEgY29ubmVjdG9yLiAgV2Ugc2hvdWxkIG5ldmVyIGdvIGludG8gc3VzcGVuZAo+ID4+PiAg CSAqIHdoaWxlIHRoZSBkaXNwbGF5IGlzIG9uIGFueXdheXMuCj4gPj4+Cj4gPj4KPiA+PlRlc3Rl ZCB0aGlzIG9uZSBhbmQgdGhpcyBodW5rIGJyZWFrcyBzdXNwZW5kL3Jlc3VtZS4gQWZ0ZXIgYSBz dXNwZW5kL3Jlc3VtZQo+ID4+Y3ljbGUsIGFsbCBPcGVuR0wgYXBwcyBhbmQgY29tcG9zaXRlZCBk ZXNrdG9wIGFyZSBkZWFkLCBhcyB0aGUgY29yZSBjYW4ndAo+ID4+Z2V0IGFueSB2YmxhbmsgaXJx J3MgZW5hYmxlZCBhbnltb3JlLgo+ID4+Cj4gPj5TbyB0aGUgZHJtX3ZibGFua19vbigpIGlzIHN0 aWxsIG5lZWRlZCBoZXJlLgo+ID4KPiA+SG0gdGhhdCdzIHZlcnkgc3VycHJpc2luZy4gQXMgbWVu dGlvbmVkIGFib3ZlIHRoZSBmb3JjZV9tb2RlX3Jlc3RvcmUKPiA+c2hvdWxkIGJlIGNhbGxpbmcg bnZfY3J0Y19wcmVwYXJlIGFscmVhZHkgYW5kIGZpeCB0aGlzIGFsbCB1cCBmb3IgdXMuIEkKPiA+ Z3Vlc3MgSSBuZWVkIHRvIGRpZyBvdXQgbXkgbnYgY2FyZCBhbmQgdHJhY2Ugd2hhdCdzIHJlYWxs eSBnb2luZyBvbiBoZXJlLgo+ID4KPiA+RW5hYmxpbmcgaW50ZXJydXB0cyB3aGVuIHRoZSBjcnRj IGlzIG9mZiBpc24ndCBhIGdvb2QgaWRlYS4KPiA+LURhbmllbAo+ID4KPiAKPiBJIHRoaW5rIHRo ZSBudl9jcnRjX3ByZXBhcmUoKSBwYXRoIG1vZGlmaWVkIGluIHlvdXIgZmlyc3QgaHVuayBpcyBv bmx5IGZvcgo+IHRoZSBvcmlnaW5hbCBudjA0IGRpc3BsYXkgZW5naW5lIGZvciB2ZXJ5IG9sZCBj YXJkcy4gbnY1MCsgKEdlRm9yY2UtOCBhbmQKPiBsYXRlcikgdGFrZSBkaWZmZXJlbnQgcGF0aHMu CgpPaCByaWdodCB0b3RhbGx5IG1pc3NlZCB0aGUgbnY1MCsgY29kZS4gSSBvbmx5IGdyZXBwZWQg Zm9yCnByZS9wb3N0X21vZGVzZXQgLi4uCgpCZWxvdyB1bnRlc3RlZCBkaWZmIHNob3VsZCBoZWxw LiBJIGFsc28gcmVhbGl6ZWQgdGhhdCB0aGUgcHJlLW52NTAgY29kZQpsYWNrcyBkcm1fdmJsYW5r X29uL29mZiBpbiB0aGUgZHBtcyBjYWxsYmFjaywgc28gdGhlcmUncyBtb3JlIHdvcmsgdG8gZG8K YW55d2F5IGZvciB0aGlzIG9uZSBoZXJlLgoKVGhhbmtzLCBEYW5pZWwKCmRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vbm91dmVhdS9udjUwX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9u b3V2ZWF1L252NTBfZGlzcGxheS5jCmluZGV4IDdkYTc5NTg1NTZhMy4uYTE2YzM3ZDhmN2UxIDEw MDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9udjUwX2Rpc3BsYXkuYworKysgYi9k cml2ZXJzL2dwdS9kcm0vbm91dmVhdS9udjUwX2Rpc3BsYXkuYwpAQCAtOTk3LDYgKzk5NywxMCBA QCBudjUwX2NydGNfY3Vyc29yX3Nob3dfaGlkZShzdHJ1Y3Qgbm91dmVhdV9jcnRjICpudl9jcnRj LCBib29sIHNob3csIGJvb2wgdXBkYXRlKQogc3RhdGljIHZvaWQKIG52NTBfY3J0Y19kcG1zKHN0 cnVjdCBkcm1fY3J0YyAqY3J0YywgaW50IG1vZGUpCiB7CisJaWYgKG1vZGUgPT0gRFJNX01PREVf RFBNU19PTikKKwkJZHJtX2NydGNfdmJsYW5rX29uKGNydGMpOworCWVsc2UKKwkJZHJtX2NydGNf dmJsYW5rX29mZihjcnRjKTsKIH0KIAogc3RhdGljIHZvaWQKQEAgLTEwMzYsNiArMTA0MCw4IEBA IG52NTBfY3J0Y19wcmVwYXJlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKIAl9CiAKIAludjUwX2Ny dGNfY3Vyc29yX3Nob3dfaGlkZShudl9jcnRjLCBmYWxzZSwgZmFsc2UpOworCisJZHJtX2NydGNf dmJsYW5rX29uKGNydGMpOwogfQogCiBzdGF0aWMgdm9pZApAQCAtMTA0NSw2ICsxMDUxLDggQEAg bnY1MF9jcnRjX2NvbW1pdChzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCiAJc3RydWN0IG52NTBfbWFz dCAqbWFzdCA9IG52NTBfbWFzdChjcnRjLT5kZXYpOwogCXUzMiAqcHVzaDsKIAorCWRybV9jcnRj X3ZibGFua19vbihjcnRjKTsKKwogCXB1c2ggPSBldm9fd2FpdChtYXN0LCAzMik7CiAJaWYgKHB1 c2gpIHsKIAkJaWYgKG52NTBfdmVycyhtYXN0KSA8IEc4Ml9ESVNQX0NPUkVfQ0hBTk5FTF9ETUEp IHsKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9u Cmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg==