From: Thierry Reding <thierry.reding@gmail.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Ben Skeggs <bskeggs@redhat.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/nouveau/disp: Use NULL for pointers
Date: Fri, 5 Jun 2015 13:33:43 +0200 [thread overview]
Message-ID: <20150605113342.GE17776@ulmo.nvidia.com> (raw)
In-Reply-To: <543C2529.2080708@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1467 bytes --]
On Mon, Oct 13, 2014 at 08:16:57PM +0100, Emil Velikov wrote:
> On 13/10/14 12:47, Thierry Reding wrote:
> > On Mon, Jul 21, 2014 at 02:02:58PM +0200, Thierry Reding wrote:
> >> From: Thierry Reding <treding@nvidia.com>
> >>
> >> The return type of exec_lookup() is struct nvkm_output *, so it should
> >> return NULL rather than 0.
> >>
> >> Signed-off-by: Thierry Reding <treding@nvidia.com>
> >> ---
> >> drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c b/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c
> >> index fa30d8196f35..ebf64e1d0a70 100644
> >> --- a/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c
> >> +++ b/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c
> >> @@ -939,7 +939,7 @@ exec_lookup(struct nv50_disp_priv *priv, int head, int or, u32 ctrl,
> >> case 0x00000900: type = DCB_OUTPUT_DP; mask = 2; break;
> >> default:
> >> nv_error(priv, "unknown SOR mc 0x%08x\n", ctrl);
> >> - return 0x0000;
> >> + return NULL;
> >> }
> >> }
> >>
> >
> > Ping?
> >
> > Thierry
> >
> I have an identical patch in a local branch, but with worse commit
> message :) Fwiw the patch is
>
> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
Ben, any chance you could pick this up? It should still apply as-is on
recent trees, but I can resend if you prefer.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-06-05 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 12:02 [PATCH] drm/nouveau/disp: Use NULL for pointers Thierry Reding
2014-10-13 11:47 ` Thierry Reding
2014-10-13 19:16 ` Emil Velikov
2015-06-05 11:33 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150605113342.GE17776@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox