From: Thierry Reding <thierry.reding@gmail.com>
To: Dave Airlie <airlied@gmail.com>
Cc: "Stéphane Marchesin" <marcheu@chromium.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v3] drm/tegra: Use 64-bit offset for tegra_gem_mmap
Date: Mon, 29 Jun 2015 10:50:00 +0200 [thread overview]
Message-ID: <20150629084959.GB5431@ulmo> (raw)
In-Reply-To: <CAPM=9twjVOeMXU6rOow7rJvNr9keg8-LcQ-n94xT5_5ULp4MFQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1052 bytes --]
On Mon, Jun 29, 2015 at 02:16:17PM +1000, Dave Airlie wrote:
> On 6 February 2015 at 22:18, Thierry Reding <thierry.reding@gmail.com> wrote:
> > On Fri, Jan 30, 2015 at 01:57:01PM -0500, Sean Paul wrote:
> >> On 64-bit targets, tegra_gem_mmap doesn't return the
> >> offset to userspace. As such, subsequent calls to mmap(2)
> >> fail. Alter the args to use 64-bit offset to fix this.
> >>
> >> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> >> ---
> >> include/uapi/drm/tegra_drm.h | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > I've applied this with a slightly tweaked commit message.
>
> Doesn't that break 32-bit ABI?
Yes it does. This was discussed earlier in this thread. The original
patch was to add a separate IOCTL to be used on 64-bit architectures
because the 32-bit IOCTL was broken. After some discussion everybody
involved agreed that it'd be best to fix the IOCTL while we can (the
driver-specific IOCTLs in the Tegra driver are all guarded by the
STAGING Kconfig symbol).
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-06-29 8:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 18:46 [PATCH] drm/tegra: Add tegra_gem_mmap2 to fix 64-bit offsets Sean Paul
2015-01-29 18:55 ` Rob Clark
2015-01-29 19:18 ` [PATCH v2] " Sean Paul
2015-01-29 20:11 ` Rob Clark
2015-01-30 9:49 ` Thierry Reding
2015-01-30 10:15 ` Erik Faye-Lund
2015-01-30 10:21 ` Thierry Reding
2015-01-30 11:41 ` Emil Velikov
2015-01-30 18:57 ` [PATCH v3] drm/tegra: Use 64-bit offset for tegra_gem_mmap Sean Paul
2015-02-06 12:18 ` Thierry Reding
2015-06-28 20:54 ` Dmitry
2015-06-29 8:46 ` Thierry Reding
2015-06-29 4:16 ` Dave Airlie
2015-06-29 8:50 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150629084959.GB5431@ulmo \
--to=thierry.reding@gmail.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=marcheu@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox