From: Daniel Vetter <daniel@ffwll.ch>
To: Shixin Zeng <zeng.shixin@gmail.com>
Cc: Daniel Stone <daniels@collabora.com>, dri-devel@lists.freedesktop.org
Subject: Re: [DRM] Fix a regression caused by a typo
Date: Fri, 3 Jul 2015 08:44:41 +0200 [thread overview]
Message-ID: <20150703064441.GF23343@phenom.ffwll.local> (raw)
In-Reply-To: <1435863439-28660-1-git-send-email-szeng@atronixengineering.com>
On Thu, Jul 02, 2015 at 02:57:19PM -0400, Shixin Zeng wrote:
> From: Shixin Zeng <zeng.shixin@gmail.com>
>
> The length of each EDID block is EDID_LENGTH, and number of blocks is (1
> + edid->extensions)
>
> This causes wrong EDID to be passed on, and is a regression introduced
> by d2ed34362a52 (drm: Introduce helper for replacing blob properties)
When fixing a regression, please cc the people who wrote/reviewed the
offending patch. Added them and merged the patch to topic/drm-fixes.
Thanks, Daniel
>
> Signed-off-by: Shixin Zeng <zeng.shixin@gmail.com>
> ---
> drivers/gpu/drm/drm_crtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index b69ed97..b9ba061 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -4732,7 +4732,7 @@ int drm_mode_connector_update_edid_property(struct drm_connector *connector,
> return 0;
>
> if (edid)
> - size = EDID_LENGTH + (1 + edid->extensions);
> + size = EDID_LENGTH * (1 + edid->extensions);
>
> ret = drm_property_replace_global_blob(dev,
> &connector->edid_blob_ptr,
> --
> 2.4.5
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-03 6:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 18:57 [DRM] Fix a regression caused by a typo Shixin Zeng
2015-07-03 6:44 ` Daniel Vetter [this message]
2015-07-03 6:45 ` Daniel Vetter
2015-07-03 7:23 ` Daniel Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150703064441.GF23343@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=zeng.shixin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox