From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH libdrm 2/4] omap: zero is a valid fd number, treat it as such Date: Wed, 15 Jul 2015 13:30:50 +0200 Message-ID: <20150715113049.GB15045@ulmo.nvidia.com> References: <1436883005-6163-1-git-send-email-emil.l.velikov@gmail.com> <1436883005-6163-2-git-send-email-emil.l.velikov@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1388969236==" Return-path: Received: from mail-pd0-f182.google.com (mail-pd0-f182.google.com [209.85.192.182]) by gabe.freedesktop.org (Postfix) with ESMTPS id 09FF56E25D for ; Wed, 15 Jul 2015 04:31:04 -0700 (PDT) Received: by pdrg1 with SMTP id g1so23642139pdr.2 for ; Wed, 15 Jul 2015 04:31:03 -0700 (PDT) In-Reply-To: <1436883005-6163-2-git-send-email-emil.l.velikov@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1388969236== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gatW/ieO32f1wygP" Content-Disposition: inline --gatW/ieO32f1wygP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 14, 2015 at 03:10:03PM +0100, Emil Velikov wrote: > Equivalent to the previous patch. >=20 > Cc: Rob Clark > Cc: Thierry Reding > Suggested-by: Thierry Reding > Signed-off-by: Emil Velikov > --- > omap/omap_drm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Thierry Reding > diff --git a/omap/omap_drm.c b/omap/omap_drm.c > index ff83a93..4a0248d 100644 > --- a/omap/omap_drm.c > +++ b/omap/omap_drm.c > @@ -363,7 +363,7 @@ void omap_bo_del(struct omap_bo *bo) > munmap(bo->map, bo->size); > } > =20 > - if (bo->fd) { > + if (bo->fd >=3D 0) { > close(bo->fd); > } > =20 > @@ -414,7 +414,7 @@ uint32_t omap_bo_handle(struct omap_bo *bo) > */ > int omap_bo_dmabuf(struct omap_bo *bo) > { > - if (!bo->fd) { > + if (bo->fd < 0) { > struct drm_prime_handle req =3D { > .handle =3D bo->handle, > .flags =3D DRM_CLOEXEC, > --=20 > 2.4.5 >=20 --gatW/ieO32f1wygP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVpkRpAAoJEN0jrNd/PrOhsCsP/3ZA1j8kXl6U2AxkJBiLfRMp rR9FcJBZauj27uFjqcr0GAXyEyaZM+YiavqakBHnmRAhtWN6EauW153DyZrlxaFh edePGJK1ufnLEohrYL23wKxynvIS/IYm/twkkYYNZF5mIJcyMSMxWjvSHIHxVGqW VLk+AipF3UaCZayVQ1q/hoi97mwI7tqNFYbMslj5dDjVq/F5MN+BLoxq/TH4+SoE CFy66FaRq6RKpgwlyXr2/g8sRKgCUwIrczfRO9D8f5CgDUB6dWJ78T6nSdOtbDqZ wAMc3GkIqhTCVJDC3nx9lHSTMQ8mGRr7mB7iCPlfpeewVR+iNHU5p1JtRmcalSa1 j6y6kFBLtmSRmREhxZQG/CmegkqGdkprHrOtsQSscOh/DudZfMdAVwXzNit2Xt4w IPtJJF0pQ48XyGHHG5IurSEjxLl70m69Fk893QaGuwuxSNdiH/rQL3hxj9PsTM/D 3E/cX741fNCR+9W0/Y5tCDKLjML81ZFYrjqee+u1pyfFwXF5ze0VA93fxg/HIqvH Ic7xsdaJa4Va2w006Z8eQTZD8xz3LnI1ypUeIZFQVxY9CXCQMDPZ/t4/5B7nx85z 45dqP3ZdQBP32Ol40Fvao0F2CDOxFdbI/IwwzHLUPwuOPNahUYsrkm+7jD6nEqjp 4ETx3JxBf4GHrAkdNP6k =bfQN -----END PGP SIGNATURE----- --gatW/ieO32f1wygP-- --===============1388969236== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1388969236==--