From: Thierry Reding <treding@nvidia.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] tests: modetest: Accept connector names in addition to connector IDs
Date: Tue, 21 Jul 2015 11:05:59 +0200 [thread overview]
Message-ID: <20150721090557.GD20388@ulmo.nvidia.com> (raw)
In-Reply-To: <1437411380-10015-1-git-send-email-laurent.pinchart@ideasonboard.com>
[-- Attachment #1.1: Type: text/plain, Size: 1449 bytes --]
On Mon, Jul 20, 2015 at 07:56:20PM +0300, Laurent Pinchart wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Allow connector names to be used in the specification of the -s option.
> This requires storing the string passed on the command-line so that it
> can later be resolved to a connector ID (after the DRM device has been
> opened).
>
> Connector names are constructed from the connector type name and
> connector type ID using the same format as used internally in the
> Linux kernel.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> tests/modetest/modetest.c | 94 +++++++++++++++++++++++++++++++++++++++++------
> 1 file changed, 82 insertions(+), 12 deletions(-)
>
> I've carried this patch in my tree for too long and I'm now tired of rebasing
> it. It's thus time to get it in mainline.
>
> Compared to the original version developed by Thierry, I've
>
> - rebased the patch on top of latest master
> - dropped dependencies on other WIP patches in Thierry's tree
> - fixed printf alignment
> - used asprintf to simplify name string allocation
> - constructed the connector name using the same format as the Linux kernel
Heh, I started to get all these patches into shape last week, and this
will probably give me more rebase headaches. But I guess that's what I
deserve for letting things slide...
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-21 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 16:56 [PATCH] tests: modetest: Accept connector names in addition to connector IDs Laurent Pinchart
2015-07-21 9:05 ` Thierry Reding [this message]
2015-07-21 12:27 ` Laurent Pinchart
2015-07-21 15:10 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721090557.GD20388@ulmo.nvidia.com \
--to=treding@nvidia.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox