From: Daniel Vetter <daniel@ffwll.ch>
To: Vincent Abriou <vincent.abriou@st.com>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Fabien Dessenne <fabien.dessenne@st.com>,
dri-devel@lists.freedesktop.org, kernel@stlinux.com
Subject: Re: [PATCH 4/4] drm/sti: atomic crtc/plane update
Date: Fri, 31 Jul 2015 15:45:58 +0200 [thread overview]
Message-ID: <20150731134558.GE16722@phenom.ffwll.local> (raw)
In-Reply-To: <1438337607-13122-5-git-send-email-vincent.abriou@st.com>
On Fri, Jul 31, 2015 at 12:13:27PM +0200, Vincent Abriou wrote:
> static struct drm_crtc_helper_funcs sti_crtc_helper_funcs = {
> .dpms = sti_crtc_dpms,
dpms isn't needed any more with atomic, you should use
drm_atomic_helper_connector_dpms instead of drm_helper_connector_dpms.
> - .prepare = sti_crtc_prepare,
> - .commit = sti_crtc_commit,
> + .prepare = sti_crtc_helper_prepare,
prepare is now called .enable for clarity.
> + .commit = sti_crtc_helper_commit,
commit and disable are redundant with atomic.
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-31 13:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 10:13 [PATCH 0/4] drm/sti: update STI driver to be atomic Vincent Abriou
2015-07-31 10:13 ` [PATCH 1/4] drm/sti: fix dynamic z-ordering Vincent Abriou
2015-07-31 10:13 ` [PATCH 2/4] drm/sti: code clean up Vincent Abriou
2015-07-31 10:13 ` [PATCH 3/4] drm/sti: rename files and functions Vincent Abriou
2015-07-31 10:13 ` [PATCH 4/4] drm/sti: atomic crtc/plane update Vincent Abriou
2015-07-31 12:22 ` Emil Velikov
2015-07-31 12:54 ` Benjamin Gaignard
2015-07-31 13:24 ` Emil Velikov
2015-07-31 13:45 ` Daniel Vetter [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-08-03 12:44 Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150731134558.GE16722@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=benjamin.gaignard@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabien.dessenne@st.com \
--cc=kernel@stlinux.com \
--cc=vincent.abriou@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox