From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Sinclair Yeh" <syeh@vmware.com>
Subject: Re: [PATCH 04/15] drivers: gpu: Drop unlikely before IS_ERR(_OR_NULL)
Date: Fri, 31 Jul 2015 08:53:04 -0700
Message-ID: <20150731155228.GA18431@syeh-linux>
References: <cover.1438331416.git.viresh.kumar@linaro.org>
 <1b19585aab58d665973c475677ce5a80fc6aa48c.1438331416.git.viresh.kumar@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from smtp-outbound-1.vmware.com (smtp-outbound-1.vmware.com
 [208.91.2.12])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 7440B6E0B4
 for <dri-devel@lists.freedesktop.org>; Fri, 31 Jul 2015 08:52:39 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1b19585aab58d665973c475677ce5a80fc6aa48c.1438331416.git.viresh.kumar@linaro.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Thomas Hellstrom <thellstrom@vmware.com>, linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, "open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>, Ben Skeggs <bskeggs@redhat.com>, akpm@linux-foundation.org
List-Id: dri-devel@lists.freedesktop.org

VGhpcyBwYXRjaDogIFJldmlld2VkLWJ5OiBTaW5jbGFpciBZZWggPHN5ZWhAdm13YXJlLmNvbT4K
Ck9uIEZyaSwgSnVsIDMxLCAyMDE1IGF0IDAyOjA4OjI0UE0gKzA1MzAsIFZpcmVzaCBLdW1hciB3
cm90ZToKPiBJU19FUlIoX09SX05VTEwpIGFscmVhZHkgY29udGFpbiBhbiAndW5saWtlbHknIGNv
bXBpbGVyIGZsYWcgYW5kIHRoZXJlCj4gaXMgbm8gbmVlZCB0byBkbyB0aGF0IGFnYWluIGZyb20g
aXRzIGNhbGxlcnMuIERyb3AgaXQuCj4gCj4gU2lnbmVkLW9mZi1ieTogVmlyZXNoIEt1bWFyIDx2
aXJlc2gua3VtYXJAbGluYXJvLm9yZz4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3R0bS90dG1f
dHQuYyAgICAgICAgICAgIHwgNCArKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4
X2NvbnRleHQuYyB8IDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfZHJ2LmMg
ICAgIHwgMiArLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlv
bnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3R0bS90dG1fdHQuYyBiL2Ry
aXZlcnMvZ3B1L2RybS90dG0vdHRtX3R0LmMKPiBpbmRleCBiZjA4MGFiYzg2ZDEuLjRlMTlkMGY5
Y2MzMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdHRtL3R0bV90dC5jCj4gKysrIGIv
ZHJpdmVycy9ncHUvZHJtL3R0bS90dG1fdHQuYwo+IEBAIC0zNDAsNyArMzQwLDcgQEAgaW50IHR0
bV90dF9zd2Fwb3V0KHN0cnVjdCB0dG1fdHQgKnR0bSwgc3RydWN0IGZpbGUgKnBlcnNpc3RlbnRf
c3dhcF9zdG9yYWdlKQo+ICAJCXN3YXBfc3RvcmFnZSA9IHNobWVtX2ZpbGVfc2V0dXAoInR0bSBz
d2FwIiwKPiAgCQkJCQkJdHRtLT5udW1fcGFnZXMgPDwgUEFHRV9TSElGVCwKPiAgCQkJCQkJMCk7
Cj4gLQkJaWYgKHVubGlrZWx5KElTX0VSUihzd2FwX3N0b3JhZ2UpKSkgewo+ICsJCWlmIChJU19F
UlIoc3dhcF9zdG9yYWdlKSkgewo+ICAJCQlwcl9lcnIoIkZhaWxlZCBhbGxvY2F0aW5nIHN3YXAg
c3RvcmFnZVxuIik7Cj4gIAkJCXJldHVybiBQVFJfRVJSKHN3YXBfc3RvcmFnZSk7Cj4gIAkJfQo+
IEBAIC0zNTQsNyArMzU0LDcgQEAgaW50IHR0bV90dF9zd2Fwb3V0KHN0cnVjdCB0dG1fdHQgKnR0
bSwgc3RydWN0IGZpbGUgKnBlcnNpc3RlbnRfc3dhcF9zdG9yYWdlKQo+ICAJCWlmICh1bmxpa2Vs
eShmcm9tX3BhZ2UgPT0gTlVMTCkpCj4gIAkJCWNvbnRpbnVlOwo+ICAJCXRvX3BhZ2UgPSBzaG1l
bV9yZWFkX21hcHBpbmdfcGFnZShzd2FwX3NwYWNlLCBpKTsKPiAtCQlpZiAodW5saWtlbHkoSVNf
RVJSKHRvX3BhZ2UpKSkgewo+ICsJCWlmIChJU19FUlIodG9fcGFnZSkpIHsKPiAgCQkJcmV0ID0g
UFRSX0VSUih0b19wYWdlKTsKPiAgCQkJZ290byBvdXRfZXJyOwo+ICAJCX0KPiBkaWZmIC0tZ2l0
IGEvZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfY29udGV4dC5jIGIvZHJpdmVycy9ncHUv
ZHJtL3Ztd2dmeC92bXdnZnhfY29udGV4dC5jCj4gaW5kZXggNWFjOTI4NzQ0MDRkLi40NGU2ZWNi
YTNkZTcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfY29udGV4
dC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfY29udGV4dC5jCj4gQEAg
LTE1OSw3ICsxNTksNyBAQCBzdGF0aWMgaW50IHZtd19nYl9jb250ZXh0X2luaXQoc3RydWN0IHZt
d19wcml2YXRlICpkZXZfcHJpdiwKPiAgCj4gIAlpZiAoZGV2X3ByaXYtPmhhc19tb2IpIHsKPiAg
CQl1Y3R4LT5tYW4gPSB2bXdfY21kYnVmX3Jlc19tYW5fY3JlYXRlKGRldl9wcml2KTsKPiAtCQlp
ZiAodW5saWtlbHkoSVNfRVJSKHVjdHgtPm1hbikpKSB7Cj4gKwkJaWYgKElTX0VSUih1Y3R4LT5t
YW4pKSB7Cj4gIAkJCXJldCA9IFBUUl9FUlIodWN0eC0+bWFuKTsKPiAgCQkJdWN0eC0+bWFuID0g
TlVMTDsKPiAgCQkJZ290byBvdXRfZXJyOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v
dm13Z2Z4L3Ztd2dmeF9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4X2Rydi5j
Cj4gaW5kZXggNjIwYmI1Y2Y2MTdjLi42MjE4YTM2Y2YwMWEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy
cy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vdm13
Z2Z4L3Ztd2dmeF9kcnYuYwo+IEBAIC0xMDU0LDcgKzEwNTQsNyBAQCBzdGF0aWMgbG9uZyB2bXdf
Z2VuZXJpY19pb2N0bChzdHJ1Y3QgZmlsZSAqZmlscCwgdW5zaWduZWQgaW50IGNtZCwKPiAgCQly
ZXR1cm4gLUVJTlZBTDsKPiAgCj4gIAl2bWFzdGVyID0gdm13X21hc3Rlcl9jaGVjayhkZXYsIGZp
bGVfcHJpdiwgZmxhZ3MpOwo+IC0JaWYgKHVubGlrZWx5KElTX0VSUih2bWFzdGVyKSkpIHsKPiAr
CWlmIChJU19FUlIodm1hc3RlcikpIHsKPiAgCQlyZXQgPSBQVFJfRVJSKHZtYXN0ZXIpOwo+ICAK
PiAgCQlpZiAocmV0ICE9IC1FUkVTVEFSVFNZUykKPiAtLSAKPiAyLjQuMAo+IApfX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs
aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr
dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=