From: Daniel Vetter <daniel@ffwll.ch>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH 0/2] drm/fb-helper: Silence defined but not used warning
Date: Tue, 4 Aug 2015 15:49:33 +0200 [thread overview]
Message-ID: <20150804134933.GJ24689@phenom.ffwll.local> (raw)
In-Reply-To: <1438694531-11116-1-git-send-email-geert@linux-m68k.org>
On Tue, Aug 04, 2015 at 03:22:09PM +0200, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Hi,
>
> If CONFIG_MAGIC_SYSRQ is not set:
>
> drivers/gpu/drm/drm_fb_helper.c:390:13: warning: 'drm_fb_helper_force_kernel_mode' defined but not used [-Wunused-function]
> static bool drm_fb_helper_force_kernel_mode(void)
> ^
>
> As just silencing this warning would require moving two functions (one
> of them having obsolete documentation) inside the #ifdef, I fixed the
> documentation first.
>
> This patch series is against next-20150803.
>
> Geert Uytterhoeven (2):
> drm/fb-helper: Clarify drm_fb_helper_restore_fbdev_mode*()
> drm/fb-helper: Move drm_fb_helper_force_kernel_mode() inside #ifdef
Thanks, both applied to drm-misc.
-Daniel
>
> drivers/gpu/drm/drm_fb_helper.c | 71 ++++++++++++++++-------------------------
> 1 file changed, 28 insertions(+), 43 deletions(-)
>
> --
> 1.9.1
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-08-04 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 13:22 [PATCH 0/2] drm/fb-helper: Silence defined but not used warning Geert Uytterhoeven
2015-08-04 13:22 ` [PATCH 1/2] drm/fb-helper: Clarify drm_fb_helper_restore_fbdev_mode*() Geert Uytterhoeven
2015-08-04 13:22 ` [PATCH 2/2] drm/fb-helper: Move drm_fb_helper_force_kernel_mode() inside #ifdef Geert Uytterhoeven
2015-08-04 13:49 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804134933.GJ24689@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox