From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: Use CPU mapping for userspace dma-buf mmap() Date: Thu, 6 Aug 2015 15:17:10 +0200 Message-ID: <20150806131710.GQ17734@phenom.ffwll.local> References: <1438375344-4954-1-git-send-email-tiago.vignatti@intel.com> <1438375344-4954-2-git-send-email-tiago.vignatti@intel.com> <20150731210234.GA16824@nuc-i3427.alporthouse.com> <55C12EF1.7080701@intel.com> <20150805070810.GL24689@phenom.ffwll.local> <55C26DA9.9020907@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <55C26DA9.9020907@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tiago Vignatti Cc: daniel.thompson@linaro.org, daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBdWcgMDUsIDIwMTUgYXQgMDU6MTA6MTdQTSAtMDMwMCwgVGlhZ28gVmlnbmF0dGkg d3JvdGU6Cj4gT24gMDgvMDUvMjAxNSAwNDowOCBBTSwgRGFuaWVsIFZldHRlciB3cm90ZToKPiA+ T24gVHVlLCBBdWcgMDQsIDIwMTUgYXQgMDY6MzA6MjVQTSAtMDMwMCwgVGlhZ28gVmlnbmF0dGkg d3JvdGU6Cj4gPk5haCB0aGV5IGRvbid0IGhhdmUgdG8gYmUgZXF1YWwgc2luY2UgdGhlIHByb2Js ZW0gaXNuJ3QgdGhhdCBub3RoaW5nIGdvZXMKPiA+b3V0IHRvIG1lbW9yeSB3aGVyZSB0aGUgZGlz cGxheSBjYW4gc2VlIGl0LCBidXQgdXN1YWxseSBvbmx5IHBhcnRzIG9mIGl0Lgo+ID5JLmUuIHlv dSBuZWVkIHRvIGNoYW5nZSB5b3VyIHRlc3QgdG8KPiA+LSBkcmF3IGJsYWNrIHNjcmVlbiAoaXQg c3RhcnRzIHRoYXQgd2F5IHNvIG5vdGhpbmcgdG8gZG8gcmVhbGx5KSwgZ3JhYiBjcnRjCj4gPi0g ZHJhdyB3aGl0ZSBzY3JlZW4gYW5kIG1ha2Ugc3VyZSB5b3UgZmx1c2ggY29ycmVjdGx5LCBkb24n dCBib3RoZXIgd2l0aAo+ID4gICBjcmMgKHdlIGNhbid0IHRlc3QgZm9yIGluZXF1YWxpdHkKPiA+ ICAgYmVjYXVzZSBjb2xsaXNpb25zIGFyZSB0b28gZWFzeSkKPiA+LSBkcmF3IGJsYWNrIHNjcmVl biBhZ2FpbiB3aXRob3V0IGZsdXNoaW5nLCBncmFiIGNyYwo+ID4KPiA+VGhlbiBhc3NlcnQgdGhh dCB5b3VyIHR3byBjcmMgd2lsbCBiZSBpbmVxdWFsICh3aGljaCB0aGV5IHNob3VsZG4ndCBiZQo+ ID5iZWNhdXNlIHNvbWUgY2FjaGVsaW5lcyB3aWxsIHN0aWxsIGJlIHN0dWNrKS4gTWF5YmUgYWxz byBhZGQgYSBkZWxheQo+ID5zb21ld2hlcmUgc28geW91IGNhbiBzZWUgdGhlIGNhY2hlbGluZSBk aXJ0IHBhdHRlcm4sIGl0J3MgdmVyeQo+ID5jaGFyYWN0ZXJpc3RpYy4KPiAKPiBDb29sLCBJJ3Zl IGdvdCBpdCBub3cuIFRoZSB0ZXN0IGJlbG93IG1ha2VzIHRoZSBjYWNoZWxpbmVzIGRpcnQsIHJl cXVpcmluZwo+IHRoZW0gdG8gZ2V0IGZsdXNoZWQgY29ycmVjdGx5IC0tIEknbGwgd29yayBvbiBp dCBub3cuIFNob3VsZCB3ZSBhZGQgdGhhdAo+IGtpbmQgb2YgdGVzdCBzb21ld2hlcmUgaW4gaWd0 IEJUVz8KClllYWggaWYgeW91IGV4cGVjdCBtZSB0byBtZXJnZSBkbWEtYnVmIG1tYXAgd2l0aCB0 aGUgYmVnaW4vZW5kIHN0dWZmIEknbGwKYXNrIGZvciBhbiBpZ3QgZm9yIGl0IDstKQoKPiBQUzog SSBoYWQgYW4gaXNzdWUgd2l0aCB0aGUgb3JpZ2luYWwga21zX3B3cml0ZV9jcmMgd2hpY2ggcmV0 dXJucyBmcmVxdWVudAo+IGZhaWxzLiBQYXVsbyBoZWxwZWQgdGhvdWdoIGFuZCBzaG93ZWQgbWUg dGhhdCBwd3JpdGUgaXMgY3VycmVudGx5IGJyb2tlbjoKPiBodHRwczovL2J1Z3MuZnJlZWRlc2t0 b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD04NjQyMgoKSWYgeW91IGRvIGRtYS1idWYgbW1hcCB3aXRo IGJlZ2luL2VuZCBpdCBzaG91bGQgd29yaywgc2luY2UgaW4gdGhlcmUgd2UnbGwKanVzdCB0byBt YW51YWwgcmFuZ2UtYmFzZWQgY2xmbHVzaGluZy4KLURhbmllbAoKCj4gCj4gVGlhZ28KPiAKPiBk aWZmIC0tZ2l0IGEvdGVzdHMva21zX3B3cml0ZV9jcmMuYyBiL3Rlc3RzL2ttc19wd3JpdGVfY3Jj LmMKPiBpbmRleCAwNWI5ZTM4Li40MTliNDZkIDEwMDY0NAo+IC0tLSBhL3Rlc3RzL2ttc19wd3Jp dGVfY3JjLmMKPiArKysgYi90ZXN0cy9rbXNfcHdyaXRlX2NyYy5jCj4gQEAgLTUwLDYgKzUwLDIw IEBAIHR5cGVkZWYgc3RydWN0IHsKPiAgCXVpbnQzMl90IGRldmlkOwo+ICB9IGRhdGFfdDsKPiAK PiArc3RhdGljIGNoYXIgKmRtYWJ1Zl9tbWFwX2ZyYW1lYnVmZmVyKGludCBkcm1fZmQsIHN0cnVj dCBpZ3RfZmIgKmZiKQo+ICt7Cj4gKwlpbnQgZG1hX2J1Zl9mZDsKPiArCWNoYXIgKnB0ciA9IE5V TEw7Cj4gKwo+ICsJZG1hX2J1Zl9mZCA9IHByaW1lX2hhbmRsZV90b19mZChkcm1fZmQsIGZiLT5n ZW1faGFuZGxlKTsKPiArCWlndF9hc3NlcnQoZXJybm8gPT0gMCk7Cj4gKwo+ICsJcHRyID0gbW1h cChOVUxMLCBmYi0+c2l6ZSwgUFJPVF9SRUFEIHwgUFJPVF9XUklURSwgTUFQX1NIQVJFRCwgZG1h X2J1Zl9mZCwKPiAwKTsKPiArCWlndF9hc3NlcnQocHRyICE9IE1BUF9GQUlMRUQpOwo+ICsKPiAr CXJldHVybiBwdHI7Cj4gK30KPiArCj4gIHN0YXRpYyB2b2lkIHRlc3QoZGF0YV90ICpkYXRhKQo+ ICB7Cj4gIAlpZ3RfZGlzcGxheV90ICpkaXNwbGF5ID0gJmRhdGEtPmRpc3BsYXk7Cj4gQEAgLTU3 LDYgKzcxLDcgQEAgc3RhdGljIHZvaWQgdGVzdChkYXRhX3QgKmRhdGEpCj4gIAlzdHJ1Y3QgaWd0 X2ZiICpmYiA9ICZkYXRhLT5mYlsxXTsKPiAgCWRybU1vZGVNb2RlSW5mbyAqbW9kZTsKPiAgCWNh aXJvX3QgKmNyOwo+ICsJY2hhciAqcHRyOwo+ICAJdWludDMyX3QgY2FjaGluZzsKPiAgCXZvaWQg KmJ1ZjsKPiAgCWlndF9jcmNfdCBjcmM7Cj4gQEAgLTY3LDYgKzgyLDggQEAgc3RhdGljIHZvaWQg dGVzdChkYXRhX3QgKmRhdGEpCj4gIAlpZ3RfY3JlYXRlX2ZiKGRhdGEtPmRybV9mZCwgbW9kZS0+ aGRpc3BsYXksIG1vZGUtPnZkaXNwbGF5LAo+ICAJCSAgICAgIERSTV9GT1JNQVRfWFJHQjg4ODgs IExPQ0FMX0RSTV9GT1JNQVRfTU9EX05PTkUsIGZiKTsKPiAKPiArCXB0ciA9IGRtYWJ1Zl9tbWFw X2ZyYW1lYnVmZmVyKGRhdGEtPmRybV9mZCwgZmIpOwo+ICsKPiAgCWNyID0gaWd0X2dldF9jYWly b19jdHgoZGF0YS0+ZHJtX2ZkLCBmYik7Cj4gIAlpZ3RfcGFpbnRfdGVzdF9wYXR0ZXJuKGNyLCBm Yi0+d2lkdGgsIGZiLT5oZWlnaHQpOwo+ICAJY2Fpcm9fZGVzdHJveShjcik7Cj4gQEAgLTgzLDEx ICsxMDAsMTEgQEAgc3RhdGljIHZvaWQgdGVzdChkYXRhX3QgKmRhdGEpCj4gIAljYWNoaW5nID0g Z2VtX2dldF9jYWNoaW5nKGRhdGEtPmRybV9mZCwgZmItPmdlbV9oYW5kbGUpOwo+ICAJaWd0X2Fz c2VydChjYWNoaW5nID09IEk5MTVfQ0FDSElOR19OT05FIHx8IGNhY2hpbmcgPT0KPiBJOTE1X0NB Q0hJTkdfRElTUExBWSk7Cj4gCj4gLQkvKiB1c2UgcHdyaXRlIHRvIG1ha2UgdGhlIG90aGVyIGZi IGFsbCB3aGl0ZSB0b28gKi8KPiArCS8qIHVzZSBkbWFidWYgcG9pbnRlciB0byBtYWtlIHRoZSBv dGhlciBmYiBhbGwgd2hpdGUgdG9vICovCj4gIAlidWYgPSBtYWxsb2MoZmItPnNpemUpOwo+ICAJ aWd0X2Fzc2VydChidWYgIT0gTlVMTCk7Cj4gIAltZW1zZXQoYnVmLCAweGZmLCBmYi0+c2l6ZSk7 Cj4gLQlnZW1fd3JpdGUoZGF0YS0+ZHJtX2ZkLCBmYi0+Z2VtX2hhbmRsZSwgMCwgYnVmLCBmYi0+ c2l6ZSk7Cj4gKwltZW1jcHkocHRyLCBidWYsIGZiLT5zaXplKTsKPiAgCWZyZWUoYnVmKTsKPiAK PiAgCS8qIGFuZCBmbGlwIHRvIGl0ICovCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBF bmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK