From: Daniel Vetter <daniel@ffwll.ch>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: linux-samsung-soc@vger.kernel.org,
dri-devel@lists.freedesktop.org, tjakobi@math.uni-bielefeld.de,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: Re: [PATCH 2/2] drm: WARN_ON if a modeset driver uses legacy suspend/resume helpers
Date: Thu, 13 Aug 2015 23:19:08 +0200 [thread overview]
Message-ID: <20150813211908.GF17734@phenom.ffwll.local> (raw)
In-Reply-To: <1439496399-25791-2-git-send-email-gustavo@padovan.org>
On Thu, Aug 13, 2015 at 05:06:39PM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> Legacy s/r hooks are only used for shadow-attaching drivers, warn
> when a KMS driver tries to use them.
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Assuming that Inki picks up the exynos patch I've applied this to
drm-misc.
Thanks, Daniel
> ---
> drivers/gpu/drm/drm_drv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
> index b7bf4ce..4e76193 100644
> --- a/drivers/gpu/drm/drm_drv.c
> +++ b/drivers/gpu/drm/drm_drv.c
> @@ -567,6 +567,8 @@ struct drm_device *drm_dev_alloc(struct drm_driver *driver,
> ret = drm_minor_alloc(dev, DRM_MINOR_CONTROL);
> if (ret)
> goto err_minors;
> +
> + WARN_ON(driver->suspend || driver->resume);
> }
>
> if (drm_core_check_feature(dev, DRIVER_RENDER)) {
> --
> 2.1.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-08-13 21:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 20:06 [PATCH 1/2] drm/exynos: remove legacy ->suspend()/resume() Gustavo Padovan
2015-08-13 20:06 ` [PATCH 2/2] drm: WARN_ON if a modeset driver uses legacy suspend/resume helpers Gustavo Padovan
2015-08-13 21:19 ` Daniel Vetter [this message]
2015-08-26 15:50 ` [PATCH 1/2] drm/exynos: remove legacy ->suspend()/resume() Gustavo Padovan
2015-08-26 19:12 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150813211908.GF17734@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=gustavo@padovan.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox