From: Hyungwon Hwang <human.hwang@samsung.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/6] xf86drmMode: separate drmModeAtomicCommit() and drmModeAtomicCleanup()
Date: Fri, 21 Aug 2015 13:54:49 +0900 [thread overview]
Message-ID: <20150821135449.6e2c5b00@samsung.com> (raw)
In-Reply-To: <CACvgo52U3jsC6AN=mNuFh4riuSoa2tQPVTh4wh1Bra0_ffmX_g@mail.gmail.com>
Hi Emil,
On Thu, 20 Aug 2015 17:17:27 +0100
Emil Velikov <emil.l.velikov@gmail.com> wrote:
> Hi Hyungwon,
>
> On 19 August 2015 at 01:58, Hyungwon Hwang <human.hwang@samsung.com>
> wrote:
> > This patch seprates the code, which sorts proprty sets and
> > eliminates duplicate properties, from drmModeAtomicCommit(). Now
> > drmModeAtomicCleanup() has to do the job before calling
> > drmModeAtomicCommit(), and drmModeAtomicCommit() just converts the
> > cleaned request to IOCTL argument.
> >
> Afaict the commit message should say why we want this, rather than
> rewording what the patch does.
>
> I'm not sure about the atomic status for wayland and others but this
> commit might cause issues there. Additionally, with this patch we'll
> send a lot of useless information to the kernel if one omits
> drmModeAtomicCleanup(). The kernel will likely discard it but still
> this doesn't seem like a good idea imho.
Yes. I agree that this change burdens the userspace application to use
API correctly. In my case, for modetest, the function of cleaning up
the request is needed, so I thought that this separation would be
needed. Overall, I agree with you. So I will drop this patch, and find
another way which is specific for modetest.
Thanks for your review.
Best regards,
Hyungwon Hwang
>
> -Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-08-21 4:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 0:58 [PATCH 1/6] xf86drmMode: remove the trailing white spaces Hyungwon Hwang
2015-08-19 0:58 ` [PATCH 2/6] xf86drmMode: separate drmModeAtomicCommit() and drmModeAtomicCleanup() Hyungwon Hwang
2015-08-20 16:17 ` Emil Velikov
2015-08-21 4:54 ` Hyungwon Hwang [this message]
2015-08-21 6:42 ` Pekka Paalanen
2015-08-21 7:18 ` Hyungwon Hwang
2015-08-21 10:08 ` Pekka Paalanen
2015-08-19 0:58 ` [PATCH 3/6] xf86drmMode: Make atomic request structures visible Hyungwon Hwang
2015-08-20 16:23 ` Emil Velikov
2015-08-21 6:06 ` Hyungwon Hwang
2015-08-21 6:44 ` Pekka Paalanen
2015-08-21 7:35 ` Hyungwon Hwang
2015-08-19 0:58 ` [PATCH 4/6] modetest: remove the trailing white spaces Hyungwon Hwang
2015-08-19 0:58 ` [PATCH 5/6] modetest: add atomic modeset support Hyungwon Hwang
2015-08-19 0:58 ` [PATCH 6/6] modetest: add atomic page flip support Hyungwon Hwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150821135449.6e2c5b00@samsung.com \
--to=human.hwang@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox