From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: make sure to check callbacks of ENCODER and CRTC helpers Date: Tue, 25 Aug 2015 10:26:33 +0200 Message-ID: <20150825082633.GS20434@phenom.ffwll.local> References: <1439698334-19925-1-git-send-email-inki.dae@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C22E6E14D for ; Tue, 25 Aug 2015 01:26:37 -0700 (PDT) Received: by widdq5 with SMTP id dq5so7381030wid.0 for ; Tue, 25 Aug 2015 01:26:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1439698334-19925-1-git-send-email-inki.dae@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Inki Dae Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBBdWcgMTYsIDIwMTUgYXQgMDE6MTI6MTRQTSArMDkwMCwgSW5raSBEYWUgd3JvdGU6 Cj4gVGhpcyBwYXRjaCBmaXhlcyBOVUxMIHBvaW50ZXIgYWNjZXNzIGlzc3VlcyB0byBFTkNPREVS Cj4gYW5kIENSVEMgZHJpdmVycy4KPiAKPiBWZW5kb3Igc3BlY2lmaWMgRFJNIEtNUyBkcml2ZXJz IG1heSBub3Qgc2V0IHRoZWlyIGhlbHBlciBjYWxsYmFja3MKPiB0byBFTkNPREVSIGRuIENSVEMg ZHJpdmVycy4gSW4gdGhpcyBjYXNlLCB0aGF0IHdpbGwgaW5jdXIgTlVMTAo+IHBvaW50ZXIgYWNj ZXNzIHdoZW4gbW9kZXNldCBpcyB0cmllZC4KPiAKPiBTbyB0aGlzIHBhdGNoIG1ha2VzIHN1cmUg dG8gY2hlY2sgaWYgdGhlIGNhbGxiYWNrcyBhcmUgTlVMTCBvciBub3QuCj4gCj4gU2lnbmVkLW9m Zi1ieTogSW5raSBEYWUgPGlua2kuZGFlQHNhbXN1bmcuY29tPgoKSXMgdGhlcmUgcmVhbGx5IGEg bG90IG9mIHZhbHVlIGluIHR1bmluZyBsZWdhY3kgY3J0YyBoZWxwZXJzPyBOZXcgZHJpdmVycwpz aG91bGQganVzdCB1c2UgYXRvbWljICh3aGVyZSB3ZSd2ZSBtYWRlIGFsbCB0aGVzZSBjaGFuZ2Vz IGFscmVhZHkpLApkcml2ZXJzIHdoaWNoIGFyZSBzdGlsbCB0cmFuc2l0aW9uaW5nIGNhbiBqdXN0 IGNhcnJ5IGFyb3VuZCBkdW1teQpmdW5jdGlvbnMgZm9yIG5vdy4KLURhbmllbAoKPiAtLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjX2hlbHBlci5jIHwgNDQgKysrKysrKysrKysrKysrKysr KysrKysrKystLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyOSBpbnNlcnRpb25zKCsp LCAxNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9j cnRjX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjX2hlbHBlci5jCj4gaW5kZXgg ZWY1MzQ3NS4uYWExZjQyZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGNf aGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGNfaGVscGVyLmMKPiBAQCAt MzE4LDE2ICszMTgsMjIgQEAgYm9vbCBkcm1fY3J0Y19oZWxwZXJfc2V0X21vZGUoc3RydWN0IGRy bV9jcnRjICpjcnRjLAo+ICAJCX0KPiAgCj4gIAkJZW5jb2Rlcl9mdW5jcyA9IGVuY29kZXItPmhl bHBlcl9wcml2YXRlOwo+IC0JCWlmICghKHJldCA9IGVuY29kZXJfZnVuY3MtPm1vZGVfZml4dXAo ZW5jb2RlciwgbW9kZSwKPiAtCQkJCQkJICAgICAgYWRqdXN0ZWRfbW9kZSkpKSB7Cj4gLQkJCURS TV9ERUJVR19LTVMoIkVuY29kZXIgZml4dXAgZmFpbGVkXG4iKTsKPiAtCQkJZ290byBkb25lOwo+ ICsJCWlmIChlbmNvZGVyX2Z1bmNzLT5tb2RlX2ZpeHVwKSB7Cj4gKwkJCXJldCA9IGVuY29kZXJf ZnVuY3MtPm1vZGVfZml4dXAoZW5jb2RlciwgbW9kZSwKPiArCQkJCQkJCWFkanVzdGVkX21vZGUp Owo+ICsJCQlpZiAoIXJldCkgewo+ICsJCQkJRFJNX0RFQlVHX0tNUygiRW5jb2RlciBmaXh1cCBm YWlsZWRcbiIpOwo+ICsJCQkJZ290byBkb25lOwo+ICsJCQl9Cj4gIAkJfQo+ICAJfQo+ICAKPiAt CWlmICghKHJldCA9IGNydGNfZnVuY3MtPm1vZGVfZml4dXAoY3J0YywgbW9kZSwgYWRqdXN0ZWRf bW9kZSkpKSB7Cj4gLQkJRFJNX0RFQlVHX0tNUygiQ1JUQyBmaXh1cCBmYWlsZWRcbiIpOwo+IC0J CWdvdG8gZG9uZTsKPiArCWlmIChjcnRjX2Z1bmNzLT5tb2RlX2ZpeHVwKSB7Cj4gKwkJcmV0ID0g Y3J0Y19mdW5jcy0+bW9kZV9maXh1cChjcnRjLCBtb2RlLCBhZGp1c3RlZF9tb2RlKTsKPiArCQlp ZiAoIXJldCkgewo+ICsJCQlEUk1fREVCVUdfS01TKCJDUlRDIGZpeHVwIGZhaWxlZFxuIik7Cj4g KwkJCWdvdG8gZG9uZTsKPiArCQl9Cj4gIAl9Cj4gIAlEUk1fREVCVUdfS01TKCJbQ1JUQzolZF1c biIsIGNydGMtPmJhc2UuaWQpOwo+ICAKPiBAQCAtMzQzLDIxICszNDksMjYgQEAgYm9vbCBkcm1f Y3J0Y19oZWxwZXJfc2V0X21vZGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAKPiAgCQllbmNv ZGVyX2Z1bmNzID0gZW5jb2Rlci0+aGVscGVyX3ByaXZhdGU7Cj4gIAkJLyogRGlzYWJsZSB0aGUg ZW5jb2RlcnMgYXMgdGhlIGZpcnN0IHRoaW5nIHdlIGRvLiAqLwo+IC0JCWVuY29kZXJfZnVuY3Mt PnByZXBhcmUoZW5jb2Rlcik7Cj4gKwkJaWYgKGVuY29kZXJfZnVuY3MtPnByZXBhcmUpCj4gKwkJ CWVuY29kZXJfZnVuY3MtPnByZXBhcmUoZW5jb2Rlcik7Cj4gIAo+ICAJCWRybV9icmlkZ2VfcG9z dF9kaXNhYmxlKGVuY29kZXItPmJyaWRnZSk7Cj4gIAl9Cj4gIAo+ICAJZHJtX2NydGNfcHJlcGFy ZV9lbmNvZGVycyhkZXYpOwo+ICAKPiAtCWNydGNfZnVuY3MtPnByZXBhcmUoY3J0Yyk7Cj4gKwlp ZiAoY3J0Y19mdW5jcy0+cHJlcGFyZSkKPiArCQljcnRjX2Z1bmNzLT5wcmVwYXJlKGNydGMpOwo+ ICAKPiAgCS8qIFNldCB1cCB0aGUgRFBMTCBhbmQgYW55IGVuY29kZXJzIHN0YXRlIHRoYXQgbmVl ZHMgdG8gYWRqdXN0IG9yIGRlcGVuZAo+ICAJICogb24gdGhlIERQTEwuCj4gIAkgKi8KPiAtCXJl dCA9ICFjcnRjX2Z1bmNzLT5tb2RlX3NldChjcnRjLCBtb2RlLCBhZGp1c3RlZF9tb2RlLCB4LCB5 LCBvbGRfZmIpOwo+IC0JaWYgKCFyZXQpCj4gLQkgICAgZ290byBkb25lOwo+ICsJaWYgKGNydGNf ZnVuY3MtPm1vZGVfc2V0KSB7Cj4gKwkJcmV0ID0gIWNydGNfZnVuY3MtPm1vZGVfc2V0KGNydGMs IG1vZGUsIGFkanVzdGVkX21vZGUsIHgsIHksCj4gKwkJCQkJICAgIG9sZF9mYik7Cj4gKwkJaWYg KCFyZXQpCj4gKwkJCWdvdG8gZG9uZTsKPiArCX0KPiAgCj4gIAlkcm1fZm9yX2VhY2hfZW5jb2Rl cihlbmNvZGVyLCBkZXYpIHsKPiAgCj4gQEAgLTM2OCwxMyArMzc5LDE1IEBAIGJvb2wgZHJtX2Ny dGNfaGVscGVyX3NldF9tb2RlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCQkJZW5jb2Rlci0+ YmFzZS5pZCwgZW5jb2Rlci0+bmFtZSwKPiAgCQkJbW9kZS0+YmFzZS5pZCwgbW9kZS0+bmFtZSk7 Cj4gIAkJZW5jb2Rlcl9mdW5jcyA9IGVuY29kZXItPmhlbHBlcl9wcml2YXRlOwo+IC0JCWVuY29k ZXJfZnVuY3MtPm1vZGVfc2V0KGVuY29kZXIsIG1vZGUsIGFkanVzdGVkX21vZGUpOwo+ICsJCWlm IChlbmNvZGVyX2Z1bmNzLT5tb2RlX3NldCkKPiArCQkJZW5jb2Rlcl9mdW5jcy0+bW9kZV9zZXQo ZW5jb2RlciwgbW9kZSwgYWRqdXN0ZWRfbW9kZSk7Cj4gIAo+ICAJCWRybV9icmlkZ2VfbW9kZV9z ZXQoZW5jb2Rlci0+YnJpZGdlLCBtb2RlLCBhZGp1c3RlZF9tb2RlKTsKPiAgCX0KPiAgCj4gIAkv KiBOb3cgZW5hYmxlIHRoZSBjbG9ja3MsIHBsYW5lLCBwaXBlLCBhbmQgY29ubmVjdG9ycyB0aGF0 IHdlIHNldCB1cC4gKi8KPiAtCWNydGNfZnVuY3MtPmNvbW1pdChjcnRjKTsKPiArCWlmIChjcnRj X2Z1bmNzLT5jb21taXQpCj4gKwkJY3J0Y19mdW5jcy0+Y29tbWl0KGNydGMpOwo+ICAKPiAgCWRy bV9mb3JfZWFjaF9lbmNvZGVyKGVuY29kZXIsIGRldikgewo+ICAKPiBAQCAtMzg0LDcgKzM5Nyw4 IEBAIGJvb2wgZHJtX2NydGNfaGVscGVyX3NldF9tb2RlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywK PiAgCQlkcm1fYnJpZGdlX3ByZV9lbmFibGUoZW5jb2Rlci0+YnJpZGdlKTsKPiAgCj4gIAkJZW5j b2Rlcl9mdW5jcyA9IGVuY29kZXItPmhlbHBlcl9wcml2YXRlOwo+IC0JCWVuY29kZXJfZnVuY3Mt PmNvbW1pdChlbmNvZGVyKTsKPiArCQlpZiAoZW5jb2Rlcl9mdW5jcy0+Y29tbWl0KQo+ICsJCQll bmNvZGVyX2Z1bmNzLT5jb21taXQoZW5jb2Rlcik7Cj4gIAo+ICAJCWRybV9icmlkZ2VfZW5hYmxl KGVuY29kZXItPmJyaWRnZSk7Cj4gIAl9Cj4gLS0gCj4gMS45LjEKPiAKPiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkRhbmllbCBWZXR0ZXIK U29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNo Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==