From: Daniel Vetter <daniel@ffwll.ch>
To: Rob Clark <robdclark@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [RFC 0/2] atomicify fbdev stuff
Date: Tue, 25 Aug 2015 10:53:01 +0200 [thread overview]
Message-ID: <20150825085301.GV20434@phenom.ffwll.local> (raw)
In-Reply-To: <1440024317-21944-1-git-send-email-robdclark@gmail.com>
On Wed, Aug 19, 2015 at 06:45:15PM -0400, Rob Clark wrote:
> So the issues that Inki and Bjorn ran into with ww_acquire_fini() vs
> legacy fbdev codepaths (like restore_fbdev_mode() and pan_display())
> would be solved by using a single atomic update for these cases. So
> I hacked up a prototype.
>
> (disclaimer, these are completely untested hacked-up-between-sessions-
> at-conference patches.. but at least they compile ;-))
>
> I think Daniel wanted something other than DRIVER_ATOMIC check, since
> i915 currently supports atomic other than async. Other option would
> be a separate DRIVER_ATOMIC_ASYNC flag (which has some advantage, in
> that we could start using atomic modeset, but not atomic pageflip,
> on i915.. and perhaps finally start work on atomic xrandr). Other
> option would be to, for now, just introduce an fb_helper->use_atomic
> flag, which driver could override, instead.
Not a separate driver flag, but simply something to force fbdev helper to
use atomic without DRIVER_ATOMIC. That way partially-converted drivers can
switch things on their own. With that addressed and testing done this
looks ready imo and I'll pull it in.
> For now we should probably revert the ww_acquire_fini patch, and then
> shoot for re-introducing it on top of these patches (hopefully working
> by then) for 4.4. And maybe in the process we can fix some i915 multi-
> monitor VT switch fail.
Yeah, Dave already pushed the revert.
-Daniel
>
> Rob Clark (2):
> drm/fb-helper: atomic restore_fbdev_mode()..
> drm/fb-helper: atomic pan_display()..
>
> drivers/gpu/drm/drm_atomic_helper.c | 129 ++++++++++++++++++++--------------
> drivers/gpu/drm/drm_fb_helper.c | 133 ++++++++++++++++++++++++++++++++++++
> include/drm/drm_atomic_helper.h | 6 ++
> 3 files changed, 215 insertions(+), 53 deletions(-)
>
> --
> 2.4.3
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-08-25 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 22:45 [RFC 0/2] atomicify fbdev stuff Rob Clark
2015-08-19 22:45 ` [RFC 1/2] drm/fb-helper: atomic restore_fbdev_mode() Rob Clark
2015-08-19 22:45 ` [RFC 2/2] drm/fb-helper: atomic pan_display() Rob Clark
2015-08-25 8:53 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150825085301.GV20434@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox