From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/fb-helper: Use -errno return in
	restore_mode_unlocked
Date: Wed, 26 Aug 2015 13:36:08 +0200
Message-ID: <20150826113608.GF1367@phenom.ffwll.local>
References: <1440510314-8633-2-git-send-email-daniel.vetter@ffwll.ch>
 <1440516028-11127-1-git-send-email-daniel.vetter@ffwll.ch>
 <CAF6AEGs6DwqZun9vLAUT+smz23=8xU+CKd-fQW7RBS+Nt78CUw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <CAF6AEGs6DwqZun9vLAUT+smz23=8xU+CKd-fQW7RBS+Nt78CUw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Rob Clark <robdclark@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, DRI Development <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

T24gVHVlLCBBdWcgMjUsIDIwMTUgYXQgMDM6MjA6MDJQTSAtMDQwMCwgUm9iIENsYXJrIHdyb3Rl
Ogo+IE9uIFR1ZSwgQXVnIDI1LCAyMDE1IGF0IDExOjIwIEFNLCBEYW5pZWwgVmV0dGVyIDxkYW5p
ZWwudmV0dGVyQGZmd2xsLmNoPiB3cm90ZToKPiA+IFVzaW5nIGJvb2wgYW5kIHJldHVybmluZyB0
cnVlIHVwb24gZXJyb3IgaXMgdmVyeSB1bmNvbW1vbi4gQWxzbyBhbiBpbnQKPiA+IHJldHVybiB2
YWx1ZSBpcyBhY3R1YWxseSB3aGF0IGFsbCB0aGUgY2FsbGVycyB3aGljaCBkaWQgY2hlY2sgaXQg
c2VlbQo+ID4gdG8gaGF2ZSBleHBlY3RlZC4KPiA+Cj4gPiB2MjogUmVzdG9yZSBodW5rIG1pc3Bs
YWNlZCBpbiBhIHJlYmFzZSwgc3BvdHRlZCBieSBSb2IuCj4gPgo+ID4gQ2M6IFJvYiBDbGFyayA8
cm9iZGNsYXJrQGdtYWlsLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRh
bmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gCj4gUmV2aWV3ZWQtYnk6IFJvYiBDbGFyayA8cm9iZGNs
YXJrQGdtYWlsLmNvbT4KCk1lcmdlZCB0aGUgZmlyc3QgMiBwYXRjaGVzIGZyb20gdGhpcyBzZXJp
ZXMgdG8gZHJtLW1pc2MsIHRoYW5rcyBmb3IgeW91cgpyZXZpZXcuCi1EYW5pZWwKCj4gCj4gCj4g
PiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIHwgMTkgKysrKysrKysr
KystLS0tLS0tLQo+ID4gIGluY2x1ZGUvZHJtL2RybV9mYl9oZWxwZXIuaCAgICAgfCAgNiArKyst
LS0KPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygt
KQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIGIv
ZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+ID4gaW5kZXggNDE4ZDI5OWYzYjEyLi44
NTkxMzRlMGQ3MmQgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBl
ci5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4gPiBAQCAtMzIw
LDExICszMjAsMTAgQEAgaW50IGRybV9mYl9oZWxwZXJfZGVidWdfbGVhdmUoc3RydWN0IGZiX2lu
Zm8gKmluZm8pCj4gPiAgfQo+ID4gIEVYUE9SVF9TWU1CT0woZHJtX2ZiX2hlbHBlcl9kZWJ1Z19s
ZWF2ZSk7Cj4gPgo+ID4gLXN0YXRpYyBib29sIHJlc3RvcmVfZmJkZXZfbW9kZShzdHJ1Y3QgZHJt
X2ZiX2hlbHBlciAqZmJfaGVscGVyKQo+ID4gK3N0YXRpYyBpbnQgcmVzdG9yZV9mYmRldl9tb2Rl
KHN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIpCj4gPiAgewo+ID4gICAgICAgICBzdHJ1
Y3QgZHJtX2RldmljZSAqZGV2ID0gZmJfaGVscGVyLT5kZXY7Cj4gPiAgICAgICAgIHN0cnVjdCBk
cm1fcGxhbmUgKnBsYW5lOwo+ID4gLSAgICAgICBib29sIGVycm9yID0gZmFsc2U7Cj4gPiAgICAg
ICAgIGludCBpOwo+ID4KPiA+ICAgICAgICAgZHJtX3dhcm5fb25fbW9kZXNldF9ub3RfYWxsX2xv
Y2tlZChkZXYpOwo+ID4gQEAgLTM0OCwxNCArMzQ3LDE1IEBAIHN0YXRpYyBib29sIHJlc3RvcmVf
ZmJkZXZfbW9kZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyKQo+ID4gICAgICAgICAg
ICAgICAgIGlmIChjcnRjLT5mdW5jcy0+Y3Vyc29yX3NldCkgewo+ID4gICAgICAgICAgICAgICAg
ICAgICAgICAgcmV0ID0gY3J0Yy0+ZnVuY3MtPmN1cnNvcl9zZXQoY3J0YywgTlVMTCwgMCwgMCwg
MCk7Cj4gPiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAocmV0KQo+ID4gLSAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBlcnJvciA9IHRydWU7Cj4gPiArICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4gPiAgICAgICAgICAgICAgICAgfQo+ID4KPiA+ICAg
ICAgICAgICAgICAgICByZXQgPSBkcm1fbW9kZV9zZXRfY29uZmlnX2ludGVybmFsKG1vZGVfc2V0
KTsKPiA+ICAgICAgICAgICAgICAgICBpZiAocmV0KQo+ID4gLSAgICAgICAgICAgICAgICAgICAg
ICAgZXJyb3IgPSB0cnVlOwo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHJldDsK
PiA+ICAgICAgICAgfQo+ID4gLSAgICAgICByZXR1cm4gZXJyb3I7Cj4gPiArCj4gPiArICAgICAg
IHJldHVybiAwOwo+ID4gIH0KPiA+Cj4gPiAgLyoqCj4gPiBAQCAtMzY1LDEyICszNjUsMTUgQEAg
c3RhdGljIGJvb2wgcmVzdG9yZV9mYmRldl9tb2RlKHN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9o
ZWxwZXIpCj4gPiAgICogVGhpcyBzaG91bGQgYmUgY2FsbGVkIGZyb20gZHJpdmVyJ3MgZHJtIC0+
bGFzdGNsb3NlIGNhbGxiYWNrCj4gPiAgICogd2hlbiBpbXBsZW1lbnRpbmcgYW4gZmJjb24gb24g
dG9wIG9mIGttcyB1c2luZyB0aGlzIGhlbHBlci4gVGhpcyBlbnN1cmVzIHRoYXQKPiA+ICAgKiB0
aGUgdXNlciBpc24ndCBncmVldGVkIHdpdGggYSBibGFjayBzY3JlZW4gd2hlbiBlLmcuIFggZGll
cy4KPiA+ICsgKgo+ID4gKyAqIFJFVFVSTlM6Cj4gPiArICogWmVybyBpZiBldmVyeXRoaW5nIHdl
bnQgb2ssIG5lZ2F0aXZlIGVycm9yIGNvZGUgb3RoZXJ3aXNlLgo+ID4gICAqLwo+ID4gLWJvb2wg
ZHJtX2ZiX2hlbHBlcl9yZXN0b3JlX2ZiZGV2X21vZGVfdW5sb2NrZWQoc3RydWN0IGRybV9mYl9o
ZWxwZXIgKmZiX2hlbHBlcikKPiA+ICtpbnQgZHJtX2ZiX2hlbHBlcl9yZXN0b3JlX2ZiZGV2X21v
ZGVfdW5sb2NrZWQoc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlcikKPiA+ICB7Cj4gPiAg
ICAgICAgIHN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBmYl9oZWxwZXItPmRldjsKPiA+IC0gICAg
ICAgYm9vbCByZXQ7Cj4gPiAtICAgICAgIGJvb2wgZG9fZGVsYXllZCA9IGZhbHNlOwo+ID4gKyAg
ICAgICBib29sIGRvX2RlbGF5ZWQ7Cj4gPiArICAgICAgIGludCByZXQ7Cj4gPgo+ID4gICAgICAg
ICBkcm1fbW9kZXNldF9sb2NrX2FsbChkZXYpOwo+ID4gICAgICAgICByZXQgPSByZXN0b3JlX2Zi
ZGV2X21vZGUoZmJfaGVscGVyKTsKPiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fZmJf
aGVscGVyLmggYi9pbmNsdWRlL2RybS9kcm1fZmJfaGVscGVyLmgKPiA+IGluZGV4IGRiYWI0NjIy
YjU4Zi4uNjdkZTFmMTAwMDhlIDEwMDY0NAo+ID4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX2ZiX2hl
bHBlci5oCj4gPiArKysgYi9pbmNsdWRlL2RybS9kcm1fZmJfaGVscGVyLmgKPiA+IEBAIC0xMzYs
NyArMTM2LDcgQEAgaW50IGRybV9mYl9oZWxwZXJfc2V0X3BhcihzdHJ1Y3QgZmJfaW5mbyAqaW5m
byk7Cj4gPiAgaW50IGRybV9mYl9oZWxwZXJfY2hlY2tfdmFyKHN0cnVjdCBmYl92YXJfc2NyZWVu
aW5mbyAqdmFyLAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBmYl9pbmZv
ICppbmZvKTsKPiA+Cj4gPiAtYm9vbCBkcm1fZmJfaGVscGVyX3Jlc3RvcmVfZmJkZXZfbW9kZV91
bmxvY2tlZChzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyKTsKPiA+ICtpbnQgZHJtX2Zi
X2hlbHBlcl9yZXN0b3JlX2ZiZGV2X21vZGVfdW5sb2NrZWQoc3RydWN0IGRybV9mYl9oZWxwZXIg
KmZiX2hlbHBlcik7Cj4gPgo+ID4gIHN0cnVjdCBmYl9pbmZvICpkcm1fZmJfaGVscGVyX2FsbG9j
X2ZiaShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyKTsKPiA+ICB2b2lkIGRybV9mYl9o
ZWxwZXJfdW5yZWdpc3Rlcl9mYmkoc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlcik7Cj4g
PiBAQCAtMjI2LDEwICsyMjYsMTAgQEAgc3RhdGljIGlubGluZSBpbnQgZHJtX2ZiX2hlbHBlcl9j
aGVja192YXIoc3RydWN0IGZiX3Zhcl9zY3JlZW5pbmZvICp2YXIsCj4gPiAgICAgICAgIHJldHVy
biAwOwo+ID4gIH0KPiA+Cj4gPiAtc3RhdGljIGlubGluZSBib29sCj4gPiArc3RhdGljIGlubGlu
ZSBpbnQKPiA+ICBkcm1fZmJfaGVscGVyX3Jlc3RvcmVfZmJkZXZfbW9kZV91bmxvY2tlZChzdHJ1
Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyKQo+ID4gIHsKPiA+IC0gICAgICAgcmV0dXJuIHRy
dWU7Cj4gPiArICAgICAgIHJldHVybiAwOwo+ID4gIH0KPiA+Cj4gPiAgc3RhdGljIGlubGluZSBz
dHJ1Y3QgZmJfaW5mbyAqCj4gPiAtLQo+ID4gMS44LjMuMQo+ID4KCi0tIApEYW5pZWwgVmV0dGVy
ClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5j
aApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n
ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xp
c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=