From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/atomic: refuse changing CRTC for planes directly Date: Thu, 27 Aug 2015 09:45:52 +0200 Message-ID: <20150827074552.GZ1367@phenom.ffwll.local> References: <1440603683-15822-1-git-send-email-daniel.vetter@ffwll.ch> <1440618582-19845-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rob Clark Cc: Daniel Stone , Daniel Vetter , Intel Graphics Development , DRI Development , Thierry Reding , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBdWcgMjYsIDIwMTUgYXQgMDU6NTE6NDZQTSAtMDQwMCwgUm9iIENsYXJrIHdyb3Rl Ogo+IE9uIFdlZCwgQXVnIDI2LCAyMDE1IGF0IDM6NDkgUE0sIERhbmllbCBWZXR0ZXIgPGRhbmll bC52ZXR0ZXJAZmZ3bGwuY2g+IHdyb3RlOgo+ID4gVmVyeSBzdHJpY3RseSBzcGVha2luZyB0aGlz IGlzIHBvc3NpYmxlIGlmIHlvdSBoYXZlIHNwZWNpYWwgaHcgYW5kCj4gPiBnZW5sb2NrZWQgQ1JU Q3MuIEluIGdlbmVyYWwgc3dpdGNoaW5nIGEgcGxhbmUgYmV0d2VlbiB0d28gYWN0aXZlIENSVEMK PiA+IGp1c3Qgd29uJ3Qgd29yayBzbyB3ZWxsIGFuZCBpcyBwcm9iYWJseSBub3QgdGVzdGVkIGF0 IGFsbC4gSnVzdCBmb3JiaWQKPiA+IGl0Lgo+ID4KPiA+IEkndmUgcHV0IHRoaXMgaW50byB0aGUg Y29yZSBzaW5jZSByaWdodCBub3cgbm8gaGVscGVyIG9yIGRyaXZlciBjb3Blcwo+ID4gd2l0aCBp dCwgbm8gdXNlcnNwYWNlIGhhcyBjb2RlIGZvciBpdCBhbmQgbm8gb25lIGFza3MgZm9yIGl0LiBZ ZXMKPiA+IHRoZXJlJ3MgcGlsZXMgb2YgY29ybmVyLWNhc2VzIHdoZXJlIHRoaXMgd291bGQgYmUg cG9zc2libGUgdG8gZG8gdGhpcwo+ID4gbGlrZToKPiA+IC0gc3dpdGNoIGZyb20gaW5hY3RpdmUg Y3J0YyB0byBhY3RpdmUgY3J0Ywo+ID4gLSBzd2l0aGMgZnJvbSBhY3RpdmUgY3J0YyB0byBpbmFj dGl2ZSBjcnRjCj4gPiAtIGdlbmxvY2tlZCBkaXNwbGF5Cj4gPiAtIGludmlzaWJsZSBwbGFuZSAo dG8gZG8gd2hhdGV2ZXIpCj4gPiAtIGlkbGUgcGxhbmUgaHcgZHVlIHRvIGRzaSBjbWQgbW9kZS9w c3IKPiA+IC0gd2hhdGV2ZXIKPiA+IGJ1dCBsb29raW5nIGF0IGRldGFpbHMgaXQncyBub3QgdGhh dCBlYXN5IHRvIGltcGxlbWVudCB0aGlzIGNvcnJlY3RseS4KPiA+IEhlbmNlIGp1c3QgcHV0IGl0 IGludG8gdGhlIGNvcmUgYW5kIGFkZCBhIGNvbW1lbnQsIHNpbmNlIHRoZSBvbmx5Cj4gPiB1c2Vy c3BhY2Ugd2UgaGF2ZSByaWdodCBub3cgZm9yIGF0b21pYyAod2VzdG9uKSBkb2Vzbid0IHdhbnQg dG8gdXNlCj4gPiBkaXJlY3QgcGxhbmUgc3dpdGNoaW5nIGVpdGhlci4KPiAKPiBJIHN1c3BlY3Qg dGhhdCBldmVudHVhbGx5IHdlJ2xsIHdhbnQgdG8gbWFrZSB0aGlzIGEgaGVscGVyIGV4cG9zZWQg dG8KPiBkcml2ZXJzIGFuZCBwdXNoIHRoaXMgY2hlY2sgZG93biBpbnRvIHRoZSBkcml2ZXJzLi4g cGVyaGFwcyB0aGF0IGlzCj4gbm90IHVudGlsIHdlc3RvbiAoYW5kL29yIGF0b21pYyBiYXNlZCBo d2MpIGdyb3dzIGRyaXZlciBzcGVjaWZpYwo+IHVzZXJzcGFjZSBwbHVnaW4gdHlwZSBBUEkgdG8g bWFrZSBzbWFydGVyIGh3IHNwZWNpZmljIGRlY2lzaW9ucy4uCj4gdW50aWwgdGhlbiwgdGhpcyBp cyBwcm9iYWJseSB0aGUgbW9zdCByZWFzb25hYmxlIHRoaW5nIHRvIGRvLi4gc28KClllYWggdGhp cyByZWFsbHkgaXMganVzdCB0byBwbHVnIGEgInVuZGVmaW5lZCBiZWhhdmlvdXIiIGdhcCBpbiB0 aGUgYWJpCnVudGlsIHdlIGtub3cgd2hhdCBleGFjdGx5IHdlIHdhbnQgYW5kIGhhdmUgc29tZSB1 c2Vyc3BhY2UgbmVlZGluZyB0aGlzLgoKPiAody8gcy9zd2loYy9zd2l0Y2gvIGZpeCBzbWFzaGVk IGluIGFib3ZlKQo+IAo+IFJldmlld2VkLWJ5OiBSb2IgQ2xhcmsgPHJvYmRjbGFya0BnbWFpbC5j b20+CgpGaXhlZCZtZXJnZWQgdG8gZHJtLW1pc2MsIHRoYW5rcyBmb3IgdGhlIHJldmlldy4KLURh bmllbAoKPiAKPiAKPiA+IHYyOiBkb24ndCBib3RoZXIgd2l0aCBjb21wbGV4aXR5IGFuZCBqdXN0 IG91dHJpZ2h0IGRpc2FsbG93IHBsYW5lCj4gPiBzd2l0Y2hpbmcgd2l0aG91dCB0aGUgaW50ZXJt ZWRpYXRlIE9GRiBzdGF0ZS4gU2ltcGxpZmllcyBkcml2ZXJzLCB3ZQo+ID4gZG9uJ3QgaGF2ZSBh bnkgaHcgdGhhdCBjb3VsZCBkbyBpdCBhbnl3YXkgYW5kIGN1cnJlbnQgYXRvbWljIHVzZXJzcGFj ZQo+ID4gKHdlc3Rvbikgd29ya3MgbGlrZSB0aGlzIGFscmVhZHkgYW55d2F5Lgo+ID4KPiA+IHYz OiBCaWtlc2hlZCBmdW5jdGlvbiBuYW1lIChWaWxsZSkgYW5kIGFkZCBjb21tZW50IChSb2IpLgo+ ID4KPiA+IHY0OiBBbHNvIGJpa2VzaGVkIGNvbW1pdCBtZXNzYWdlIChSb2IpLgo+ID4KPiA+IENj OiBUaGllcnJ5IFJlZGluZyA8dGhpZXJyeS5yZWRpbmdAZ21haWwuY29tPgo+ID4gQ2M6IE1hYXJ0 ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPiBDYzog RGFuaWVsIFN0b25lIDxkYW5pZWxzQGNvbGxhYm9yYS5jb20+Cj4gPiBBY2tlZC1ieTogRGFuaWVs IFN0b25lIDxkYW5pZWxzQGNvbGxhYm9yYS5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwg VmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiA+Cj4gPiAtLS0KPiA+Cj4gPiBJbW8g dGhpcyBpcyBiaWtlc2hlZGRlZCBlbm91Z2gsIHNvIGVpdGhlciBzb21lb25lIHRha2VzIHRoaXMg b3IKPiA+IHNvbWVvbmUgZWxzZSBjYW4gbWFuZ2xlIHRoaXMgcGF0Y2ggbW9yZS4KPiA+IC1EYW5p ZWwKPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMgfCAyNyArKysrKysr KysrKysrKysrKysrKysrKysrKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygr KQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jIGIvZHJp dmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+ID4gaW5kZXggMTA2NmU0YjY1OGNmLi40MGRkZDZh YTEwMGYgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gPiBAQCAtNjYzLDYgKzY2MywyNyBA QCBkcm1fYXRvbWljX3BsYW5lX2dldF9wcm9wZXJ0eShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwK PiA+ICAgICAgICAgcmV0dXJuIDA7Cj4gPiAgfQo+ID4KPiA+ICtzdGF0aWMgYm9vbAo+ID4gK3Bs YW5lX3N3aXRjaGluZ19jcnRjKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiA+ICsg ICAgICAgICAgICAgICAgICAgIHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ID4gKyAgICAgICAg ICAgICAgICAgICAgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpCj4gPiArewo+ ID4gKyAgICAgICBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsICpjdXJyX2NydGNf c3RhdGU7Cj4gPiArCj4gPiArICAgICAgIGlmICghcGxhbmUtPnN0YXRlLT5jcnRjIHx8ICFwbGFu ZV9zdGF0ZS0+Y3J0YykKPiA+ICsgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Cj4gPiArCj4g PiArICAgICAgIGlmIChwbGFuZS0+c3RhdGUtPmNydGMgPT0gcGxhbmVfc3RhdGUtPmNydGMpCj4g PiArICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo+ID4gKwo+ID4gKyAgICAgICAvKiBUaGlz IGNvdWxkIGJlIHJlZmluZWQsIGJ1dCBjdXJyZW50bHkgdGhlcmUncyBubyBoZWxwZXIgb3IgZHJp dmVyIGNvZGUKPiA+ICsgICAgICAgICogdG8gaW1wbGVtZW50IGRpcmVjdCBzd2l0Y2hpbmcgb2Yg YWN0aXZlIHBsYW5lcyBub3IgdXNlcnNwYWNlIHRvIHRha2UKPiA+ICsgICAgICAgICogYWR2YW50 YWdlIG9mIG1vcmUgZGlyZWN0IHBsYW5lIHN3aXRjaGluZyB3aXRob3V0IHRoZSBpbnRlcm1lZGlh dGUKPiA+ICsgICAgICAgICogZnVsbCBPRkYgc3RhdGUuCj4gPiArICAgICAgICAqLwo+ID4gKyAg ICAgICByZXR1cm4gdHJ1ZTsKPiA+ICt9Cj4gPiArCj4gPiAgLyoqCj4gPiAgICogZHJtX2F0b21p Y19wbGFuZV9jaGVjayAtIGNoZWNrIHBsYW5lIHN0YXRlCj4gPiAgICogQHBsYW5lOiBwbGFuZSB0 byBjaGVjawo+ID4gQEAgLTczNCw2ICs3NTUsMTIgQEAgc3RhdGljIGludCBkcm1fYXRvbWljX3Bs YW5lX2NoZWNrKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ID4gICAgICAgICAgICAgICAgIHJl dHVybiAtRU5PU1BDOwo+ID4gICAgICAgICB9Cj4gPgo+ID4gKyAgICAgICBpZiAocGxhbmVfc3dp dGNoaW5nX2NydGMoc3RhdGUtPnN0YXRlLCBwbGFuZSwgc3RhdGUpKSB7Cj4gPiArICAgICAgICAg ICAgICAgRFJNX0RFQlVHX0FUT01JQygiW1BMQU5FOiVkXSBzd2l0Y2hpbmcgQ1JUQyBkaXJlY3Rs eVxuIiwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBsYW5lLT5iYXNlLmlk KTsKPiA+ICsgICAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiA+ICsgICAgICAgfQo+ID4g Kwo+ID4gICAgICAgICByZXR1cm4gMDsKPiA+ICB9Cj4gPgo+ID4gLS0KPiA+IDIuNS4wCj4gPgo+ ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IElu dGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK PiA+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlv bgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo=