dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Dave Airlie <airlied@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/1] signals: kill block_all_signals() and unblock_all_signals()
Date: Thu, 27 Aug 2015 18:25:05 +0200	[thread overview]
Message-ID: <20150827162505.GA7885@redhat.com> (raw)

On 05/26, Dave Airlie wrote:
>
> On 26 May 2015 at 02:50, Oleg Nesterov <oleg@redhat.com> wrote:
> > AAAAOn 05/25, Richard Weinberger wrote:
> >>
> >> Is this functionality still in use/needed?
> >
> > All I can say it doesn't work.
> >
> >> Otherwise we could get rid of block_all_signals() and unpuzzle the signaling
> >> code a bit. :-)
> >
> > Yes. I do not even remember when I reported this the first time. Perhaps
> > more than 10 years ago.
> >
> > See the last attempt in 2011: https://lkml.org/lkml/2011/7/12/263
> > I copied this email below.
> >
> > Dave. Lets finally kill this horror? I am going to send a patch unless
> > you stop me ;)
>
> There were follow up on that thread 4 years ago, but we are probably
> at the stage where this thing can die,

Heh.

I tried to kill this horror so many years, and forgot to send the patch
after you finally blessed it ;)

Could you please review?

> I suspect any hw using it has died out, and any new hardware won't be
> doing evil things with drm locks

even if it does, let me repeat that block_all_signals() simply do not
work. At all. if ->notifier() returns 0, this thread will burn CPU until
SIGCONT or SIGKILL. Or it will stop anyway if multi-threaded.

Oleg.

             reply	other threads:[~2015-08-27 16:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27 16:25 Oleg Nesterov [this message]
2015-08-27 16:25 ` [PATCH 1/1] signals: kill block_all_signals() and unblock_all_signals() Oleg Nesterov
2015-08-31  8:19   ` Daniel Vetter
2015-09-15 16:41   ` Oleg Nesterov
2015-09-15 23:53     ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150827162505.GA7885@redhat.com \
    --to=oleg@redhat.com \
    --cc=airlied@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox