From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 1/2] drm/atomic-helper: Implement drm_atomic_helper_duplicate_state() Date: Tue, 8 Sep 2015 15:25:18 +0200 Message-ID: <20150908132518.GE2767@phenom.ffwll.local> References: <1441717246-24484-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0EB6489BFD for ; Tue, 8 Sep 2015 06:22:36 -0700 (PDT) Received: by wicge5 with SMTP id ge5so116593966wic.0 for ; Tue, 08 Sep 2015 06:22:34 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1441717246-24484-1-git-send-email-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBTZXAgMDgsIDIwMTUgYXQgMDM6MDA6NDVQTSArMDIwMCwgVGhpZXJyeSBSZWRpbmcg d3JvdGU6Cj4gRnJvbTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KPiAKPiBU aGlzIGZ1bmN0aW9uIGNhbiBiZSB1c2VkIHRvIGR1cGxpY2F0ZSBhbiBhdG9taWMgc3RhdGUgb2Jq ZWN0LiBUaGlzIGlzCj4gdXNlZnVsIGZvciBleGFtcGxlIHRvIGltcGxlbWVudCBzdXNwZW5kL3Jl c3VtZSwgd2hlcmUgdGhlIHN0YXRlIGJlZm9yZQo+IHN1c3BlbmQgY2FuIGJlIHNhdmVkIGFuZCBy ZXN0b3JlZCB1cG9uIHJlc3VtZS4KPiAKPiB2MjogbW92ZSBsb2NraW5nIHRvIGNhbGxlciwgYmUg bW9yZSBleHBsaWNpdCBhYm91dCBwcmVyZXF1aXNpdGVzCj4gdjM6IGV4cGxpY2l0bHkgcGFzcyBs b2NrIGFjcXVpc2l0aW9uIGNvbnRleHQsIGltcHJvdmUga2VybmVsZG9jCj4gCj4gU2lnbmVkLW9m Zi1ieTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KCkFwcGxpZWQgdG8gZHJt LW1pc2Mgd2l0aCAyIHRpbnkgc3BlbGxpbmcgZml4ZXMgaW4gdGhlIGtlcm5lbGRvYy4KClRoYW5r cywgRGFuaWVsCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIHwg NzggKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBpbmNsdWRlL2RybS9k cm1fYXRvbWljX2hlbHBlci5oICAgICB8ICAzICsrCj4gIDIgZmlsZXMgY2hhbmdlZCwgODEgaW5z ZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19o ZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gaW5kZXggNjM0 YWE2MTc4MTFiLi4zMjMyZjRiODM4ZTQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9hdG9taWNfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxw ZXIuYwo+IEBAIC0yMzQ5LDYgKzIzNDksODQgQEAgZHJtX2F0b21pY19oZWxwZXJfY29ubmVjdG9y X2R1cGxpY2F0ZV9zdGF0ZShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICBFWFBP UlRfU1lNQk9MKGRybV9hdG9taWNfaGVscGVyX2Nvbm5lY3Rvcl9kdXBsaWNhdGVfc3RhdGUpOwo+ ICAKPiAgLyoqCj4gKyAqIGRybV9hdG9taWNfaGVscGVyX2R1cGxpY2F0ZV9zdGF0ZSAtIGR1cGxp Y2F0ZSBhbiBhdG9taWMgc3RhdGUgb2JqZWN0Cj4gKyAqIEBkZXY6IERSTSBkZXZpY2UKPiArICog QGN0eDogbG9jayBhY3F1aXNpdGlvbiBjb250ZXh0Cj4gKyAqCj4gKyAqIE1ha2VzIGEgY29weSBv ZiB0aGUgY3VycmVudCBhdG9taWMgc3RhdGUgYnkgbG9vcGluZyBvdmVyIGFsbCBvYmplY3RzIGFu ZAo+ICsgKiBkdXBsaWNhdGluZyB0aGVpciByZXNwZWN0aXZlIHN0YXRlcy4KPiArICoKPiArICog Tm90ZSB0aGF0IHRoaXMgdHJlYXRzIGF0b21pYyBzdGF0ZSBhcyBwZXJzaXN0ZW50IGJldHdlZW4g c2F2ZSBhbmQgcmVzdG9yZS4KPiArICogRHJpdmVycyBtdXN0IG1ha2Ugc3VyZSB0aGF0IHRoaXMg aXMgcG9zc2libGUgYW5kIHdvbid0IHJlc3VsdCBpbiBjb25mdXNpb24KPiArICogb3IgZXJyb25l b3VzIGJlaGF2aW91ci4KPiArICoKPiArICogTm90ZSB0aGF0IGlmIGNhbGxlcnMgaGF2ZW4ndCBh bHJlYWR5IGFjcXVpcmVkIGFsbCBtb2Rlc2V0IGxvY2tzIHRoaXMgbWlnaHQKPiArICogcmV0dXJu IC1FREVBRExLLCB3aGljaCBtdXN0IGJlIGhhbmRsZWQgYnkgY2FsbGluZyBkcm1fbW9kZXNldF9i YWNrb2ZmKCkuCj4gKyAqCj4gKyAqIFJldHVybnM6Cj4gKyAqIEEgcG9pbnRlciB0byB0aGUgY29w eSBvZiB0aGUgYXRvbWljIHN0YXRlIG9iamVjdCBvbiBzdWNjZXNzIG9yIGFuCj4gKyAqIEVSUl9Q VFIoKS1lbmNvZGVkIGVycm9yIGNvZGUgb24gZmFpbHVyZS4KPiArICovCj4gK3N0cnVjdCBkcm1f YXRvbWljX3N0YXRlICoKPiArZHJtX2F0b21pY19oZWxwZXJfZHVwbGljYXRlX3N0YXRlKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsCj4gKwkJCQkgIHN0cnVjdCBkcm1fbW9kZXNldF9hY3F1aXJlX2N0 eCAqY3R4KQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGU7Cj4gKwlzdHJ1 Y3QgZHJtX2Nvbm5lY3RvciAqY29ubjsKPiArCXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lOwo+ICsJ c3RydWN0IGRybV9jcnRjICpjcnRjOwo+ICsJaW50IGVyciA9IDA7Cj4gKwo+ICsJc3RhdGUgPSBk cm1fYXRvbWljX3N0YXRlX2FsbG9jKGRldik7Cj4gKwlpZiAoIXN0YXRlKQo+ICsJCXJldHVybiBF UlJfUFRSKC1FTk9NRU0pOwo+ICsKPiArCXN0YXRlLT5hY3F1aXJlX2N0eCA9IGN0eDsKPiArCj4g Kwlkcm1fZm9yX2VhY2hfY3J0YyhjcnRjLCBkZXYpIHsKPiArCQlzdHJ1Y3QgZHJtX2NydGNfc3Rh dGUgKmNydGNfc3RhdGU7Cj4gKwo+ICsJCWNydGNfc3RhdGUgPSBkcm1fYXRvbWljX2dldF9jcnRj X3N0YXRlKHN0YXRlLCBjcnRjKTsKPiArCQlpZiAoSVNfRVJSKGNydGNfc3RhdGUpKSB7Cj4gKwkJ CWVyciA9IFBUUl9FUlIoY3J0Y19zdGF0ZSk7Cj4gKwkJCWdvdG8gZnJlZTsKPiArCQl9Cj4gKwl9 Cj4gKwo+ICsJZHJtX2Zvcl9lYWNoX3BsYW5lKHBsYW5lLCBkZXYpIHsKPiArCQlzdHJ1Y3QgZHJt X3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZTsKPiArCj4gKwkJcGxhbmVfc3RhdGUgPSBkcm1fYXRv bWljX2dldF9wbGFuZV9zdGF0ZShzdGF0ZSwgcGxhbmUpOwo+ICsJCWlmIChJU19FUlIocGxhbmVf c3RhdGUpKSB7Cj4gKwkJCWVyciA9IFBUUl9FUlIocGxhbmVfc3RhdGUpOwo+ICsJCQlnb3RvIGZy ZWU7Cj4gKwkJfQo+ICsJfQo+ICsKPiArCWRybV9mb3JfZWFjaF9jb25uZWN0b3IoY29ubiwgZGV2 KSB7Cj4gKwkJc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGU7Cj4gKwo+ICsJ CWNvbm5fc3RhdGUgPSBkcm1fYXRvbWljX2dldF9jb25uZWN0b3Jfc3RhdGUoc3RhdGUsIGNvbm4p Owo+ICsJCWlmIChJU19FUlIoY29ubl9zdGF0ZSkpIHsKPiArCQkJZXJyID0gUFRSX0VSUihjb25u X3N0YXRlKTsKPiArCQkJZ290byBmcmVlOwo+ICsJCX0KPiArCX0KPiArCj4gKwkvKiBjbGVhciB0 aGUgYWNxdWlyZSBjb250ZXh0IHNvIHRoYXQgaXQgaXNuJ3QgYWNjaWRlbnRhbGx5IHJldXNlZCAq Lwo+ICsJc3RhdGUtPmFjcXVpcmVfY3R4ID0gTlVMTDsKPiArCj4gK2ZyZWU6Cj4gKwlpZiAoZXJy IDwgMCkgewo+ICsJCWRybV9hdG9taWNfc3RhdGVfZnJlZShzdGF0ZSk7Cj4gKwkJc3RhdGUgPSBF UlJfUFRSKGVycik7Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIHN0YXRlOwo+ICt9Cj4gK0VYUE9SVF9T WU1CT0woZHJtX2F0b21pY19oZWxwZXJfZHVwbGljYXRlX3N0YXRlKTsKPiArCj4gKy8qKgo+ICAg KiBfX2RybV9hdG9taWNfaGVscGVyX2Nvbm5lY3Rvcl9kZXN0cm95X3N0YXRlIC0gcmVsZWFzZSBj b25uZWN0b3Igc3RhdGUKPiAgICogQGNvbm5lY3RvcjogY29ubmVjdG9yIG9iamVjdAo+ICAgKiBA c3RhdGU6IGNvbm5lY3RvciBzdGF0ZSBvYmplY3QgdG8gcmVsZWFzZQo+IGRpZmYgLS1naXQgYS9p bmNsdWRlL2RybS9kcm1fYXRvbWljX2hlbHBlci5oIGIvaW5jbHVkZS9kcm0vZHJtX2F0b21pY19o ZWxwZXIuaAo+IGluZGV4IDRmZmU5ZGNhMDdjNC4uMTU0N2ViNDNjMTRhIDEwMDY0NAo+IC0tLSBh L2luY2x1ZGUvZHJtL2RybV9hdG9taWNfaGVscGVyLmgKPiArKysgYi9pbmNsdWRlL2RybS9kcm1f YXRvbWljX2hlbHBlci5oCj4gQEAgLTExOCw2ICsxMTgsOSBAQCBfX2RybV9hdG9taWNfaGVscGVy X2Nvbm5lY3Rvcl9kdXBsaWNhdGVfc3RhdGUoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3Rv ciwKPiAgCQkJCQkgICBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqc3RhdGUpOwo+ICBzdHJ1 Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqCj4gIGRybV9hdG9taWNfaGVscGVyX2Nvbm5lY3Rvcl9k dXBsaWNhdGVfc3RhdGUoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3Rvcik7Cj4gK3N0cnVj dCBkcm1fYXRvbWljX3N0YXRlICoKPiArZHJtX2F0b21pY19oZWxwZXJfZHVwbGljYXRlX3N0YXRl KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gKwkJCQkgIHN0cnVjdCBkcm1fbW9kZXNldF9hY3F1 aXJlX2N0eCAqY3R4KTsKPiAgdm9pZAo+ICBfX2RybV9hdG9taWNfaGVscGVyX2Nvbm5lY3Rvcl9k ZXN0cm95X3N0YXRlKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gIAkJCQkJICAg IHN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpzdGF0ZSk7Cj4gLS0gCj4gMi41LjAKPiAKCi0t IApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRw Oi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo=