From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 3/5] drm: cleanup drm_core_{init,exit}() Date: Wed, 9 Sep 2015 15:11:29 +0200 Message-ID: <20150909131129.GK2767@phenom.ffwll.local> References: <1441801293-1440-1-git-send-email-dh.herrmann@gmail.com> <1441801293-1440-4-git-send-email-dh.herrmann@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C8A86E0BB for ; Wed, 9 Sep 2015 06:08:46 -0700 (PDT) Received: by wiclk2 with SMTP id lk2so21196540wic.1 for ; Wed, 09 Sep 2015 06:08:45 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1441801293-1440-4-git-send-email-dh.herrmann@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Herrmann Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBTZXAgMDksIDIwMTUgYXQgMDI6MjE6MzFQTSArMDIwMCwgRGF2aWQgSGVycm1hbm4g d3JvdGU6Cj4gVmFyaW91cyBjbGVhbnVwcyB0byB0aGUgRFJNIGNvcmUgaW5pdGlhbGl6YXRpb24g YW5kIGV4aXQgaGFuZGxlcnM6Cj4gCj4gIC0gUmVnaXN0ZXIgY2hyZGV2IGxhc3Q6IE9uY2UgcmVn aXN0ZXJfY2hyZGV2KCkgcmV0dXJucywgb3BlbigpIHdpbGwKPiAgICBzdWNjZWVkIG9uIHRoZSBn aXZlbiBjaHJkZXZzLiBUaGlzIGlzIHVzdWFsbHkgbm90IGFuIGlzc3VlLCBhcyBubwo+ICAgIGNo YXJkZXZzIGFyZSByZWdpc3RlcmVkLCB5ZXQuIEhvd2V2ZXIsIG5vZGVzIGNhbiBiZSBjcmVhdGVk IGJ5Cj4gICAgdXNlci1zcGFjZSB2aWEgbWtub2QoMiksIGV2ZW4gdGhvdWdoIHN1Y2ggbWFqb3Iv bWlub3IgY29tYmluYXRpb25zIGFyZQo+ICAgIHVua25vd24gdG8gdGhlIGtlcm5lbC4gQXZvaWQg Y2FsbGluZyBpbnRvIGRybV9zdHViX29wZW4oKSBpbiB0aG9zZQo+ICAgIGNhc2VzLgo+ICAgIEFn YWluLCBkcm1fc3R1Yl9vcGVuKCkgd291bGQganVzdCBiYWlsIG91dCBhcyB0aGUgaW5vZGUgaXMg dW5rbm93biwKPiAgICBidXQgaXQncyByZWFsbHkgbm9uLW9idmlvdXMgaWYgeW91IGhhY2sgb24g ZHJtX3N0dWJfb3BlbigpLgo+IAo+ICAtIFVuaWZ5IGVycm9yLXBhdGhzIGludG8ganVzdCBvbmUg bGFiZWwuIEFsbCB0aGUgZXJyb3ItcGF0aCBoZWxwZXJzIGNhbgo+ICAgIGJlIGNhbGxlZCBldmVu IHRob3VnaCB0aGUgY29uc3RydWN0b3JzIHdlcmUgbm90IGNhbGxlZCB5ZXQsIG9yIGZhaWxlZC4K PiAgICBIZW5jZSwganVzdCBjYWxsIGFsbCBjbGVhbnVwcyB1bmNvbmRpdGlvbmFsbHkuCj4gCj4g IC0gQ2FsbCBpbnRvIGRybV9nbG9iYWxfcmVsZWFzZSgpLiBUaGlzIGlzIGEgbm8tb3AsIGJ1dCBw cm92aWRlcwo+ICAgIGRlYnVnZ2luZyBoZWxwZXJzIGluIGNhc2UgdGhlcmUncmUgR0xPQkFMUyBs ZWZ0IG9uIG1vZHVsZSB1bmxvYWQuIFRoaXMKPiAgICBmdW5jdGlvbiB3YXMgdW51c2VkIHVudGls IG5vdy4KPiAKPiAgLSBVc2UgRFJNX0VSUk9SKCkgaW5zdGVhZCBvZiBwcmludGsoKSwgYW5kIGFs c28gcHJpbnQgdGhlIGVycm9yLWNvZGUgb24KPiAgICBmYWlsdXJlIChldmVuIGlmIGl0IGlzIHN0 YXRpYyEpLgo+IAo+ICAtIERvbid0IHRocm93IGF3YXkgZXJyb3ItY29kZXMgb2YgcmVnaXN0ZXJf Y2hyZGV2KCkhCj4gCj4gIC0gRG9uJ3QgaGFyZGNvZGUgLTEgYXMgZXJybm8uIFRoaXMgaXMganVz dCBwbGFpbiB3cm9uZy4KPiAKPiAgLSBPcmRlciBleGl0LWhhbmRsZXJzIGluIHRoZSBleGFjdCBy ZXZlcnNlIG9yZGVyIG9mIGluaXRpYWxpemF0aW9uCj4gICAgKGV4Y2VwdCBpZiB0aGUgb3JkZXIg YWN0dWFsbHkgbWF0dGVycyBmb3Igc3luY2luZy1yZWFzb25zLCB3aGljaCBpcwo+ICAgIG5vdCB0 aGUgY2FzZSBoZXJlLCB0aG91Z2gpLgo+IAo+IFNpZ25lZC1vZmYtYnk6IERhdmlkIEhlcnJtYW5u IDxkaC5oZXJybWFubkBnbWFpbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZHJ2 LmMgfCAzNiArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNo YW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDE4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9kcnYuYwo+ IGluZGV4IDU4Mjk5ZjcuLmJmMjkyNGIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHJ2LmMKPiBAQCAtODI5LDUwICs4 MjksNTAgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBmaWxlX29wZXJhdGlvbnMgZHJtX3N0dWJfZm9w cyA9IHsKPiAgCj4gIHN0YXRpYyBpbnQgX19pbml0IGRybV9jb3JlX2luaXQodm9pZCkKPiAgewo+ IC0JaW50IHJldCA9IC1FTk9NRU07Cj4gKwlpbnQgcmV0Owo+ICAKPiAgCWRybV9nbG9iYWxfaW5p dCgpOwo+ICAJZHJtX2Nvbm5lY3Rvcl9pZGFfaW5pdCgpOwo+ICAJaWRyX2luaXQoJmRybV9taW5v cnNfaWRyKTsKPiAgCj4gLQlpZiAocmVnaXN0ZXJfY2hyZGV2KERSTV9NQUpPUiwgImRybSIsICZk cm1fc3R1Yl9mb3BzKSkKPiAtCQlnb3RvIGVycl9wMTsKPiAtCj4gIAlyZXQgPSBkcm1fc3lzZnNf aW5pdCgpOwo+ICAJaWYgKHJldCA8IDApIHsKPiAtCQlwcmludGsoS0VSTl9FUlIgIkRSTTogRXJy b3IgY3JlYXRpbmcgZHJtIGNsYXNzLlxuIik7Cj4gLQkJZ290byBlcnJfcDI7Cj4gKwkJRFJNX0VS Uk9SKCJDYW5ub3QgY3JlYXRlIERSTSBjbGFzczogJWRcbiIsIHJldCk7Cj4gKwkJZ290byBlcnJv cjsKPiAgCX0KPiAgCj4gIAlkcm1fZGVidWdmc19yb290ID0gZGVidWdmc19jcmVhdGVfZGlyKCJk cmkiLCBOVUxMKTsKPiAgCWlmICghZHJtX2RlYnVnZnNfcm9vdCkgewo+IC0JCURSTV9FUlJPUigi Q2Fubm90IGNyZWF0ZSAvc3lzL2tlcm5lbC9kZWJ1Zy9kcmlcbiIpOwo+IC0JCXJldCA9IC0xOwo+ IC0JCWdvdG8gZXJyX3AzOwo+ICsJCXJldCA9IC1FTk9NRU07Cj4gKwkJRFJNX0VSUk9SKCJDYW5u b3QgY3JlYXRlIGRlYnVnZnMtcm9vdDogJWRcbiIsIHJldCk7Cj4gKwkJZ290byBlcnJvcjsKPiAg CX0KPiAgCj4gKwlyZXQgPSByZWdpc3Rlcl9jaHJkZXYoRFJNX01BSk9SLCAiZHJtIiwgJmRybV9z dHViX2ZvcHMpOwo+ICsJaWYgKHJldCA8IDApCj4gKwkJZ290byBlcnJvcjsKPiArCj4gIAlEUk1f SU5GTygiSW5pdGlhbGl6ZWQgJXMgJWQuJWQuJWQgJXNcbiIsCj4gIAkJIENPUkVfTkFNRSwgQ09S RV9NQUpPUiwgQ09SRV9NSU5PUiwgQ09SRV9QQVRDSExFVkVMLCBDT1JFX0RBVEUpOwo+ICAJcmV0 dXJuIDA7Cj4gLWVycl9wMzoKPiAtCWRybV9zeXNmc19kZXN0cm95KCk7Cj4gLWVycl9wMjoKPiAt CXVucmVnaXN0ZXJfY2hyZGV2KERSTV9NQUpPUiwgImRybSIpOwo+ICAKPiArZXJyb3I6Cj4gKwlk ZWJ1Z2ZzX3JlbW92ZShkcm1fZGVidWdmc19yb290KTsKPiArCWRybV9zeXNmc19kZXN0cm95KCk7 Cj4gIAlpZHJfZGVzdHJveSgmZHJtX21pbm9yc19pZHIpOwo+IC1lcnJfcDE6Cj4gKwlkcm1fY29u bmVjdG9yX2lkYV9kZXN0cm95KCk7Cj4gKwlkcm1fZ2xvYmFsX3JlbGVhc2UoKTsKPiAgCXJldHVy biByZXQ7CgpTaW5jZSB1bnJlZ2lzdGVyX2NoYXJkZXYgY2FuIGNvcGUgaWYgd2UgaGF2ZW4ndCBy ZWdpc3RlcmVkIHRoZSByYW5nZSB5ZXQsCmNhbid0IHdlIGp1c3QgY2FsbCBkcm1fY29yZV9leGl0 IGhlcmUgZm9yIHNpbXBsaWNpdHkgYW5kIHJvYnVzdG5lc3M/Ci1EYW5pZWwKCj4gIH0KPiAgCj4g IHN0YXRpYyB2b2lkIF9fZXhpdCBkcm1fY29yZV9leGl0KHZvaWQpCj4gIHsKPiArCXVucmVnaXN0 ZXJfY2hyZGV2KERSTV9NQUpPUiwgImRybSIpOwo+ICAJZGVidWdmc19yZW1vdmUoZHJtX2RlYnVn ZnNfcm9vdCk7Cj4gIAlkcm1fc3lzZnNfZGVzdHJveSgpOwo+IC0KPiAtCXVucmVnaXN0ZXJfY2hy ZGV2KERSTV9NQUpPUiwgImRybSIpOwo+IC0KPiAtCWRybV9jb25uZWN0b3JfaWRhX2Rlc3Ryb3ko KTsKPiAgCWlkcl9kZXN0cm95KCZkcm1fbWlub3JzX2lkcik7Cj4gKwlkcm1fY29ubmVjdG9yX2lk YV9kZXN0cm95KCk7Cj4gKwlkcm1fZ2xvYmFsX3JlbGVhc2UoKTsKPiAgfQo+ICAKPiAgbW9kdWxl X2luaXQoZHJtX2NvcmVfaW5pdCk7Cj4gLS0gCj4gMi41LjEKPiAKCi0tIApEYW5pZWwgVmV0dGVy ClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5j aApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=