dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Rob Clark <robdclark@gmail.com>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH RFCv2 3/4] staging: etnaviv: add drm driver
Date: Wed, 16 Sep 2015 08:56:17 +0100	[thread overview]
Message-ID: <20150916075617.GZ21084@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAF6AEGu_XhGCLoZT+DwdUZgmASg8H1c=FchDpF3SxkECsohR-A@mail.gmail.com>

On Mon, Sep 14, 2015 at 09:16:01AM -0400, Rob Clark wrote:
> On Fri, Sep 11, 2015 at 10:10 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
> > From: Christian Gmeiner <christian.gmeiner@gmail.com>
> >
> > This is a squashed commit of the complete etnaviv DRM driver in order
> > to make it easy for people to review the code by seeing the driver as a
> > whole and is not intended for merging in this form.
> >
> > If you are interested in the history of individual commits:
> > git://git.pengutronix.de/git/lst/linux.git etnaviv-for-upstream
> >
> > Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> >  drivers/staging/Kconfig                      |    2 +
> >  drivers/staging/Makefile                     |    1 +
> >  drivers/staging/etnaviv/Kconfig              |   20 +
> >  drivers/staging/etnaviv/Makefile             |   18 +
> >  drivers/staging/etnaviv/cmdstream.xml.h      |  218 ++++
> >  drivers/staging/etnaviv/common.xml.h         |  249 +++++
> >  drivers/staging/etnaviv/etnaviv_buffer.c     |  271 +++++
> >  drivers/staging/etnaviv/etnaviv_cmd_parser.c |  119 +++
> >  drivers/staging/etnaviv/etnaviv_drv.c        |  705 +++++++++++++
> >  drivers/staging/etnaviv/etnaviv_drv.h        |  138 +++
> >  drivers/staging/etnaviv/etnaviv_gem.c        |  887 ++++++++++++++++
> >  drivers/staging/etnaviv/etnaviv_gem.h        |  141 +++
> >  drivers/staging/etnaviv/etnaviv_gem_prime.c  |  121 +++
> >  drivers/staging/etnaviv/etnaviv_gem_submit.c |  421 ++++++++
> >  drivers/staging/etnaviv/etnaviv_gpu.c        | 1468 ++++++++++++++++++++++++++
> >  drivers/staging/etnaviv/etnaviv_gpu.h        |  198 ++++
> >  drivers/staging/etnaviv/etnaviv_iommu.c      |  221 ++++
> >  drivers/staging/etnaviv/etnaviv_iommu.h      |   28 +
> >  drivers/staging/etnaviv/etnaviv_iommu_v2.c   |   33 +
> >  drivers/staging/etnaviv/etnaviv_iommu_v2.h   |   25 +
> >  drivers/staging/etnaviv/etnaviv_mmu.c        |  282 +++++
> >  drivers/staging/etnaviv/etnaviv_mmu.h        |   58 +
> >  drivers/staging/etnaviv/state.xml.h          |  351 ++++++
> >  drivers/staging/etnaviv/state_hi.xml.h       |  407 +++++++
> >  include/uapi/drm/etnaviv_drm.h               |  215 ++++
> >  25 files changed, 6597 insertions(+)
> >  create mode 100644 drivers/staging/etnaviv/Kconfig
> >  create mode 100644 drivers/staging/etnaviv/Makefile
> >  create mode 100644 drivers/staging/etnaviv/cmdstream.xml.h
> >  create mode 100644 drivers/staging/etnaviv/common.xml.h
> >  create mode 100644 drivers/staging/etnaviv/etnaviv_buffer.c
> >  create mode 100644 drivers/staging/etnaviv/etnaviv_cmd_parser.c
> >  create mode 100644 drivers/staging/etnaviv/etnaviv_drv.c
> >  create mode 100644 drivers/staging/etnaviv/etnaviv_drv.h
> >  create mode 100644 drivers/staging/etnaviv/etnaviv_gem.c
> >  create mode 100644 drivers/staging/etnaviv/etnaviv_gem.h
> >  create mode 100644 drivers/staging/etnaviv/etnaviv_gem_prime.c
> >  create mode 100644 drivers/staging/etnaviv/etnaviv_gem_submit.c
> >  create mode 100644 drivers/staging/etnaviv/etnaviv_gpu.c
> >  create mode 100644 drivers/staging/etnaviv/etnaviv_gpu.h
> >  create mode 100644 drivers/staging/etnaviv/etnaviv_iommu.c
> >  create mode 100644 drivers/staging/etnaviv/etnaviv_iommu.h
> >  create mode 100644 drivers/staging/etnaviv/etnaviv_iommu_v2.c
> >  create mode 100644 drivers/staging/etnaviv/etnaviv_iommu_v2.h
> >  create mode 100644 drivers/staging/etnaviv/etnaviv_mmu.c
> >  create mode 100644 drivers/staging/etnaviv/etnaviv_mmu.h
> >  create mode 100644 drivers/staging/etnaviv/state.xml.h
> >  create mode 100644 drivers/staging/etnaviv/state_hi.xml.h
> >  create mode 100644 include/uapi/drm/etnaviv_drm.h
> >
> > diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
> > index 7f6cae5beb90..5446fe4859ce 100644
> > --- a/drivers/staging/Kconfig
> > +++ b/drivers/staging/Kconfig
> > @@ -112,4 +112,6 @@ source "drivers/staging/fsl-mc/Kconfig"
> >
> >  source "drivers/staging/wilc1000/Kconfig"
> >
> > +source "drivers/staging/etnaviv/Kconfig"
> > +
> >  endif # STAGING
> > diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
> > index 347f6477aa3e..9fd3c06b6bfd 100644
> > --- a/drivers/staging/Makefile
> > +++ b/drivers/staging/Makefile
> > @@ -48,3 +48,4 @@ obj-$(CONFIG_COMMON_CLK_XLNX_CLKWZRD) += clocking-wizard/
> >  obj-$(CONFIG_FB_TFT)           += fbtft/
> >  obj-$(CONFIG_FSL_MC_BUS)       += fsl-mc/
> >  obj-$(CONFIG_WILC1000)         += wilc1000/
> > +obj-$(CONFIG_DRM_ETNAVIV)      += etnaviv/
> > diff --git a/drivers/staging/etnaviv/Kconfig b/drivers/staging/etnaviv/Kconfig
> > new file mode 100644
> > index 000000000000..6f034eda914c
> > --- /dev/null
> > +++ b/drivers/staging/etnaviv/Kconfig
> > @@ -0,0 +1,20 @@
> > +
> > +config DRM_ETNAVIV
> > +       tristate "etnaviv DRM"
> > +       depends on DRM
> > +       select SHMEM
> > +       select TMPFS
> > +       select IOMMU_API
> > +       select IOMMU_SUPPORT
> > +       default y
> > +       help
> > +         DRM driver for Vivante GPUs.
> > +
> > +config DRM_ETNAVIV_REGISTER_LOGGING
> > +       bool "etnaviv DRM register logging"
> > +       depends on DRM_ETNAVIV
> > +       default n
> > +       help
> > +         Compile in support for logging register reads/writes in a format
> > +         that can be parsed by envytools demsm tool.  If enabled, register
> > +         logging can be switched on via etnaviv.reglog=y module param.
> 
> heh, ok, didn't realize anyone else was using demsm..  I guess that is
> one of the things that I should clean up and get into upstream
> envytools tree.  (And maybe come up with a better name.. if anyone has
> any suggestions..)

Do you think you can learn to trim your replies.  You are being
completely unreasonable here - leaving thousands of lines which are
not relevant to your reply still attached.  Not only is it a waste of
bandwidth, but it bloats people's mailboxes needlessly.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-09-16  7:56 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11 14:10 [PATCH RFCv2 0/4] Etnaviv DRM driver again Lucas Stach
2015-09-11 14:10 ` [PATCH RFCv2 1/4] of: Add vendor prefix for Vivante Corporation Lucas Stach
2015-09-11 14:10 ` [PATCH RFCv2 2/4] staging: etnaviv: add devicetree bindings Lucas Stach
2015-09-11 14:10 ` [PATCH RFCv2 3/4] staging: etnaviv: add drm driver Lucas Stach
2015-09-14 13:16   ` Rob Clark
2015-09-16  7:56     ` Russell King - ARM Linux [this message]
2015-09-16  6:11   ` Christian Gmeiner
2015-09-16  7:49     ` Russell King - ARM Linux
2015-09-16 15:30     ` Lucas Stach
2015-09-16  8:04   ` Russell King - ARM Linux
2015-09-16 10:42     ` Christian Gmeiner
2015-09-16 15:36     ` Lucas Stach
2015-09-25 11:57     ` [PATCH 00/48] Etnaviv changes RFCv1->RFCv2 Lucas Stach
2015-09-25 11:57       ` [PATCH 01/48] staging: etnaviv: avoid holding struct_mutex over dma_alloc_coherent() Lucas Stach
2015-09-25 11:57       ` [PATCH 02/48] staging: etnaviv: restructure iommu handling Lucas Stach
2015-09-25 11:57       ` [PATCH 03/48] staging: etnaviv: remove compat MMU code Lucas Stach
2015-09-25 12:18         ` Russell King - ARM Linux
2015-10-21 11:35           ` Russell King - ARM Linux
2015-10-21 12:37             ` Lucas Stach
2015-10-21 13:37               ` Russell King - ARM Linux
2015-10-21 14:53                 ` Lucas Stach
2015-10-21 15:13                   ` Russell King - ARM Linux
2015-09-25 11:57       ` [PATCH 04/48] staging: etnaviv: clean up public API (part 2) Lucas Stach
2015-09-25 11:57       ` [PATCH 05/48] staging: etnaviv: rename last remaining msm_* symbols Lucas Stach
2015-09-25 11:57       ` [PATCH 06/48] staging: etnaviv: rename last remaining bits from msm to etnaviv Lucas Stach
2015-09-25 11:57       ` [PATCH 07/48] staging: etnaviv: quiten down kernel log output Lucas Stach
2015-09-25 11:57       ` [PATCH 08/48] staging: etnaviv: add proper license header to all files Lucas Stach
2015-09-25 11:57       ` [PATCH 09/48] staging: etnaviv: add Dove GPU subsystem compatible Lucas Stach
2015-09-25 11:57       ` [PATCH 10/48] staging: etnaviv: fix missing error cleanups in etnaviv_load() Lucas Stach
2015-09-25 11:57       ` [PATCH 11/48] staging: etnaviv: fix off-by-one for iommu aperture end Lucas Stach
2015-09-25 11:57       ` [PATCH 12/48] staging: etnaviv: avoid lockdep circular dependency warning Lucas Stach
2015-09-25 12:20         ` Russell King - ARM Linux
2015-09-25 11:57       ` [PATCH 13/48] staging: etnaviv: fix gpu debugfs show implementation Lucas Stach
2015-09-25 11:57       ` [PATCH 14/48] staging: etnaviv: use vm_insert_page() rather than vm_insert_mixed() Lucas Stach
2015-09-25 11:57       ` [PATCH 15/48] staging: etnaviv: etnaviv_gem_fault: reduce struct_mutex exposure Lucas Stach
2015-09-25 11:57       ` [PATCH 16/48] staging: etnaviv: give etnaviv_gem_mmap_offset() a sane behaviour Lucas Stach
2015-09-25 11:57       ` [PATCH 17/48] staging: etnaviv: allow etnaviv_ioctl_gem_info() locking to be interruptible Lucas Stach
2015-09-25 11:57       ` [PATCH 18/48] staging: etnaviv: make context a per-GPU thing Lucas Stach
2015-09-25 11:57       ` [PATCH 19/48] staging: etnaviv: switch to per-GPU fence completion implementation Lucas Stach
2015-09-25 11:57       ` [PATCH 20/48] staging: etnaviv: provide etnaviv_queue_work() Lucas Stach
2015-09-25 11:57       ` [PATCH 21/48] staging: etnaviv: use standard kernel types rather than stdint.h types Lucas Stach
2015-09-25 11:57       ` [PATCH 22/48] staging: etnaviv: no need to initialise a list_head Lucas Stach
2015-09-25 11:57       ` [PATCH 23/48] staging: etnaviv: fix oops caused by scanning for free blocks Lucas Stach
2015-09-25 11:57       ` [PATCH 24/48] staging: etnaviv: clean up etnaviv_iommu_unmap_gem() signature Lucas Stach
2015-09-25 11:57       ` [PATCH 25/48] staging: etnaviv: increase page table size to maximum Lucas Stach
2015-09-25 11:57       ` [PATCH 26/48] staging: etnaviv: fix BUG_ON when removing module Lucas Stach
2015-09-25 11:57       ` [PATCH 27/48] staging: etnaviv: provide a helper to load the GPU clock field Lucas Stach
2015-09-25 11:57       ` [PATCH 28/48] staging: etnaviv: rename GPU clock functions Lucas Stach
2015-09-25 11:57       ` [PATCH 29/48] staging: etnaviv: fix runtime resume Lucas Stach
2015-09-25 11:57       ` [PATCH 30/48] staging: etnaviv: drop event ring buffer tracking Lucas Stach
2015-09-25 11:57       ` [PATCH 31/48] staging: etnaviv: improve efficiency of command parser Lucas Stach
2015-09-25 11:57       ` [PATCH 32/48] staging: etnaviv: no point looking up the mapping for cmdstream bos Lucas Stach
2015-09-25 11:57       ` [PATCH 33/48] staging: etnaviv: copy submit command and bos in one go Lucas Stach
2015-09-25 11:57       ` [PATCH 34/48] staging: etnaviv: remove cmd buffer offset validation in submit_reloc() Lucas Stach
2015-09-25 11:57       ` [PATCH 35/48] staging: etnaviv: move mapping teardown into etnaviv_gem_free_object() Lucas Stach
2015-09-25 11:57       ` [PATCH 36/48] staging: etnaviv: add support for GEM_WAIT ioctl Lucas Stach
2015-09-25 11:57       ` [PATCH 37/48] staging: etnaviv: avoid pinning pages in CMA Lucas Stach
2015-09-25 11:57       ` [PATCH 38/48] staging: etnaviv: fix 'ret' may be used uninitialized in this function Lucas Stach
2015-09-25 11:57       ` [PATCH 39/48] staging: etnaviv: fix error: 'etnaviv_gpu_hw_resume' defined but not used Lucas Stach
2015-09-25 11:57       ` [PATCH 40/48] staging: etnaviv: debugfs: add possibility to dump kernel buffer Lucas Stach
2015-10-21 11:38         ` Russell King - ARM Linux
2015-09-25 11:57       ` [PATCH 41/48] staging: etnaviv: change etnaviv_buffer_init() to return prefetch Lucas Stach
2015-10-21 11:38         ` Russell King - ARM Linux
2015-09-25 11:57       ` [PATCH 42/48] staging: etnaviv: implement simple hang recovery Lucas Stach
2015-10-21 15:43         ` Russell King - ARM Linux
2015-09-25 11:57       ` [PATCH 43/48] staging: etnaviv: map all buffers to the GPU Lucas Stach
2015-10-21 15:23         ` Russell King - ARM Linux
2015-09-25 11:57       ` [PATCH 44/48] staging: etnaviv: implement cache maintenance on cpu_(prep|fini) Lucas Stach
2015-10-21 15:23         ` Russell King - ARM Linux
2015-09-25 11:57       ` [PATCH 45/48] staging: etnaviv: remove submit type Lucas Stach
2015-10-21 14:41         ` Russell King - ARM Linux
2015-09-25 11:57       ` [PATCH 46/48] staging: etnaviv: rewrite submit interface to use copy from user Lucas Stach
2015-10-21 14:41         ` Russell King - ARM Linux
2015-10-26 20:48         ` Russell King - ARM Linux
2015-10-27 10:46           ` Lucas Stach
2015-09-25 11:57       ` [PATCH 47/48] staging: etnaviv: don't use GEM buffer for internal ring buffer Lucas Stach
2015-10-21 14:51         ` Russell King - ARM Linux
2015-09-25 11:58       ` [PATCH 48/48] staging: etnaviv: remove CMDSTREAM GEM allocation from UAPI Lucas Stach
2015-10-21 15:29         ` Russell King - ARM Linux
2015-09-28  9:46       ` [PATCH 00/48] Etnaviv changes RFCv1->RFCv2 Christian Gmeiner
2015-09-28 10:39         ` Lucas Stach
2015-09-30  7:53           ` Christian Gmeiner
2015-10-01  8:50             ` Lucas Stach
2015-10-13  8:25             ` Lucas Stach
2015-10-20  7:20               ` Christian Gmeiner
2015-10-20  9:00                 ` Lucas Stach
2015-10-20  9:09                   ` Jon Nettleton
2015-10-20  9:40                     ` Christian Gmeiner
2015-10-20 10:42                     ` Fabio Estevam
2015-10-20  9:39                   ` Christian Gmeiner
2015-09-16 15:05   ` [PATCH RFCv2 3/4] staging: etnaviv: add drm driver Eric Anholt
2015-09-16 16:51     ` Russell King - ARM Linux
2015-09-16 18:43       ` Eric Anholt
2015-09-11 14:10 ` [PATCH RFCv2 4/4] ARM: imx6: add Vivante GPU nodes Lucas Stach
2015-09-11 14:15 ` [PATCH RFCv2 0/4] Etnaviv DRM driver again Lucas Stach
2015-10-20  9:36 ` Daniel Vetter
2015-10-21 17:04   ` Russell King - ARM Linux
2015-10-22  7:12     ` Daniel Vetter
2015-10-22  8:19       ` Lucas Stach
2015-10-22  8:42       ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150916075617.GZ21084@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@pengutronix.de \
    --cc=robdclark@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox