From: Gustavo Padovan <gustavo@padovan.org>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: sw0312.kim@samsung.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/exynos: fix missed calling of drm_prime_gem_destroy()
Date: Mon, 21 Sep 2015 13:05:43 -0300 [thread overview]
Message-ID: <20150921160543.GA5178@joana> (raw)
In-Reply-To: <1442380494-32170-1-git-send-email-jy0922.shim@samsung.com>
HI Joonyoung,
2015-09-16 Joonyoung Shim <jy0922.shim@samsung.com>:
> When obj->import_attach is existed, code calling drm_prime_gem_destroy()
> was removed from commit 67e93c808b48 ("drm/exynos: stop copying sg
> table"), and it's a fault.
>
> The drm_prime_gem_destroy() is cleanup function which GEM drivers need
> to call when they use drm_gem_prime_import() to import dma-bufs, so
> exynos-drm driver using drm_gem_prime_import() needs calling
> drm_prime_gem_destroy().
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_gem.c | 9 +++++----
> drivers/gpu/drm/exynos/exynos_drm_gem.h | 2 ++
> 2 files changed, 7 insertions(+), 4 deletions(-)
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-09-21 16:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 5:14 [PATCH] drm/exynos: fix missed calling of drm_prime_gem_destroy() Joonyoung Shim
2015-09-21 16:05 ` Gustavo Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921160543.GA5178@joana \
--to=gustavo@padovan.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jy0922.shim@samsung.com \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox