From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/dp/mst: fixup handling hotplug on port removal. Date: Wed, 30 Sep 2015 09:30:03 +0200 Message-ID: <20150930073003.GW3383@phenom.ffwll.local> References: <1442366532-23024-1-git-send-email-airlied@gmail.com> <1442366532-23024-2-git-send-email-airlied@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3BE026E106 for ; Wed, 30 Sep 2015 00:27:09 -0700 (PDT) Received: by wicgb1 with SMTP id gb1so181258264wic.1 for ; Wed, 30 Sep 2015 00:27:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1442366532-23024-2-git-send-email-airlied@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dave Airlie Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBTZXAgMTYsIDIwMTUgYXQgMTE6MjI6MTJBTSArMTAwMCwgRGF2ZSBBaXJsaWUgd3Jv dGU6Cj4gRnJvbTogRGF2ZSBBaXJsaWUgPGFpcmxpZWRAcmVkaGF0LmNvbT4KPiAKPiBvdXRwdXQg cG9ydHMgc2hvdWxkIGFsd2F5cyBoYXZlIGEgY29ubmVjdG9yLCB1bmxlc3MKPiBpbiB0aGUgcmFy ZSBjYXNlIGNvbm5lY3RvciBhbGxvY2F0aW9uIGZhaWxzIGluIHRoZQo+IGRyaXZlci4KPiAKPiBJ biB0aGlzIGNhc2Ugd2Ugb25seSBuZWVkIHRvIHRlYXJkb3duIHRoZSBwZHQsCj4gYW5kIGZyZWUg dGhlIHN0cnVjdCwgYW5kIHRoZXJlIGlzIG5vIG5lZWQgdG8KPiBzZW5kIGEgaG90cGx1ZyBtc2cu Cj4gCj4gSW4gdGhlIGNhc2Ugd2VyZSB3ZSBhZGQgdGhlIHBvcnQgdG8gdGhlIGRlc3Ryb3kKPiBs aXN0IHdlIG5lZWQgdG8gc2VuZCBhIGhvdHBsdWcgaWYgd2UgZGVzdHJveQo+IGFueSBjb25uZWN0 b3JzLCBzbyB1c2Vyc3BhY2Uga25vd3MgdG8gcmVwcm9iZQo+IHN0dWZmLgo+IAo+IHRoaXMgcGF0 Y2ggYWxzbyBoYW5kbGVzIHBvcnQtPmNvbm5lY3RvciBhbGxvY2F0aW9uCj4gZmFpbGluZyB3aGlj aCBzaG91bGQgYmUgYSByYXJlIGV2ZW50LCBidXQgbWFrZXMKPiB0aGUgY29kZSBjb25zaXN0ZW50 Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IERhdmUgQWlybGllIDxhaXJsaWVkQHJlZGhhdC5jb20+CgpS ZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZHBfbXN0X3RvcG9sb2d5LmMgfCAzNiArKysrKysrKysr KysrKysrKysrKysrKysrLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjYgaW5zZXJ0aW9u cygrKSwgMTAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9k cm1fZHBfbXN0X3RvcG9sb2d5LmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2RwX21zdF90b3BvbG9n eS5jCj4gaW5kZXggODcxMTJkMy4uZDExMDUyYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vZHJtX2RwX21zdF90b3BvbG9neS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9kcF9t c3RfdG9wb2xvZ3kuYwo+IEBAIC04NjMsMjkgKzg2MywzMyBAQCBzdGF0aWMgdm9pZCBkcm1fZHBf ZGVzdHJveV9wb3J0KHN0cnVjdCBrcmVmICprcmVmKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2RwX21z dF9wb3J0ICpwb3J0ID0gY29udGFpbmVyX29mKGtyZWYsIHN0cnVjdCBkcm1fZHBfbXN0X3BvcnQs IGtyZWYpOwo+ICAJc3RydWN0IGRybV9kcF9tc3RfdG9wb2xvZ3lfbWdyICptZ3IgPSBwb3J0LT5t Z3I7Cj4gKwo+ICAJaWYgKCFwb3J0LT5pbnB1dCkgewo+ICAJCXBvcnQtPnZjcGkubnVtX3Nsb3Rz ID0gMDsKPiAgCj4gIAkJa2ZyZWUocG9ydC0+Y2FjaGVkX2VkaWQpOwo+ICAKPiAtCQkvKiB3ZSBj YW4ndCBkZXN0cm95IHRoZSBjb25uZWN0b3IgaGVyZSwgYXMKPiAtCQkgICB3ZSBtaWdodCBiZSBo b2xkaW5nIHRoZSBtb2RlX2NvbmZpZy5tdXRleAo+IC0JCSAgIGZyb20gYW4gRURJRCByZXRyaWV2 YWwgKi8KPiArCQkvKgo+ICsJCSAqIFRoZSBvbmx5IHRpbWUgd2UgZG9uJ3QgaGF2ZSBhIGNvbm5l Y3Rvcgo+ICsJCSAqIG9uIGFuIG91dHB1dCBwb3J0IGlzIGlmIHRoZSBjb25uZWN0b3IgaW5pdAo+ ICsJCSAqIGZhaWxzLgo+ICsJCSAqLwo+ICAJCWlmIChwb3J0LT5jb25uZWN0b3IpIHsKPiArCQkJ Lyogd2UgY2FuJ3QgZGVzdHJveSB0aGUgY29ubmVjdG9yIGhlcmUsIGFzCj4gKwkJCSAqIHdlIG1p Z2h0IGJlIGhvbGRpbmcgdGhlIG1vZGVfY29uZmlnLm11dGV4Cj4gKwkJCSAqIGZyb20gYW4gRURJ RCByZXRyaWV2YWwgKi8KPiArCj4gIAkJCW11dGV4X2xvY2soJm1nci0+ZGVzdHJveV9jb25uZWN0 b3JfbG9jayk7Cj4gIAkJCWxpc3RfYWRkKCZwb3J0LT5uZXh0LCAmbWdyLT5kZXN0cm95X2Nvbm5l Y3Rvcl9saXN0KTsKPiAgCQkJbXV0ZXhfdW5sb2NrKCZtZ3ItPmRlc3Ryb3lfY29ubmVjdG9yX2xv Y2spOwo+ICAJCQlzY2hlZHVsZV93b3JrKCZtZ3ItPmRlc3Ryb3lfY29ubmVjdG9yX3dvcmspOwo+ ICAJCQlyZXR1cm47Cj4gIAkJfQo+ICsJCS8qIG5vIG5lZWQgdG8gY2xlYW4gdXAgdmNwaQo+ICsJ CSAqIGFzIGlmIHdlIGhhdmUgbm8gY29ubmVjdG9yIHdlIG5ldmVyIHNldHVwIGEgdmNwaSAqLwo+ ICAJCWRybV9kcF9wb3J0X3RlYXJkb3duX3BkdChwb3J0LCBwb3J0LT5wZHQpOwo+IC0KPiAtCQlp ZiAoIXBvcnQtPmlucHV0ICYmIHBvcnQtPnZjcGkudmNwaSA+IDApCj4gLQkJCWRybV9kcF9tc3Rf cHV0X3BheWxvYWRfaWQobWdyLCBwb3J0LT52Y3BpLnZjcGkpOwo+ICAJfQo+ICAJa2ZyZWUocG9y dCk7Cj4gLQo+IC0JKCptZ3ItPmNicy0+aG90cGx1ZykobWdyKTsKPiAgfQo+ICAKPiAgc3RhdGlj IHZvaWQgZHJtX2RwX3B1dF9wb3J0KHN0cnVjdCBkcm1fZHBfbXN0X3BvcnQgKnBvcnQpCj4gQEAg LTExMTYsMTIgKzExMjAsMjEgQEAgc3RhdGljIHZvaWQgZHJtX2RwX2FkZF9wb3J0KHN0cnVjdCBk cm1fZHBfbXN0X2JyYW5jaCAqbXN0YiwKPiAgCj4gIAkJYnVpbGRfbXN0X3Byb3BfcGF0aChtc3Ri LCBwb3J0LT5wb3J0X251bSwgcHJvcHBhdGgsIHNpemVvZihwcm9wcGF0aCkpOwo+ICAJCXBvcnQt PmNvbm5lY3RvciA9ICgqbXN0Yi0+bWdyLT5jYnMtPmFkZF9jb25uZWN0b3IpKG1zdGItPm1nciwg cG9ydCwgcHJvcHBhdGgpOwo+IC0KPiArCQlpZiAoIXBvcnQtPmNvbm5lY3Rvcikgewo+ICsJCQkv KiByZW1vdmUgaXQgZnJvbSB0aGUgcG9ydCBsaXN0ICovCj4gKwkJCW11dGV4X2xvY2soJm1zdGIt Pm1nci0+bG9jayk7Cj4gKwkJCWxpc3RfZGVsKCZwb3J0LT5uZXh0KTsKPiArCQkJbXV0ZXhfdW5s b2NrKCZtc3RiLT5tZ3ItPmxvY2spOwo+ICsJCQkvKiBkcm9wIHBvcnQgbGlzdCByZWZlcmVuY2Ug Ki8KPiArCQkJZHJtX2RwX3B1dF9wb3J0KHBvcnQpOwo+ICsJCQlnb3RvIG91dDsKPiArCQl9Cj4g IAkJaWYgKHBvcnQtPnBvcnRfbnVtID49IDgpIHsKPiAgCQkJcG9ydC0+Y2FjaGVkX2VkaWQgPSBk cm1fZ2V0X2VkaWQocG9ydC0+Y29ubmVjdG9yLCAmcG9ydC0+YXV4LmRkYyk7Cj4gIAkJfQo+ICAJ fQo+ICAKPiArb3V0Ogo+ICAJLyogcHV0IHJlZmVyZW5jZSB0byB0aGlzIHBvcnQgKi8KPiAgCWRy bV9kcF9wdXRfcG9ydChwb3J0KTsKPiAgfQo+IEBAIC0yNjcyLDcgKzI2ODUsNyBAQCBzdGF0aWMg dm9pZCBkcm1fZHBfZGVzdHJveV9jb25uZWN0b3Jfd29yayhzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndv cmspCj4gIHsKPiAgCXN0cnVjdCBkcm1fZHBfbXN0X3RvcG9sb2d5X21nciAqbWdyID0gY29udGFp bmVyX29mKHdvcmssIHN0cnVjdCBkcm1fZHBfbXN0X3RvcG9sb2d5X21nciwgZGVzdHJveV9jb25u ZWN0b3Jfd29yayk7Cj4gIAlzdHJ1Y3QgZHJtX2RwX21zdF9wb3J0ICpwb3J0Owo+IC0KPiArCWJv b2wgc2VuZF9ob3RwbHVnID0gZmFsc2U7Cj4gIAkvKgo+ICAJICogTm90IGEgcmVndWxhciBsaXN0 IHRyYXZlcnNlIGFzIHdlIGhhdmUgdG8gZHJvcCB0aGUgZGVzdHJveQo+ICAJICogY29ubmVjdG9y IGxvY2sgYmVmb3JlIGRlc3Ryb3lpbmcgdGhlIGNvbm5lY3RvciwgdG8gYXZvaWQgQUItPkJBCj4g QEAgLTI2OTUsNyArMjcwOCwxMCBAQCBzdGF0aWMgdm9pZCBkcm1fZHBfZGVzdHJveV9jb25uZWN0 b3Jfd29yayhzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4gIAkJaWYgKCFwb3J0LT5pbnB1dCAm JiBwb3J0LT52Y3BpLnZjcGkgPiAwKQo+ICAJCQlkcm1fZHBfbXN0X3B1dF9wYXlsb2FkX2lkKG1n ciwgcG9ydC0+dmNwaS52Y3BpKTsKPiAgCQlrZnJlZShwb3J0KTsKPiArCQlzZW5kX2hvdHBsdWcg PSB0cnVlOwo+ICAJfQo+ICsJaWYgKHNlbmRfaG90cGx1ZykKPiArCQkoKm1nci0+Y2JzLT5ob3Rw bHVnKShtZ3IpOwo+ICB9Cj4gIAo+ICAvKioKPiAtLSAKPiAyLjQuMwo+IAo+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcg bGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKRGFuaWVsIFZldHRl cgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwu Y2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK