From: Lukas Wunner <lukas@wunner.de>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 8/9] drm/radeon: Fix kernel-doc copy/paste snafu
Date: Mon, 12 Oct 2015 18:36:14 +0200 [thread overview]
Message-ID: <20151012163614.GA16722@wunner.de> (raw)
In-Reply-To: <CADnq5_OqQfseVQ5927St7QNGwYmvqmZLjG773EzaroWmoj_J7A@mail.gmail.com>
Hi Alex,
On Mon, Oct 12, 2015 at 12:02:13PM -0400, Alex Deucher wrote:
> On Mon, Oct 12, 2015 at 5:44 AM, Lukas Wunner <lukas@wunner.de> wrote:
> > Introduced by f482a1419545 ("drm/radeon: document radeon_kms.c").
> >
> > Signed-off-by: Lukas Wunner <lukas@wunner.de>
> > ---
> > drivers/gpu/drm/radeon/radeon_kms.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/radeon/radeon_kms.c
> > index 4e2780f..ee5cc14 100644
> > --- a/drivers/gpu/drm/radeon/radeon_kms.c
> > +++ b/drivers/gpu/drm/radeon/radeon_kms.c
> > @@ -598,11 +598,11 @@ static int radeon_info_ioctl(struct drm_device *dev, void *data, struct drm_file
> > * Outdated mess for old drm with Xorg being in charge (void function now).
> > */
> > /**
> > - * radeon_driver_firstopen_kms - drm callback for last close
> > + * radeon_driver_lastclose_kms - drm callback for last close
>
> Already fixes as part of this patch:
> http://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-fixes&id=8c70e1cda04b966b50ddfefafbd0ea376ed8edd5
Nice! I missed that because it's not yet in drm-next.
> Up to you if you want to respin the second hunk or not.
Not that important, so waived.
Thanks a lot!
Lukas
> > *
> > * @dev: drm dev pointer
> > *
> > - * Switch vga switcheroo state after last close (all asics).
> > + * Switch vga_switcheroo state after last close (all asics).
> > */
> > void radeon_driver_lastclose_kms(struct drm_device *dev)
> > {
> > --
> > 1.8.5.2 (Apple Git-48)
> >
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-10-12 16:36 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-04 9:52 [PATCH v3 0/6] Enable gpu switching on the MacBook Pro Lukas Wunner
2015-08-14 16:50 ` [PATCH v3 1/6] vga_switcheroo: Add support for switching only the DDC Lukas Wunner
2015-08-14 16:18 ` [PATCH v3 2/6] apple-gmux: Add switch_ddc support Lukas Wunner
2015-08-14 16:28 ` [PATCH v3 3/6] drm/edid: Switch DDC when reading the EDID Lukas Wunner
2015-09-11 10:40 ` [PATCH v3 4/6] drm/i915: " Lukas Wunner
2015-05-09 15:20 ` [PATCH v3 5/6] drm/nouveau: " Lukas Wunner
2015-09-12 7:44 ` [PATCH v3 6/6] drm/radeon: " Lukas Wunner
2015-10-08 3:14 ` Alex Deucher
2015-10-08 14:53 ` Lukas Wunner
2015-10-12 18:59 ` Alex Deucher
2015-10-06 7:27 ` [PATCH v3 1/6] vga_switcheroo: Add support for switching only the DDC Daniel Vetter
2015-10-06 10:10 ` Lukas Wunner
2015-10-06 11:10 ` Daniel Vetter
2015-10-06 18:27 ` Lukas Wunner
2015-10-07 7:52 ` Daniel Vetter
2015-10-12 15:17 ` [PATCH 0/9] vga_switcheroo cleanup Lukas Wunner
2015-08-28 9:56 ` [PATCH 1/9] vga_switcheroo: Use enum vga_switcheroo_state instead of int Lukas Wunner
2015-10-12 16:09 ` Alex Deucher
2015-08-28 10:54 ` [PATCH 3/9] vga_switcheroo: Use enum vga_switcheroo_client_id " Lukas Wunner
2015-10-12 16:10 ` Alex Deucher
2015-08-28 11:30 ` [PATCH 2/9] vga_switcheroo: Use VGA_SWITCHEROO_UNKNOWN_ID instead of -1 Lukas Wunner
2015-10-12 16:09 ` Alex Deucher
2015-10-13 7:28 ` Daniel Vetter
2015-10-15 18:14 ` Lukas Wunner
2015-10-16 14:25 ` Daniel Vetter
2015-09-04 18:49 ` [PATCH 4/9] ALSA: hda - Spell vga_switcheroo consistently Lukas Wunner
2015-10-12 8:57 ` [PATCH 5/9] drm/i915: Drop unnecessary #include <linux/vga_switcheroo.h> Lukas Wunner
2015-10-13 7:25 ` Daniel Vetter
2015-10-13 7:26 ` Jani Nikula
2015-10-12 9:15 ` [PATCH 6/9] drm/radeon: " Lukas Wunner
2015-10-12 9:44 ` [PATCH 8/9] drm/radeon: Fix kernel-doc copy/paste snafu Lukas Wunner
2015-10-12 16:02 ` Alex Deucher
2015-10-12 16:36 ` Lukas Wunner [this message]
2015-10-12 9:54 ` [PATCH 7/9] drm/amdgpu: Drop unnecessary #include <linux/vga_switcheroo.h> Lukas Wunner
2015-10-12 16:27 ` Alex Deucher
2015-10-12 10:00 ` [PATCH 9/9] drm/amdgpu: Fix kernel-doc copy/paste snafu Lukas Wunner
2015-10-12 16:03 ` Alex Deucher
[not found] ` <20151006182744.GA15532-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2015-10-12 17:14 ` [PATCH v4 0/6] Enable gpu switching on the MacBook Pro Lukas Wunner
[not found] ` <cover.1444670070.git.lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2015-05-09 15:20 ` [PATCH v4 5/6] drm/nouveau: Switch DDC when reading the EDID Lukas Wunner
2015-08-14 16:18 ` [PATCH v4 2/6] apple-gmux: Add switch_ddc support Lukas Wunner
2015-10-12 21:07 ` Alex Deucher
2015-10-12 21:10 ` Alex Deucher
2015-10-13 7:32 ` Daniel Vetter
2015-10-29 14:58 ` Lukas Wunner
2015-10-15 4:51 ` Darren Hart
2015-10-15 6:27 ` Daniel Vetter
2015-08-14 16:28 ` [PATCH v4 3/6] drm/edid: Switch DDC when reading the EDID Lukas Wunner
2015-08-14 16:50 ` [PATCH v4 1/6] vga_switcheroo: Add support for switching only the DDC Lukas Wunner
2015-09-11 10:40 ` [PATCH v4 4/6] drm/i915: Switch DDC when reading the EDID Lukas Wunner
2015-09-12 7:44 ` [PATCH v4 6/6] drm/radeon: " Lukas Wunner
2015-10-05 13:23 ` [PATCH v3 0/6] Enable gpu switching on the MacBook Pro Lukas Wunner
[not found] ` <20151005132349.GA15130-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2015-10-05 14:15 ` Evan Foss
2015-10-05 15:17 ` [Nouveau] " Lukas Wunner
[not found] ` <20151005151704.GA15177-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2015-10-05 15:23 ` Evan Foss
2015-10-05 15:31 ` [Nouveau] " Lukas Wunner
[not found] ` <CAM2RGhT5x9GoNU4xPwzoEoiWKqVrC2pwp3ydFgaXFwtsYiBa7A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-05 15:20 ` Pierre Moreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151012163614.GA16722@wunner.de \
--to=lukas@wunner.de \
--cc=alexdeucher@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox