From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 3/4] drm/gem: cleanup prime lock issue with drm_gem_handle_create_tail Date: Thu, 15 Oct 2015 08:36:05 +0200 Message-ID: <20151015063605.GO26718@phenom.ffwll.local> References: <1444873901-32043-1-git-send-email-airlied@gmail.com> <1444873901-32043-4-git-send-email-airlied@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by gabe.freedesktop.org (Postfix) with ESMTPS id 88AC96E816 for ; Wed, 14 Oct 2015 23:33:11 -0700 (PDT) Received: by wicgb1 with SMTP id gb1so258003414wic.1 for ; Wed, 14 Oct 2015 23:33:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1444873901-32043-4-git-send-email-airlied@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dave Airlie Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBPY3QgMTUsIDIwMTUgYXQgMTE6NTE6NDBBTSArMTAwMCwgRGF2ZSBBaXJsaWUgd3Jv dGU6Cj4gRnJvbTogRGF2ZSBBaXJsaWUgPGFpcmxpZWRAcmVkaGF0LmNvbT4KPiAKPiBUaGlzIHBh dGNoIGNsZWFucyB1cCBvbmUgbG9ja2luZyBvcmRlciBpc3N1ZSB3aXRoIGEgZGVhZGxvY2sgb24K PiB0aGUgcHJpbWUgbG9jay4KPiAKPiBJdCBhdm9pZHMgY2FsbGluZyB0aGUgcHJpbWUgZGVsZXRl IGZ1bmN0aW9uIGZyb20gZHJtX2dlbV9oYW5kbGVfY3JlYXRlX3RhaWwsCj4gYW5kIGluc3RlYWQg b3BlbiBjb2RlcyB0aGUgZXhpdCBwYXRocywgaXQgYWxzbyBzcGxpdHMgdGhlIGNvbW1vbiBjb2Rl Cj4gb3V0IGZvciB0aGUgZXhpdCBwYXRoIHdoaWNoIGNhbiB1c2UgaXQuCj4gCj4gVGhpcyBtZWFu cyB0aGUgY2FsbGVlIGhhcyB0byBjYWxsIHRoZSBwcmltZSBjbGVhbnVwIHBhdGhzLCB3aGljaCBp cyBmaW5lCj4gc2luY2UgdGhpcyBpcyBvbmx5IHRoZSBwcmltZSBjb2RlIGFuZCBpdCBob2xkcyB0 aGUgbG9jayBhbHJlYWR5Lgo+IAo+IFRoaXMgaXMgYmFzZWQgb24gYW4gcGF0Y2gvaWRlYSBieSBE YW5pZWwgVmV0dGVyLCBidXQgSSd2ZSBjbGVhbmVkIGl0IHVwCj4gYW5kIHJld29ya2VkIGl0Lgo+ IAo+IFNpZ25lZC1vZmYtYnk6IERhdmUgQWlybGllIDxhaXJsaWVkQHJlZGhhdC5jb20+Cj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMgICB8IDU1ICsrKysrKysrKysrKysrKysrKysr KysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX3ByaW1lLmMg fCAgMyArKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCAzNiBpbnNlcnRpb25zKCspLCAyMiBkZWxldGlv bnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9nZW0uYyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fZ2VtLmMKPiBpbmRleCAxMmQwZGM3Li40OTM1NGQ3IDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X2dlbS5jCj4gQEAgLTIzOSwxNCArMjM5LDEyIEBAIGRybV9nZW1fb2JqZWN0X2hhbmRsZV91bnJl ZmVyZW5jZV91bmxvY2tlZChzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaikKPiAgCWRybV9nZW1f b2JqZWN0X3VucmVmZXJlbmNlX3VubG9ja2VkKG9iaik7Cj4gIH0KPiAgCj4gKy8qIHVzZSBmb3Ig ZGVsZXRpb24gYW5kIGZhaWx1cmUgaW4gYWxsb2NhdGlvbiAqLwo+ICBzdGF0aWMgdm9pZAo+IC1k cm1fZ2VtX2hhbmRsZV9kZWxldGVfdGFpbChzdHJ1Y3QgZHJtX2ZpbGUgKmZpbHAsCj4gLQkJCSAg IHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2JqKQo+ICtkcm1fZ2VtX2hhbmRsZV9jbGVhbnVwKHN0 cnVjdCBkcm1fZmlsZSAqZmlscCwKPiArCQkgICAgICAgc3RydWN0IGRybV9nZW1fb2JqZWN0ICpv YmopCj4gIHsKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBvYmotPmRldjsKPiAtCj4gLQlp ZiAoZHJtX2NvcmVfY2hlY2tfZmVhdHVyZShkZXYsIERSSVZFUl9QUklNRSkpCj4gLQkJZHJtX2dl bV9yZW1vdmVfcHJpbWVfaGFuZGxlcyhvYmosIGZpbHApOwo+ICAJZHJtX3ZtYV9ub2RlX3Jldm9r ZSgmb2JqLT52bWFfbm9kZSwgZmlscC0+ZmlscCk7Cj4gIAo+ICAJaWYgKGRldi0+ZHJpdmVyLT5n ZW1fY2xvc2Vfb2JqZWN0KQo+IEBAIC0yNTQsNiArMjUyLDE3IEBAIGRybV9nZW1faGFuZGxlX2Rl bGV0ZV90YWlsKHN0cnVjdCBkcm1fZmlsZSAqZmlscCwKPiAgCWRybV9nZW1fb2JqZWN0X2hhbmRs ZV91bnJlZmVyZW5jZV91bmxvY2tlZChvYmopOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZAo+ICtk cm1fZ2VtX2hhbmRsZV9kZWxldGVfdGFpbF9wcmltZShzdHJ1Y3QgZHJtX2ZpbGUgKmZpbHAsCj4g KwkJCQkgc3RydWN0IGRybV9nZW1fb2JqZWN0ICpvYmopCj4gK3sKPiArCXN0cnVjdCBkcm1fZGV2 aWNlICpkZXYgPSBvYmotPmRldjsKPiArCj4gKwlpZiAoZHJtX2NvcmVfY2hlY2tfZmVhdHVyZShk ZXYsIERSSVZFUl9QUklNRSkpCj4gKwkJZHJtX2dlbV9yZW1vdmVfcHJpbWVfaGFuZGxlcyhvYmos IGZpbHApOwo+ICsJZHJtX2dlbV9oYW5kbGVfY2xlYW51cChmaWxwLCBvYmopOwo+ICt9Cj4gKwo+ ICAvKioKPiAgICogZHJtX2dlbV9oYW5kbGVfZGVsZXRlIC0gZGVsZXRlcyB0aGUgZ2l2ZW4gZmls ZS1wcml2YXRlIGhhbmRsZQo+ICAgKiBAZmlscDogZHJtIGZpbGUtcHJpdmF0ZSBzdHJ1Y3R1cmUg dG8gdXNlIGZvciB0aGUgaGFuZGxlIGxvb2sgdXAKPiBAQCAtMjkxLDcgKzMwMCw3IEBAIGRybV9n ZW1faGFuZGxlX2RlbGV0ZShzdHJ1Y3QgZHJtX2ZpbGUgKmZpbHAsIHUzMiBoYW5kbGUpCj4gIAlp ZHJfcmVtb3ZlKCZmaWxwLT5vYmplY3RfaWRyLCBoYW5kbGUpOwo+ICAJc3Bpbl91bmxvY2soJmZp bHAtPnRhYmxlX2xvY2spOwo+ICAKPiAtCWRybV9nZW1faGFuZGxlX2RlbGV0ZV90YWlsKGZpbHAs IG9iaik7Cj4gKwlkcm1fZ2VtX2hhbmRsZV9kZWxldGVfdGFpbF9wcmltZShmaWxwLCBvYmopOwo+ ICAJcmV0dXJuIDA7Cj4gIH0KPiAgRVhQT1JUX1NZTUJPTChkcm1fZ2VtX2hhbmRsZV9kZWxldGUp Owo+IEBAIC0zMzMsNiArMzQyLDE3IEBAIGRybV9nZW1faGFuZGxlX2NyZWF0ZV90YWlsKHN0cnVj dCBkcm1fZmlsZSAqZmlsZV9wcml2LAo+ICAKPiAgCVdBUk5fT04oIW11dGV4X2lzX2xvY2tlZCgm ZGV2LT5vYmplY3RfbmFtZV9sb2NrKSk7Cj4gIAo+ICsJcmV0ID0gZHJtX3ZtYV9ub2RlX2FsbG93 KCZvYmotPnZtYV9ub2RlLCBmaWxlX3ByaXYtPmZpbHApOwo+ICsJaWYgKHJldCkgewo+ICsJCWdv dG8gb3V0X3VubG9jazsKPiArCX0KPiArCj4gKwlpZiAoZGV2LT5kcml2ZXItPmdlbV9vcGVuX29i amVjdCkgewo+ICsJCXJldCA9IGRldi0+ZHJpdmVyLT5nZW1fb3Blbl9vYmplY3Qob2JqLCBmaWxl X3ByaXYpOwo+ICsJCWlmIChyZXQpCj4gKwkJCWdvdG8gb3V0X3ZtYTsKPiArCX0KPiArCj4gIAkv Kgo+ICAJICogR2V0IHRoZSB1c2VyLXZpc2libGUgaGFuZGxlIHVzaW5nIGlkci4gIFByZWxvYWQg YW5kIHBlcmZvcm0KPiAgCSAqIGFsbG9jYXRpb24gdW5kZXIgb3VyIHNwaW5sb2NrLgo+IEBAIC0z NDcsMjYgKzM2NywxNyBAQCBkcm1fZ2VtX2hhbmRsZV9jcmVhdGVfdGFpbChzdHJ1Y3QgZHJtX2Zp bGUgKmZpbGVfcHJpdiwKPiAgCWlkcl9wcmVsb2FkX2VuZCgpOwo+ICAJbXV0ZXhfdW5sb2NrKCZk ZXYtPm9iamVjdF9uYW1lX2xvY2spOwo+ICAJaWYgKHJldCA8IDApIHsKPiAtCQlkcm1fZ2VtX29i amVjdF9oYW5kbGVfdW5yZWZlcmVuY2VfdW5sb2NrZWQob2JqKTsKPiArCQlkcm1fZ2VtX2hhbmRs ZV9jbGVhbnVwKGZpbGVfcHJpdiwgb2JqKTsKPiAgCQlyZXR1cm4gcmV0Owo+ICAJfQo+ICAJKmhh bmRsZXAgPSByZXQ7Cj4gIAo+IC0JcmV0ID0gZHJtX3ZtYV9ub2RlX2FsbG93KCZvYmotPnZtYV9u b2RlLCBmaWxlX3ByaXYtPmZpbHApOwo+IC0JaWYgKHJldCkgewo+IC0JCWRybV9nZW1faGFuZGxl X2RlbGV0ZShmaWxlX3ByaXYsICpoYW5kbGVwKTsKPiAtCQlyZXR1cm4gcmV0Owo+IC0JfQo+IC0K PiAtCWlmIChkZXYtPmRyaXZlci0+Z2VtX29wZW5fb2JqZWN0KSB7Cj4gLQkJcmV0ID0gZGV2LT5k cml2ZXItPmdlbV9vcGVuX29iamVjdChvYmosIGZpbGVfcHJpdik7Cj4gLQkJaWYgKHJldCkgewo+ IC0JCQlkcm1fZ2VtX2hhbmRsZV9kZWxldGUoZmlsZV9wcml2LCAqaGFuZGxlcCk7Cj4gLQkJCXJl dHVybiByZXQ7Cj4gLQkJfQo+IC0JfQo+IC0KPiAgCXJldHVybiAwOwo+ICtvdXRfdm1hOgo+ICsJ ZHJtX3ZtYV9ub2RlX3Jldm9rZSgmb2JqLT52bWFfbm9kZSwgZmlsZV9wcml2LT5maWxwKTsKPiAr b3V0X3VubG9jazoKPiArCW11dGV4X3VubG9jaygmZGV2LT5vYmplY3RfbmFtZV9sb2NrKTsKPiAr CXJldHVybiByZXQ7Cj4gIH0KPiAgCj4gIC8qKgo+IEBAIC03MTcsNyArNzI4LDcgQEAgZHJtX2dl bV9vYmplY3RfcmVsZWFzZV9oYW5kbGUoaW50IGlkLCB2b2lkICpwdHIsIHZvaWQgKmRhdGEpCj4g IAlzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdiA9IGRhdGE7Cj4gIAlzdHJ1Y3QgZHJtX2dlbV9v YmplY3QgKm9iaiA9IHB0cjsKPiAgCj4gLQlkcm1fZ2VtX2hhbmRsZV9kZWxldGVfdGFpbChmaWxl X3ByaXYsIG9iaik7Cj4gKwlkcm1fZ2VtX2hhbmRsZV9kZWxldGVfdGFpbF9wcmltZShmaWxlX3By aXYsIG9iaik7Cj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2RybV9wcmltZS5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcmltZS5jCj4gaW5kZXgg ZDIyY2U4My4uODhjMDA0ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3ByaW1l LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3ByaW1lLmMKPiBAQCAtNTkwLDYgKzU5MCw5 IEBAIGludCBkcm1fZ2VtX3ByaW1lX2ZkX3RvX2hhbmRsZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 LAo+ICAKPiAgCS8qIGRybV9nZW1faGFuZGxlX2NyZWF0ZV90YWlsIHVubG9ja3MgZGV2LT5vYmpl Y3RfbmFtZV9sb2NrLiAqLwo+ICAJcmV0ID0gZHJtX2dlbV9oYW5kbGVfY3JlYXRlX3RhaWwoZmls ZV9wcml2LCBvYmosIGhhbmRsZSk7Cj4gKwlpZiAocmV0KQo+ICsJCWRybV9wcmltZV9yZW1vdmVf YnVmX2hhbmRsZV9sb2NrZWQoJmZpbGVfcHJpdi0+cHJpbWUsCj4gKwkJCQkJCSAgIG9iai0+ZG1h X2J1Zik7CgpXaHkgaXMgdGhpcyBuZWVkZWQ/IFdlIGhhdmVuJ3QgeWV0IGFkZGVkIHRoZSBoYW5k bGUgdGhlIGJ1ZmZlciBsb29rdXAKdGFibGUgYXQgdGhpcyBwb2ludC4gdGhlIGNyZWF0ZV9oYW5k bGVfdGFpbCBjaGFuZ2VzIGxvb2sgZ29vZCwgc28gd2l0aAp0aGlzIGh1bmsgaGVyZSByZW1vdmVk IHRoZSBwYXRjaCBpcwoKUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJA ZmZ3bGwuY2g+Cj4gIAlkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZV91bmxvY2tlZChvYmopOwo+ ICAJaWYgKHJldCkKPiAgCQlnb3RvIG91dF9wdXQ7Cj4gLS0gCj4gMi41LjAKPiAKPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWls aW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkRhbmllbCBW ZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZm d2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==