From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/gem: Use kref_get_unless_zero for the weak mmap references Date: Thu, 15 Oct 2015 13:11:36 +0200 Message-ID: <20151015111136.GX26718@phenom.ffwll.local> References: <1444894601-5200-12-git-send-email-daniel.vetter@ffwll.ch> <1444901623-18918-1-git-send-email-daniel.vetter@ffwll.ch> <20151015100659.GA27669@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by gabe.freedesktop.org (Postfix) with ESMTPS id 62C626E117 for ; Thu, 15 Oct 2015 04:08:43 -0700 (PDT) Received: by wicgb1 with SMTP id gb1so267271658wic.1 for ; Thu, 15 Oct 2015 04:08:41 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20151015100659.GA27669@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson , Daniel Vetter , DRI Development , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBPY3QgMTUsIDIwMTUgYXQgMTE6MDY6NTlBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIFRodSwgT2N0IDE1LCAyMDE1IGF0IDExOjMzOjQzQU0gKzAyMDAsIERhbmllbCBW ZXR0ZXIgd3JvdGU6Cj4gPiBDb21wYXJlZCB0byB3cmFwcGluZyB0aGUgZmluYWwga3JlZl9wdXQg d2l0aCBkZXYtPnN0cnVjdF9tdXRleCB0aGlzCj4gPiBhbGxvd3MgdXMgdG8gb25seSBhY3F1aXJl IHRoZSBvZmZzZXQgbWFuYWdlciBsb29rIGJvdGggaW4gdGhlIGZpbmFsCj4gPiBjbGVhbnVwIGFu ZCBpbiB0aGUgbG9va3VwLiBXaGljaCBoYXMgdGhlIHVwc2lkZSB0aGF0IG5vIGxvY2tzIGxlYWsg b3V0Cj4gPiBvZiB0aGUgY29yZSBhYnN0cmFjdGlvbnMuIEJ1dCBpdCBtZWFucyB0aGF0IHdlIG5l ZWQgdG8gaG9sZCBhCj4gPiB0ZW1wb3JhcnkgcmVmZXJlbmNlIHRvIHRoZSBvYmplY3Qgd2hpbGUg Y2hlY2tpbmcgbW1hcCBjb25zdHJhaW50cywgdG8KPiA+IG1ha2Ugc3VyZSB0aGUgb2JqZWN0IGRv ZXNuJ3QgZGlzYXBwZWFyLiBFeHRlbmRlZCB0aGUgY3JpdGljYWwgcmVnaW9uCj4gPiB3b3VsZCBo YXZlIHdvcmtlZCB0b28sIGJ1dCB3b3VsZCByZXN1bHQgaW4gbW9yZSBsZWFreSBsb2NraW5nLgo+ ID4gCj4gPiBBbHNvLCB0aGlzIGlzIHRoZSBmaW5hbCBiaXQgd2hpY2ggcmVxdWlyZWQgZGV2LT5z dHJ1Y3RfbXV0ZXggaW4gZ2VtCj4gPiBjb3JlLCBub3cgbW9kZXJuIGRyaXZlcnMgY2FuIGJlIGNv bXBsZXRlbHkgc3RydWN0X211dGV4IGZyZWUhCj4gPiAKPiA+IFRoaXMgbmVlZHMgYSBuZXcgZHJt X3ZtYV9vZmZzZXRfZXhhY3RfbG9va3VwX2xvY2tlZCBhbmQgbWFrZXMgYm90aAo+ID4gZHJtX3Zt YV9vZmZzZXRfZXhhY3RfbG9va3VwIGFuZCBkcm1fdm1hX29mZnNldF9sb29rdXAgdW51c2VkLgo+ ID4gCj4gPiB2MjogRG9uJ3QgbGVhayBvYmplY3QgcmVmZXJlbmNlcyBpbiBmYWlsdXJlIHBhdGhz IChEYXZpZCkuCj4gPiAKPiA+IENjOiBEYXZpZCBIZXJybWFubiA8ZGguaGVycm1hbm5AZ21haWwu Y29tPgo+ID4gUmV2aWV3ZWQtYnk6IERhdmlkIEhlcnJtYW5uIDxkaC5oZXJybWFubkBnbWFpbC5j b20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVs LmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMgICAgICAgICB8IDMw ICsrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV92 bWFfbWFuYWdlci5jIHwgNDAgKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t Cj4gPiAgaW5jbHVkZS9kcm0vZHJtX3ZtYV9tYW5hZ2VyLmggICAgIHwgMjIgKysrKysrLS0tLS0t LS0tLS0tLS0tCj4gPiAgMyBmaWxlcyBjaGFuZ2VkLCAzNiBpbnNlcnRpb25zKCspLCA1NiBkZWxl dGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbS5jCj4gPiBpbmRleCBhYjhlYTQyMjY0ZjQuLjY2M2Zh ZGJlOTc5ZSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMKPiA+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMKPiA+IEBAIC04NjIsMzAgKzg2MiwzNiBAQCBp bnQgZHJtX2dlbV9tbWFwKHN0cnVjdCBmaWxlICpmaWxwLCBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3Qg KnZtYSkKPiA+ICB7Cj4gPiAgCXN0cnVjdCBkcm1fZmlsZSAqcHJpdiA9IGZpbHAtPnByaXZhdGVf ZGF0YTsKPiA+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IHByaXYtPm1pbm9yLT5kZXY7Cj4g PiAtCXN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2JqOwo+ID4gKwlzdHJ1Y3QgZHJtX2dlbV9vYmpl Y3QgKm9iaiA9IE5VTEw7Cj4gPiAgCXN0cnVjdCBkcm1fdm1hX29mZnNldF9ub2RlICpub2RlOwo+ ID4gIAlpbnQgcmV0Owo+ID4gIAo+ID4gIAlpZiAoZHJtX2RldmljZV9pc191bnBsdWdnZWQoZGV2 KSkKPiA+ICAJCXJldHVybiAtRU5PREVWOwo+ID4gIAo+IAo+IC8qIGJsYSBibGEgYmxhCj4gICog V2hlbiB0aGUgb2JqZWN0IGlzIGJlaW5nIGZyZWVkLCBhZnRlciBpdCBoaXRzIDAtcmVmY250Cj4g ICogaXQgYWNxdWlyZXMgdGhlIHN0cnVjdF9tdXRleCBhbmQgcHJvY2VlZHMgdG8gdGVhciBkb3du Cj4gICogdGhlIG9iamVjdC4gSW4gdGhlIHByb2Nlc3MgaXQgd2lsbCBhdHRlbXB0IHRvIHJlbW92 ZQo+ICAqIHRoZSBWTUEgb2Zmc2V0IGFuZCBzbyBhY3F1aXJlIHRoaXMgbWdyLT52bV9sb2NrLgo+ ICAqIFRoZXJlZm9yZSBpZiB3ZSBmaW5kIGFuIG9iamVjdCB3aXRoIGEgMC1yZWZjbnQgdGhhdCBt YXRjaGVzCj4gICogb3VyIHJhbmdlLCB3ZSBrbm93IGl0IGlzIGluIHRoZSBwcm9jZXNzIG9mIGJl aW5nIGRlc3Ryb3llZAo+ICAqIGFuZCB3aWxsIGJlIGZyZWVkIGFzIHNvb24gYXMgd2UgcmVsZWFz ZSB0aGUgbG9jayAtIHNvCj4gICogd2UgaGF2ZSB0byBjaGVjayBmb3IgdGhlIDAtcmVmY250ZWQg b2JqZWN0IGFuZCB0cmVhdCBpdCBhcwo+ICAqIGludmFsaWQuCj4gICovCgpBcyBkaXNjdXNzZWQg b24gaXJjIHN0cnVjdF9tdXRleCBpcyBqdXN0IGEgZGlncmVzc2lvbiwgc28gSSBsZWZ0IHRoYXQg cGFydApvdXQgd2hlbiBhZGRpbmcgeW91ciBjb21tZW50LgoKPiA+IC0JbXV0ZXhfbG9jaygmZGV2 LT5zdHJ1Y3RfbXV0ZXgpOwo+ID4gKwlkcm1fdm1hX29mZnNldF9sb2NrX2xvb2t1cChkZXYtPnZt YV9vZmZzZXRfbWFuYWdlcik7Cj4gPiArCW5vZGUgPSBkcm1fdm1hX29mZnNldF9leGFjdF9sb29r dXBfbG9ja2VkKGRldi0+dm1hX29mZnNldF9tYW5hZ2VyLAo+ID4gKwkJCQkJCSAgdm1hLT52bV9w Z29mZiwKPiA+ICsJCQkJCQkgIHZtYV9wYWdlcyh2bWEpKTsKPiA+ICsJaWYgKGxpa2VseShub2Rl KSkgewo+ID4gKwkJb2JqID0gY29udGFpbmVyX29mKG5vZGUsIHN0cnVjdCBkcm1fZ2VtX29iamVj dCwgdm1hX25vZGUpOwo+ID4gKwkJaWYgKCFrcmVmX2dldF91bmxlc3NfemVybygmb2JqLT5yZWZj b3VudCkpCj4gPiArCQkJb2JqID0gTlVMTDsKPiA+ICsJfQo+ID4gKwlkcm1fdm1hX29mZnNldF91 bmxvY2tfbG9va3VwKGRldi0+dm1hX29mZnNldF9tYW5hZ2VyKTsKPiAKPiBSZXZpZXdlZC1ieTog Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+CgpBbGwgZm91ciBjb3JlIGdl bSBwYXRjaGVzIG5vdyBtZXJnZWQgaW4gZHJtLW1pc2MsIHRoYW5rcyBmb3IgdGhlIHJldmlldy4K LURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9y YXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK