From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: fix mutex leak in drm_dp_get_mst_branch_device Date: Fri, 16 Oct 2015 19:24:16 +0200 Message-ID: <20151016172416.GL13786@phenom.ffwll.local> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTPS id BDD956E2A3 for ; Fri, 16 Oct 2015 10:24:20 -0700 (PDT) Received: by wijp11 with SMTP id p11so20243910wij.0 for ; Fri, 16 Oct 2015 10:24:19 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Adam Richter Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBPY3QgMTYsIDIwMTUgYXQgMDM6MzM6MDJBTSAtMDcwMCwgQWRhbSBSaWNodGVyIHdy b3RlOgo+IEluIExpbnV4IDQuMy1yYzUsIHRoZXJlIGlzIGFuIGVycm9yIGNhc2UgaW4gZHJtX2Rw X2dldF9icmFuY2hfZGV2aWNlCj4gdGhhdCByZXR1cm5zIHdpdGhvdXQgcmVsZWFzaW5nIG1nci0+ bG9jaywgcmVzdWx0aW5nIGEgc3BldyBvZiBrZXJuZWwKPiBtZXNzYWdlcyBhYm91dCBhIGtlcm5l bCB3b3JrIGZ1bmN0aW9uIHBvc3NpYmx5IGhhdmluZyBsZWFrZWQgYSBtdXRleAo+IGFuZCBwcmVz dW1hYmx5IG1vcmUgc2VyaW91cyBhZHZlcnNlIGNvbnNlcXVlbmNlcyBsYXRlci4gIFRoaXMgcGF0 Y2gKPiBjaGFuZ2VzIHRoZSBlcnJvciB0byAiZ290byBvdXQiIHRvIHVubG9jayB0aGUgbXV0ZXgg YmVmb3JlIHJldHVybmluZy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBBZGFtIEouIFJpY2h0ZXIgPGFk YW1fcmljaHRlcjIwMDRAeWFob28uY29tPgoKUGF0Y2ggd2FzIHdoaXRlc3BhY2UgbWFuZ2xlZCAo ZG9uJ3QgcGFzdCB0aGVtIGludG8geW91ciBtYWlsZXIgYnV0IGluc3RlYWQKc2VuZCB0aGVtIHdp dGggZ2l0IHNlbmQtZW1haWwgZGlyZWN0bHksIHRoYXQncyBzYWZlciksIHNvIEkgaGFkIHRvCnJl Y3JlYXRlIGl0LgoKQXBwbGllZCB0byBkcm0tbWlzYywgdGhhbmtzLgotRGFuaWVsCgo+IC0tLQo+ IAo+IGJ1Z3ppbGxhLmZyZWVkZXNrdG9wLm9yZyB0aWNrZXQ6Cj4gaHR0cHM6Ly9idWdzLmZyZWVk ZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI0ODAKPiAKPiBUaGlzIHBhdGNoIGlzIGFnYWlu c3QgdGhlIGxhdGVzdAo+IGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVs L2dpdC90b3J2YWxkcy9saW51eC5naXQgLiAgSQo+IGFwb2xvZ2l6ZSBpbiBhZHZhbmNlIGluIEkg c2hvdWxkIGJlIHN1Ym1pdHRpbmcgcGF0Y2hlcyBhZ2FpbnN0IHNvbWUKPiBvdGhlciByZWZlcmVu Y2UuICBQbGVhc2UgZmVlbCBmcmVlIHRvIGxldCBtZSBrbm93IGlmIEkgc2hvdWxkIHVzZSBzb21l Cj4gb3RoZXIgcmVmZXJlbmNlIGZvciBzdWJtaXR0aW5nIGZ1dHVyZSBwYXRjaGVzLgo+IAo+IE15 IHJlcXVlc3QgdG8gc3Vic2NyaWJlIHRvIGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcg aXMgcGVuZGluZywKPiBzbyBJIGFwb2xvZ2l6ZSBpZiBpdCB0YWtlcyBhIHdoaWxlIGZvciB0aGlz IG1lc3NhZ2UgdG8gYmUgcG9zdGVkIG9uCj4gdGhlIG1haWxpbmcgbGlzdC4KPiAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9kcF9tc3RfdG9wb2xvZ3kuYwo+IGIvZHJpdmVycy9n cHUvZHJtL2RybV9kcF9tc3RfdG9wb2xvZ3kuYwo+IGluZGV4IGJmMjdhMDcuLjAxOGFkN2YgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9kcF9tc3RfdG9wb2xvZ3kuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9kcm1fZHBfbXN0X3RvcG9sb2d5LmMKPiBAQCAtMTE5NCwxNyArMTE5 NCwxOCBAQCBzdGF0aWMgc3RydWN0IGRybV9kcF9tc3RfYnJhbmNoCj4gKmRybV9kcF9nZXRfbXN0 X2JyYW5jaF9kZXZpY2Uoc3RydWN0IGRybV9kcF9tc3RfCj4gCj4gICAgICAgICAgICAgICAgIGxp c3RfZm9yX2VhY2hfZW50cnkocG9ydCwgJm1zdGItPnBvcnRzLCBuZXh0KSB7Cj4gICAgICAgICAg ICAgICAgICAgICAgICAgaWYgKHBvcnQtPnBvcnRfbnVtID09IHBvcnRfbnVtKSB7Cj4gLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoIXBvcnQtPm1zdGIpIHsKPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIG1zdGIgPSBwb3J0LT5tc3RiOwo+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgaWYgKCFtc3RiKSB7Cj4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIERSTV9FUlJPUigiZmFpbGVkIHRvIGxvb2t1cAo+IE1TVEIgd2l0aCBs Y3QgJWQsIHJhZCAlMDJ4XG4iLCBsY3QsIHJhZFswXSk7Cj4gLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHJldHVybiBOVUxMOwo+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBnb3RvIG91dDsKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIH0KPiAKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1zdGIgPSBwb3J0LT5t c3RiOwo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gICAgICAgICAg ICAgICAgICAgICAgICAgfQo+ICAgICAgICAgICAgICAgICB9Cj4gICAgICAgICB9Cj4gICAgICAg ICBrcmVmX2dldCgmbXN0Yi0+a3JlZik7Cj4gKyBvdXQ6Cj4gICAgICAgICBtdXRleF91bmxvY2so Jm1nci0+bG9jayk7Cj4gICAgICAgICByZXR1cm4gbXN0YjsKPiAgfQo+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlz dAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKRGFuaWVsIFZldHRlcgpT b2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK