From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/fb-helper: Fix fb refcounting in pan_display_atomic Date: Fri, 16 Oct 2015 19:26:55 +0200 Message-ID: <20151016172655.GM13786@phenom.ffwll.local> References: <1445012594-25988-1-git-send-email-daniel.vetter@ffwll.ch> <1445012594-25988-2-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: Daniel Vetter , Intel Graphics Development , DRI Development , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBPY3QgMTYsIDIwMTUgYXQgMDQ6NDg6MTJQTSArMDAwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IFRoYW5rcyEKPiAKPiBUZXN0ZWQtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZp QGludGVsLmNvbT4KPiAKPiAKPiBPbiBGcmksIE9jdCAxNiwgMjAxNSBhdCA5OjM1IEFNIFJvYiBD bGFyayA8cm9iZGNsYXJrQGdtYWlsLmNvbT4gd3JvdGU6Cj4gCj4gPiBPbiBGcmksIE9jdCAxNiwg MjAxNSBhdCAxMjoyMyBQTSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4K PiA+IHdyb3RlOgo+ID4gPiBJbgo+ID4gPgo+ID4gPiBjb21taXQgYmJiMWU1MjQwMmIyYTI4OGIw OWFlMzdlODE4MjU5OTkzMWM3ZTlkZgo+ID4gPiBBdXRob3I6IFJvYiBDbGFyayA8cm9iZGNsYXJr QGdtYWlsLmNvbT4KPiA+ID4gRGF0ZTogICBUdWUgQXVnIDI1IDE1OjM1OjU4IDIwMTUgLTA0MDAK PiA+ID4KPiA+ID4gICAgIGRybS9mYi1oZWxwZXI6IGF0b21pYyByZXN0b3JlX2ZiZGV2X21vZGUo KS4uCj4gPiA+Cj4gPiA+IHdlJ3ZlIGZvcmdvdHRlbiB0byBkbyB0aGUgcGxhbmUtPm9sZF9mYiBy ZWZjb3VudCBkYW5jZSBmb3IKPiA+ID4gcGFuX2Rpc3BsYXlfYXRvbWljLCB3aGljaCBjYW4gcmVz dWx0IGluIHJlZmNvdW50IGxlYWtzIGlmIHRoZSBjdXJyZW50Cj4gPiA+IGNvbmZpZ3VyYXRpb24g aXMgbm90IGZyb20gZmJjb24uIFdoaWNoIGFwcGFyZW50bHkgY2FuIGhhcHBlbiB3aGVuCj4gPiA+ IHZ0LXN3aXRjaGluZyAtIGZiY29uIGRvZXMgYSBwYW4gZmlyc3QgYmVmb3JlIGEgc2V0X3Bhci4K PiA+Cj4gPiBvaCwgd2hvb3BzCj4gPgo+ID4gPiBPQ0QtYWxpZ24gZnVuY3Rpb24gcGFyYW1ldGVy cyB3aGlsZSBhdCBpdC4KPiA+Cj4gPiBkaWQgeW91IG1lYW4gdG8gZHJvcCB0aGF0IGxpbmUgZnJv bSB0aGUgY29tbWl0IG1zZywgb3IgaW5jbHVkZSBhbgo+ID4gZXh0cmEgaHVuayB0aGF0IHlvdSBt aXNzZWQ/CgpnaXQgYWRkIGZhaWwsIHNvIGZpeGVkIHRoYXQgYW5kIGFwcGxpZWQgdGhlIHBhdGNo ZXMsIHRoYW5rcyBmb3IgdGhlIHJldmlldwphbmQgdGVzdGluZy4KLURhbmllbAoKPiA+Cj4gPiBh dCBhbnkgcmF0ZSwKPiA+Cj4gPiBSZXZpZXdlZC1ieTogUm9iIENsYXJrIDxyb2JkY2xhcmtAZ21h aWwuY29tPgo+ID4KPiA+ID4gQ2M6IFJvYiBDbGFyayA8cm9iZGNsYXJrQGdtYWlsLmNvbT4KPiA+ ID4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGdtYWlsLmNvbT4KPiA+ID4gQnVnemls bGE6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNDgzCj4g PiA+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29t Pgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMgfCAyNyAr KysrKysrKysrKysrKysrKysrKysrKysrLS0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyNSBpbnNl cnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4gPgo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hl bHBlci5jCj4gPiA+IGluZGV4IDBhYzBmY2M5YjBkMi4uYjJjZjI4ZGQ5MGZlIDEwMDY0NAo+ID4g PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4gPiA+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiA+ID4gQEAgLTEyNDksNiArMTI0OSw4IEBAIHJl dHJ5Ogo+ID4gPgo+ID4gPiAgICAgICAgICAgICAgICAgbW9kZV9zZXQgPSAmZmJfaGVscGVyLT5j cnRjX2luZm9baV0ubW9kZV9zZXQ7Cj4gPiA+Cj4gPiA+ICsgICAgICAgICAgICAgICBtb2RlX3Nl dC0+Y3J0Yy0+cHJpbWFyeS0+b2xkX2ZiID0KPiA+IG1vZGVfc2V0LT5jcnRjLT5wcmltYXJ5LT5m YjsKPiA+ID4gKwo+ID4gPiAgICAgICAgICAgICAgICAgbW9kZV9zZXQtPnggPSB2YXItPnhvZmZz ZXQ7Cj4gPiA+ICAgICAgICAgICAgICAgICBtb2RlX3NldC0+eSA9IHZhci0+eW9mZnNldDsKPiA+ ID4KPiA+ID4gQEAgLTEyNjQsMTMgKzEyNjYsMzQgQEAgcmV0cnk6Cj4gPiA+ICAgICAgICAgaW5m by0+dmFyLnhvZmZzZXQgPSB2YXItPnhvZmZzZXQ7Cj4gPiA+ICAgICAgICAgaW5mby0+dmFyLnlv ZmZzZXQgPSB2YXItPnlvZmZzZXQ7Cj4gPiA+Cj4gPiA+IC0gICAgICAgcmV0dXJuIDA7Cj4gPiA+ Cj4gPiA+ICBmYWlsOgo+ID4gPiArICAgICAgIGZvcihpID0gMDsgaSA8IGZiX2hlbHBlci0+Y3J0 Y19jb3VudDsgaSsrKSB7Cj4gPiA+ICsgICAgICAgICAgICAgICBzdHJ1Y3QgZHJtX21vZGVfc2V0 ICptb2RlX3NldDsKPiA+ID4gKyAgICAgICAgICAgICAgIHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5l Owo+ID4gPiArCj4gPiA+ICsgICAgICAgICAgICAgICBtb2RlX3NldCA9ICZmYl9oZWxwZXItPmNy dGNfaW5mb1tpXS5tb2RlX3NldDsKPiA+ID4gKyAgICAgICAgICAgICAgIHBsYW5lID0gbW9kZV9z ZXQtPmNydGMtPnByaW1hcnk7Cj4gPiA+ICsKPiA+ID4gKyAgICAgICAgICAgICAgIGlmIChyZXQg PT0gMCkgewo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2ZyYW1lYnVm ZmVyICpuZXdfZmIgPQo+ID4gcGxhbmUtPnN0YXRlLT5mYjsKPiA+ID4gKwo+ID4gPiArICAgICAg ICAgICAgICAgICAgICAgICBpZiAobmV3X2ZiKQo+ID4gPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGRybV9mcmFtZWJ1ZmZlcl9yZWZlcmVuY2UobmV3X2ZiKTsKPiA+ID4gKyAgICAg ICAgICAgICAgICAgICAgICAgcGxhbmUtPmZiID0gbmV3X2ZiOwo+ID4gPiArICAgICAgICAgICAg ICAgICAgICAgICBwbGFuZS0+Y3J0YyA9IHBsYW5lLT5zdGF0ZS0+Y3J0YzsKPiA+ID4gKwo+ID4g PiArICAgICAgICAgICAgICAgICAgICAgICBpZiAocGxhbmUtPm9sZF9mYikKPiA+ID4gKwo+ID4g IGRybV9mcmFtZWJ1ZmZlcl91bnJlZmVyZW5jZShwbGFuZS0+b2xkX2ZiKTsKPiA+ID4gKyAgICAg ICAgICAgICAgIH0KPiA+ID4gKyAgICAgICAgICAgICAgIHBsYW5lLT5vbGRfZmIgPSBOVUxMOwo+ ID4gPiArICAgICAgIH0KPiA+ID4gKwo+ID4gPiAgICAgICAgIGlmIChyZXQgPT0gLUVERUFETEsp Cj4gPiA+ICAgICAgICAgICAgICAgICBnb3RvIGJhY2tvZmY7Cj4gPiA+Cj4gPiA+IC0gICAgICAg ZHJtX2F0b21pY19zdGF0ZV9mcmVlKHN0YXRlKTsKPiA+ID4gKyAgICAgICBpZiAocmV0ICE9IDAp Cj4gPiA+ICsgICAgICAgICAgICAgICBkcm1fYXRvbWljX3N0YXRlX2ZyZWUoc3RhdGUpOwo+ID4g Pgo+ID4gPiAgICAgICAgIHJldHVybiByZXQ7Cj4gPiA+Cj4gPiA+IC0tCj4gPiA+IDIuNS4xCj4g PiA+Cj4gPgoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBv cmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==