From: Dan Carpenter <dan.carpenter@oracle.com>
To: daniel.vetter@ffwll.ch
Cc: dri-devel@lists.freedesktop.org
Subject: re: drm/gem: Check locking in drm_gem_object_unreference
Date: Sat, 17 Oct 2015 09:33:50 +0300 [thread overview]
Message-ID: <20151017063350.GA28590@mwanda> (raw)
Hello Daniel Vetter,
This is a semi-automatic email about new static checker warnings.
The patch 5771551c4877: "drm/gem: Check locking in
drm_gem_object_unreference" from Oct 15, 2015, leads to the following
Smatch complaint:
include/drm/drm_gem.h:147 drm_gem_object_unreference()
warn: variable dereferenced before check 'obj' (see line 145)
include/drm/drm_gem.h
144 {
145 WARN_ON(!mutex_is_locked(&obj->dev->struct_mutex));
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
deref.
146
147 if (obj != NULL)
check.
148 kref_put(&obj->refcount, drm_gem_object_free);
149 }
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
reply other threads:[~2015-10-17 6:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151017063350.GA28590@mwanda \
--to=dan.carpenter@oracle.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox