From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/mgag200: don't pass NULL file_priv to drm_gem_object_lookup() Date: Mon, 19 Oct 2015 17:50:34 +0200 Message-ID: <20151019155034.GF13786@phenom.ffwll.local> References: <5624E1A602000078000AC488@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6CBEC6EA63 for ; Mon, 19 Oct 2015 08:50:38 -0700 (PDT) Received: by wicfv8 with SMTP id fv8so12301208wic.0 for ; Mon, 19 Oct 2015 08:50:37 -0700 (PDT) Content-Disposition: inline In-Reply-To: <5624E1A602000078000AC488@prv-mh.provo.novell.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jan Beulich Cc: daniel.vetter@intel.com, treding@nvidia.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBPY3QgMTksIDIwMTUgYXQgMDQ6Mjc6MThBTSAtMDYwMCwgSmFuIEJldWxpY2ggd3Jv dGU6Cj4gQ29tbWl0IGJmODkyMDlhNmQgKCJkcm0vbWdhMjAwZzogSG9sZCBhIHByb3BlciByZWZl cmVuY2UgZm9yCj4gY3Vyc29yX3NldCIpIGNsZWFybHkgZGlkbid0IHRha2UgdGhlIGNhbGwgc2l0 ZSBpbgo+IGRybV9mYl9oZWxwZXIuYzpyZXN0b3JlX2ZiZGV2X21vZGUoKSBpbnRvIGFjY291bnQs IHdoaWNoIHBhc3NlcyBOVUxMIAo+IGZvciBmaWxlX3ByaXYgYW5kIGhlbmNlIGNhdXNlcyBkcm1f Z2VtX29iamVjdF9sb29rdXAoKSB0byBmYXVsdC4gTW92ZQo+IHRoZSBsb29rdXAgYmFjayB0byBi ZWZvcmUgIm9iaiIgaXMgYWN0dWFsbHkgbmVlZGVkLCBhZGp1c3RpbmcgZXJyb3IKPiBwYXRocyBz dWl0YWJseSBvbmNlIGFnYWluLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1 bGljaEBzdXNlLmNvbT4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5j b20+Cj4gQ2M6IFRoaWVycnkgUmVkaW5nIDx0cmVkaW5nQG52aWRpYS5jb20+CgpPb3BzLCB0b3Rh bGx5IGZvcmdvdCB0aGF0IGhhbmRsZT0wIGlzIHVzZWQgdG8gZGlzYWJsZSB0aGUgY3Vyc29yLiBU aGFua3MKZm9yIHRoZSBmaXguCgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZl dHRlckBmZndsbC5jaD4KCkRhdmUsIHNpbmNlIHRoaXMgaXMgaW4gNC4zIGNhbiB5b3UgcGxzIHBp Y2sgdGhpcyB1cCBmb3IgZHJtLWZpeGVzPwoKVGhhbmtzLCBEYW5pZWwKCj4gLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9tZ2FnMjAwL21nYWcyMDBfY3Vyc29yLmMgfCAgIDE4ICsrKysrKysrKystLS0t LS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkK PiAKPiAtLS0gNC4zLXJjNi9kcml2ZXJzL2dwdS9kcm0vbWdhZzIwMC9tZ2FnMjAwX2N1cnNvci5j Cj4gKysrIDQuMy1yYzYtbWdhZzIwMC1jdXJzb3Itc2V0L2RyaXZlcnMvZ3B1L2RybS9tZ2FnMjAw L21nYWcyMDBfY3Vyc29yLmMKPiBAQCAtNDAsNyArNDAsNyBAQCBpbnQgbWdhX2NydGNfY3Vyc29y X3NldChzdHJ1Y3QgZHJtX2NydGMKPiAgCXN0cnVjdCBtZ2FnMjAwX2JvICpwaXhlbHNfMiA9IG1k ZXYtPmN1cnNvci5waXhlbHNfMjsKPiAgCXN0cnVjdCBtZ2FnMjAwX2JvICpwaXhlbHNfY3VycmVu dCA9IG1kZXYtPmN1cnNvci5waXhlbHNfY3VycmVudDsKPiAgCXN0cnVjdCBtZ2FnMjAwX2JvICpw aXhlbHNfcHJldiA9IG1kZXYtPmN1cnNvci5waXhlbHNfcHJldjsKPiAtCXN0cnVjdCBkcm1fZ2Vt X29iamVjdCAqb2JqOwo+ICsJc3RydWN0IGRybV9nZW1fb2JqZWN0ICpvYmogPSBOVUxMOwo+ICAJ c3RydWN0IG1nYWcyMDBfYm8gKmJvID0gTlVMTDsKPiAgCWludCByZXQgPSAwOwo+ICAJdW5zaWdu ZWQgaW50IGksIHJvdywgY29sOwo+IEBAIC03MCwxNSArNzAsMTEgQEAgaW50IG1nYV9jcnRjX2N1 cnNvcl9zZXQoc3RydWN0IGRybV9jcnRjCj4gIAlCVUdfT04ocGl4ZWxzXzIgIT0gcGl4ZWxzX2N1 cnJlbnQgJiYgcGl4ZWxzXzIgIT0gcGl4ZWxzX3ByZXYpOwo+ICAJQlVHX09OKHBpeGVsc19jdXJy ZW50ID09IHBpeGVsc19wcmV2KTsKPiAgCj4gLQlvYmogPSBkcm1fZ2VtX29iamVjdF9sb29rdXAo ZGV2LCBmaWxlX3ByaXYsIGhhbmRsZSk7Cj4gLQlpZiAoIW9iaikKPiAtCQlyZXR1cm4gLUVOT0VO VDsKPiAtCj4gIAlyZXQgPSBtZ2FnMjAwX2JvX3Jlc2VydmUocGl4ZWxzXzEsIHRydWUpOwo+ICAJ aWYgKHJldCkgewo+ICAJCVdSRUc4KE1HQV9DVVJQT1NYTCwgMCk7Cj4gIAkJV1JFRzgoTUdBX0NV UlBPU1hILCAwKTsKPiAtCQlnb3RvIG91dF91bnJlZjsKPiArCQlyZXR1cm4gcmV0Owo+ICAJfQo+ ICAJcmV0ID0gbWdhZzIwMF9ib19yZXNlcnZlKHBpeGVsc18yLCB0cnVlKTsKPiAgCWlmIChyZXQp IHsKPiBAQCAtMTEwLDYgKzEwNiwxMiBAQCBpbnQgbWdhX2NydGNfY3Vyc29yX3NldChzdHJ1Y3Qg ZHJtX2NydGMKPiAgCQl9Cj4gIAl9Cj4gIAo+ICsJb2JqID0gZHJtX2dlbV9vYmplY3RfbG9va3Vw KGRldiwgZmlsZV9wcml2LCBoYW5kbGUpOwo+ICsJaWYgKCFvYmopIHsKPiArCQlyZXQgPSAtRU5P RU5UOwo+ICsJCWdvdG8gb3V0MTsKPiArCX0KPiArCj4gIAlibyA9IGdlbV90b19tZ2FfYm8ob2Jq KTsKPiAgCXJldCA9IG1nYWcyMDBfYm9fcmVzZXJ2ZShibywgdHJ1ZSk7Cj4gIAlpZiAocmV0KSB7 Cj4gQEAgLTI0MywxMyArMjQ1LDEzIEBAIGludCBtZ2FfY3J0Y19jdXJzb3Jfc2V0KHN0cnVjdCBk cm1fY3J0Ywo+ICAgb3V0MjoKPiAgCW1nYWcyMDBfYm9fdW5yZXNlcnZlKGJvKTsKPiAgIG91dDE6 Cj4gKwlpZiAob2JqKQo+ICsJCWRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNlX3VubG9ja2VkKG9i aik7Cj4gIAlpZiAocmV0KQo+ICAJCW1nYV9oaWRlX2N1cnNvcihtZGV2KTsKPiAgCW1nYWcyMDBf Ym9fdW5yZXNlcnZlKHBpeGVsc18xKTsKPiAgb3V0X3VucmVzZXJ2ZTE6Cj4gIAltZ2FnMjAwX2Jv X3VucmVzZXJ2ZShwaXhlbHNfMik7Cj4gLW91dF91bnJlZjoKPiAtCWRybV9nZW1fb2JqZWN0X3Vu cmVmZXJlbmNlX3VubG9ja2VkKG9iaik7Cj4gIAo+ICAJcmV0dXJuIHJldDsKPiAgfQo+IAo+IAo+ IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJp LWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBo dHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgot LSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0 cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK