From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: correctly check failed allocation Date: Wed, 21 Oct 2015 09:29:56 +0200 Message-ID: <20151021072956.GO13786@phenom.ffwll.local> References: <1445272410-25013-1-git-send-email-wuninsu@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by gabe.freedesktop.org (Postfix) with ESMTPS id 856156ED2B for ; Wed, 21 Oct 2015 00:30:00 -0700 (PDT) Received: by wicll6 with SMTP id ll6so60763348wic.1 for ; Wed, 21 Oct 2015 00:29:59 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1445272410-25013-1-git-send-email-wuninsu@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Insu Yun Cc: yeongjin.jang@gatech.edu, taesoo@gatech.edu, insu@gatech.edu, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, changwoo@gatech.edu List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBPY3QgMTksIDIwMTUgYXQgMDQ6MzM6MzBQTSArMDAwMCwgSW5zdSBZdW4gd3JvdGU6 Cj4gZHJtX3Byb3BlcnR5X2NyZWF0ZV9yYW5nZSBjYW4gYmUgZmFpbGVkIGluIG1lbW9yeSBwcmVz c3VyZQo+IFRoZXJlZm9yZSwgY2hlY2sgcmV0dXJuIHZhbHVlIGFuZCBoYW5kbGUgYW4gZXJyb3IK PiAKPiBTaWduZWQtb2ZmLWJ5OiBJbnN1IFl1biA8d3VuaW5zdUBnbWFpbC5jb20+CgpUaGVyZSdz IGFsc28gb3RoZXIgZHJtX3Byb3BlcnR5X2NyZWF0ZV8qIGZ1bmN0aW9ucywgYW5kIHdlIG1pc3Mg ZXJyb3IKaGFuZGxpbmcgZm9yIGEgYnVuY2ggbW9yZSBvZiB0aGVzZSBwbGFjZXMuIEFyZSB5b3Ug d29ya2luZyBvbiBtb3JlCnBhdGNoZXM/CgpNZXJnZWQgdGhpcyBvbmUgdG8gZHJtLW1pc2MgbWVh bndoaWxlLCB0aGFua3MuCi1EYW5pZWwKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fY3J0 Yy5jIHwgMzAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2Vk LCAzMCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f Y3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMKPiBpbmRleCAzM2Q4NzdjLi41ZmI2 NTgzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2RybV9jcnRjLmMKPiBAQCAtMTUyNSw2ICsxNTI1LDkgQEAgaW50IGRybV9t b2RlX2NyZWF0ZV90dl9wcm9wZXJ0aWVzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJCQkJ ICAic2VsZWN0IHN1YmNvbm5lY3RvciIsCj4gIAkJCQkJICBkcm1fdHZfc2VsZWN0X2VudW1fbGlz dCwKPiAgCQkJCQkgIEFSUkFZX1NJWkUoZHJtX3R2X3NlbGVjdF9lbnVtX2xpc3QpKTsKPiArCWlm ICghdHZfc2VsZWN0b3IpCj4gKwkJZ290byBub21lbTsKPiArCj4gIAlkZXYtPm1vZGVfY29uZmln LnR2X3NlbGVjdF9zdWJjb25uZWN0b3JfcHJvcGVydHkgPSB0dl9zZWxlY3RvcjsKPiAgCj4gIAl0 dl9zdWJjb25uZWN0b3IgPQo+IEBAIC0xNTMyLDYgKzE1MzUsOCBAQCBpbnQgZHJtX21vZGVfY3Jl YXRlX3R2X3Byb3BlcnRpZXMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQkJCSAgICAic3Vi Y29ubmVjdG9yIiwKPiAgCQkJCSAgICBkcm1fdHZfc3ViY29ubmVjdG9yX2VudW1fbGlzdCwKPiAg CQkJCSAgICBBUlJBWV9TSVpFKGRybV90dl9zdWJjb25uZWN0b3JfZW51bV9saXN0KSk7Cj4gKwlp ZiAoIXR2X3N1YmNvbm5lY3RvcikKPiArCQlnb3RvIG5vbWVtOwo+ICAJZGV2LT5tb2RlX2NvbmZp Zy50dl9zdWJjb25uZWN0b3JfcHJvcGVydHkgPSB0dl9zdWJjb25uZWN0b3I7Cj4gIAo+ICAJLyoK PiBAQCAtMTUzOSw0MiArMTU0NCw2NyBAQCBpbnQgZHJtX21vZGVfY3JlYXRlX3R2X3Byb3BlcnRp ZXMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCSAqLwo+ICAJZGV2LT5tb2RlX2NvbmZpZy50 dl9sZWZ0X21hcmdpbl9wcm9wZXJ0eSA9Cj4gIAkJZHJtX3Byb3BlcnR5X2NyZWF0ZV9yYW5nZShk ZXYsIDAsICJsZWZ0IG1hcmdpbiIsIDAsIDEwMCk7Cj4gKwlpZiAoIWRldi0+bW9kZV9jb25maWcu dHZfbGVmdF9tYXJnaW5fcHJvcGVydHkpCj4gKwkJZ290byBub21lbTsKPiAgCj4gIAlkZXYtPm1v ZGVfY29uZmlnLnR2X3JpZ2h0X21hcmdpbl9wcm9wZXJ0eSA9Cj4gIAkJZHJtX3Byb3BlcnR5X2Ny ZWF0ZV9yYW5nZShkZXYsIDAsICJyaWdodCBtYXJnaW4iLCAwLCAxMDApOwo+ICsJaWYgKCFkZXYt Pm1vZGVfY29uZmlnLnR2X3JpZ2h0X21hcmdpbl9wcm9wZXJ0eSkKPiArCQlnb3RvIG5vbWVtOwo+ ICAKPiAgCWRldi0+bW9kZV9jb25maWcudHZfdG9wX21hcmdpbl9wcm9wZXJ0eSA9Cj4gIAkJZHJt X3Byb3BlcnR5X2NyZWF0ZV9yYW5nZShkZXYsIDAsICJ0b3AgbWFyZ2luIiwgMCwgMTAwKTsKPiAr CWlmICghZGV2LT5tb2RlX2NvbmZpZy50dl90b3BfbWFyZ2luX3Byb3BlcnR5KQo+ICsJCWdvdG8g bm9tZW07Cj4gIAo+ICAJZGV2LT5tb2RlX2NvbmZpZy50dl9ib3R0b21fbWFyZ2luX3Byb3BlcnR5 ID0KPiAgCQlkcm1fcHJvcGVydHlfY3JlYXRlX3JhbmdlKGRldiwgMCwgImJvdHRvbSBtYXJnaW4i LCAwLCAxMDApOwo+ICsJaWYgKCFkZXYtPm1vZGVfY29uZmlnLnR2X2JvdHRvbV9tYXJnaW5fcHJv cGVydHkpCj4gKwkJZ290byBub21lbTsKPiAgCj4gIAlkZXYtPm1vZGVfY29uZmlnLnR2X21vZGVf cHJvcGVydHkgPQo+ICAJCWRybV9wcm9wZXJ0eV9jcmVhdGUoZGV2LCBEUk1fTU9ERV9QUk9QX0VO VU0sCj4gIAkJCQkgICAgIm1vZGUiLCBudW1fbW9kZXMpOwo+ICsJaWYgKCFkZXYtPm1vZGVfY29u ZmlnLnR2X21vZGVfcHJvcGVydHkpCj4gKwkJZ290byBub21lbTsKPiArCj4gIAlmb3IgKGkgPSAw OyBpIDwgbnVtX21vZGVzOyBpKyspCj4gIAkJZHJtX3Byb3BlcnR5X2FkZF9lbnVtKGRldi0+bW9k ZV9jb25maWcudHZfbW9kZV9wcm9wZXJ0eSwgaSwKPiAgCQkJCSAgICAgIGksIG1vZGVzW2ldKTsK PiAgCj4gIAlkZXYtPm1vZGVfY29uZmlnLnR2X2JyaWdodG5lc3NfcHJvcGVydHkgPQo+ICAJCWRy bV9wcm9wZXJ0eV9jcmVhdGVfcmFuZ2UoZGV2LCAwLCAiYnJpZ2h0bmVzcyIsIDAsIDEwMCk7Cj4g KwlpZiAoIWRldi0+bW9kZV9jb25maWcudHZfYnJpZ2h0bmVzc19wcm9wZXJ0eSkKPiArCQlnb3Rv IG5vbWVtOwo+ICAKPiAgCWRldi0+bW9kZV9jb25maWcudHZfY29udHJhc3RfcHJvcGVydHkgPQo+ ICAJCWRybV9wcm9wZXJ0eV9jcmVhdGVfcmFuZ2UoZGV2LCAwLCAiY29udHJhc3QiLCAwLCAxMDAp Owo+ICsJaWYgKCFkZXYtPm1vZGVfY29uZmlnLnR2X2NvbnRyYXN0X3Byb3BlcnR5KQo+ICsJCWdv dG8gbm9tZW07Cj4gIAo+ICAJZGV2LT5tb2RlX2NvbmZpZy50dl9mbGlja2VyX3JlZHVjdGlvbl9w cm9wZXJ0eSA9Cj4gIAkJZHJtX3Byb3BlcnR5X2NyZWF0ZV9yYW5nZShkZXYsIDAsICJmbGlja2Vy IHJlZHVjdGlvbiIsIDAsIDEwMCk7Cj4gKwlpZiAoIWRldi0+bW9kZV9jb25maWcudHZfZmxpY2tl cl9yZWR1Y3Rpb25fcHJvcGVydHkpCj4gKwkJZ290byBub21lbTsKPiAgCj4gIAlkZXYtPm1vZGVf Y29uZmlnLnR2X292ZXJzY2FuX3Byb3BlcnR5ID0KPiAgCQlkcm1fcHJvcGVydHlfY3JlYXRlX3Jh bmdlKGRldiwgMCwgIm92ZXJzY2FuIiwgMCwgMTAwKTsKPiArCWlmICghZGV2LT5tb2RlX2NvbmZp Zy50dl9vdmVyc2Nhbl9wcm9wZXJ0eSkKPiArCQlnb3RvIG5vbWVtOwo+ICAKPiAgCWRldi0+bW9k ZV9jb25maWcudHZfc2F0dXJhdGlvbl9wcm9wZXJ0eSA9Cj4gIAkJZHJtX3Byb3BlcnR5X2NyZWF0 ZV9yYW5nZShkZXYsIDAsICJzYXR1cmF0aW9uIiwgMCwgMTAwKTsKPiArCWlmICghZGV2LT5tb2Rl X2NvbmZpZy50dl9zYXR1cmF0aW9uX3Byb3BlcnR5KQo+ICsJCWdvdG8gbm9tZW07Cj4gIAo+ICAJ ZGV2LT5tb2RlX2NvbmZpZy50dl9odWVfcHJvcGVydHkgPQo+ICAJCWRybV9wcm9wZXJ0eV9jcmVh dGVfcmFuZ2UoZGV2LCAwLCAiaHVlIiwgMCwgMTAwKTsKPiArCWlmICghZGV2LT5tb2RlX2NvbmZp Zy50dl9odWVfcHJvcGVydHkpCj4gKwkJZ290byBub21lbTsKPiAgCj4gIAlyZXR1cm4gMDsKPiAr bm9tZW06Cj4gKwlyZXR1cm4gLUVOT01FTTsKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKGRybV9tb2Rl X2NyZWF0ZV90dl9wcm9wZXJ0aWVzKTsKPiAgCj4gLS0gCj4gMS45LjEKPiAKPiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkRhbmllbCBWZXR0 ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xs LmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==