From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/tegra: don't take dev->struct_mutex in mmap offset ioctl Date: Wed, 21 Oct 2015 13:23:38 +0200 Message-ID: <20151021112338.GA20258@ulmo> References: <1444894601-5200-6-git-send-email-daniel.vetter@ffwll.ch> <1444912504-13581-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0540525219==" Return-path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4A4177A128 for ; Wed, 21 Oct 2015 04:23:41 -0700 (PDT) Received: by wicll6 with SMTP id ll6so69392653wic.1 for ; Wed, 21 Oct 2015 04:23:39 -0700 (PDT) In-Reply-To: <1444912504-13581-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , DRI Development List-Id: dri-devel@lists.freedesktop.org --===============0540525219== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="u3/rZRmxL6MmkK24" Content-Disposition: inline --u3/rZRmxL6MmkK24 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 15, 2015 at 02:35:04PM +0200, Daniel Vetter wrote: > Since David Herrmann's mmap vma manager rework we don't need to grab > dev->struct_mutex any more to prevent races when looking up the mmap > offset. Drop it and instead don't forget to use the unref_unlocked > variant (since the drm core still cares). >=20 > v2: Finally get rid of the copypasta from another commit in this > commit message. And convert to _unlocked like we need to (Patrik). >=20 > Cc: Patrik Jakobsson > Cc: Thierry Reding > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/tegra/gem.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Looks good to me: Acked-by: Thierry Reding --u3/rZRmxL6MmkK24 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWJ3W3AAoJEN0jrNd/PrOhtuAP/jYu8Urn4fKpQxdmPUGpfMh4 p39XsO1pOhZ2g/AZlg58n2VfkS/BInIkR2KRtpwq06LYUt+EQ3BR+XKu4Y0Rh1pw CSeYLEvZrwz/P1cgOy8tXspJ63/9L6rjffId7s1Fe1KiEA2Gm4Dqqt46zBPAEHFU jWGA6PBaAUypZ80B+5HDg3Shg7GvxRIP+cTlhTuhvMneyM+0CQYC5GlHOmtNG1rY qo9xOLXnLCLQUwD5LueAI0yVUNmb+lU3aXaCQp/RjbjbfVSq2M6a1AbA/d2dZjaa rc7JKWGbxZmVN4gDL//4e8WfL6Z2J5v7SHEVtD0iya/lTqHWgd5Tb/YytgoAZEd1 2GVGR/kedq4jNv+WolR8EgYAqo1t4bunH/atneZIIx6A6LZisKfqX0z+tC3UDQVk A6Xag2IwcmXDM6vLahbLP0gNU6vWclo0nFGHunAwTks1dpj30gZpMB8O2zAawN8x nw0lNaNUDaR/tiyvP8U63Q7STkfzTlZ8Ndv6rAmuVGy5axoFCN1eRfPhq1pYaYdR zfl4ACprsIM7qyteOSTggsDkEFvSAEaIv42s2YMIbTntWdG6AGMucub+tGGJ/MJU w4EX/MjUUV7KP29+V1dx+P7YA9oD9BQpzeEmkzV6r4UhM5Xo+YaSMPO8TrRRCa47 +ofbdHia3sqZBR3vphfx =gsl3 -----END PGP SIGNATURE----- --u3/rZRmxL6MmkK24-- --===============0540525219== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0540525219==--