From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] GPU-DRM: Delete unnecessary checks before drm_property_unreference_blob() Date: Mon, 16 Nov 2015 15:04:25 +0100 Message-ID: <20151116140425.GS16848@phenom.ffwll.local> References: <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <55998CD5.3080204@users.sourceforge.net> <20150706065346.GA2156@phenom.ffwll.local> <563C8B3E.405@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D94B6E005 for ; Mon, 16 Nov 2015 06:04:30 -0800 (PST) Received: by wmdw130 with SMTP id w130so112418149wmd.0 for ; Mon, 16 Nov 2015 06:04:29 -0800 (PST) Content-Disposition: inline In-Reply-To: <563C8B3E.405@users.sourceforge.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: SF Markus Elfring Cc: kernel-janitors@vger.kernel.org, LKML , dri-devel@lists.freedesktop.org, Julia Lawall , Junwang Zhao List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBOb3YgMDYsIDIwMTUgYXQgMTI6MTM6MDJQTSArMDEwMCwgU0YgTWFya3VzIEVsZnJp bmcgd3JvdGU6Cj4gRnJvbTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9y Z2UubmV0Pgo+IERhdGU6IEZyaSwgNiBOb3YgMjAxNSAxMjowMzo0NiArMDEwMAo+IAo+IFRoZSBk cm1fcHJvcGVydHlfdW5yZWZlcmVuY2VfYmxvYigpIGZ1bmN0aW9uIHRlc3RzIHdoZXRoZXIgaXRz IGFyZ3VtZW50Cj4gaXMgTlVMTCBhbmQgdGhlbiByZXR1cm5zIGltbWVkaWF0ZWx5Lgo+IFRodXMg dGhlIHRlc3RzIGFyb3VuZCB0aGUgY2FsbHMgYXJlIG5vdCBuZWVkZWQuCj4gCj4gVGhpcyBpc3N1 ZSB3YXMgZGV0ZWN0ZWQgYnkgdXNpbmcgdGhlIENvY2NpbmVsbGUgc29mdHdhcmUuCj4gCj4gU2ln bmVkLW9mZi1ieTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0 PgoKQXBwbGllZCB0byBkcm0tbWlzYywgdGhhbmtzLgotRGFuaWVsCgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vZHJtX2F0b21pYy5jICAgICAgICB8IDkgKysrLS0tLS0tCj4gIGRyaXZlcnMvZ3B1 L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIHwgNSArKy0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDUg aW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2RybV9hdG9taWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiBpbmRl eCA3YmIzODQ1Li5kNjVkYzMxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRv bWljLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gQEAgLTMxNiw4ICsz MTYsNyBAQCBpbnQgZHJtX2F0b21pY19zZXRfbW9kZV9mb3JfY3J0YyhzdHJ1Y3QgZHJtX2NydGNf c3RhdGUgKnN0YXRlLAo+ICAJaWYgKG1vZGUgJiYgbWVtY21wKCZzdGF0ZS0+bW9kZSwgbW9kZSwg c2l6ZW9mKCptb2RlKSkgPT0gMCkKPiAgCQlyZXR1cm4gMDsKPiAgCj4gLQlpZiAoc3RhdGUtPm1v ZGVfYmxvYikKPiAtCQlkcm1fcHJvcGVydHlfdW5yZWZlcmVuY2VfYmxvYihzdGF0ZS0+bW9kZV9i bG9iKTsKPiArCWRybV9wcm9wZXJ0eV91bnJlZmVyZW5jZV9ibG9iKHN0YXRlLT5tb2RlX2Jsb2Ip Owo+ICAJc3RhdGUtPm1vZGVfYmxvYiA9IE5VTEw7Cj4gIAo+ICAJaWYgKG1vZGUpIHsKPiBAQCAt MzYzLDggKzM2Miw3IEBAIGludCBkcm1fYXRvbWljX3NldF9tb2RlX3Byb3BfZm9yX2NydGMoc3Ry dWN0IGRybV9jcnRjX3N0YXRlICpzdGF0ZSwKPiAgCWlmIChibG9iID09IHN0YXRlLT5tb2RlX2Js b2IpCj4gIAkJcmV0dXJuIDA7Cj4gIAo+IC0JaWYgKHN0YXRlLT5tb2RlX2Jsb2IpCj4gLQkJZHJt X3Byb3BlcnR5X3VucmVmZXJlbmNlX2Jsb2Ioc3RhdGUtPm1vZGVfYmxvYik7Cj4gKwlkcm1fcHJv cGVydHlfdW5yZWZlcmVuY2VfYmxvYihzdGF0ZS0+bW9kZV9ibG9iKTsKPiAgCXN0YXRlLT5tb2Rl X2Jsb2IgPSBOVUxMOwo+ICAKPiAgCWlmIChibG9iKSB7Cj4gQEAgLTQxOSw4ICs0MTcsNyBAQCBp bnQgZHJtX2F0b21pY19jcnRjX3NldF9wcm9wZXJ0eShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4g IAkJc3RydWN0IGRybV9wcm9wZXJ0eV9ibG9iICptb2RlID0KPiAgCQkJZHJtX3Byb3BlcnR5X2xv b2t1cF9ibG9iKGRldiwgdmFsKTsKPiAgCQlyZXQgPSBkcm1fYXRvbWljX3NldF9tb2RlX3Byb3Bf Zm9yX2NydGMoc3RhdGUsIG1vZGUpOwo+IC0JCWlmIChtb2RlKQo+IC0JCQlkcm1fcHJvcGVydHlf dW5yZWZlcmVuY2VfYmxvYihtb2RlKTsKPiArCQlkcm1fcHJvcGVydHlfdW5yZWZlcmVuY2VfYmxv Yihtb2RlKTsKPiAgCQlyZXR1cm4gcmV0Owo+ICAJfQo+ICAJZWxzZSBpZiAoY3J0Yy0+ZnVuY3Mt PmF0b21pY19zZXRfcHJvcGVydHkpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f YXRvbWljX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiBp bmRleCAwYzZmNjIxLi45ODcwYzcwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f YXRvbWljX2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVy LmMKPiBAQCAtMjE3Myw3ICsyMTczLDcgQEAgRVhQT1JUX1NZTUJPTChkcm1fYXRvbWljX2hlbHBl cl9jb25uZWN0b3JfZHBtcyk7Cj4gICAqLwo+ICB2b2lkIGRybV9hdG9taWNfaGVscGVyX2NydGNf cmVzZXQoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ICB7Cj4gLQlpZiAoY3J0Yy0+c3RhdGUgJiYg Y3J0Yy0+c3RhdGUtPm1vZGVfYmxvYikKPiArCWlmIChjcnRjLT5zdGF0ZSkKPiAgCQlkcm1fcHJv cGVydHlfdW5yZWZlcmVuY2VfYmxvYihjcnRjLT5zdGF0ZS0+bW9kZV9ibG9iKTsKPiAgCWtmcmVl KGNydGMtPnN0YXRlKTsKPiAgCWNydGMtPnN0YXRlID0ga3phbGxvYyhzaXplb2YoKmNydGMtPnN0 YXRlKSwgR0ZQX0tFUk5FTCk7Cj4gQEAgLTIyNDEsOCArMjI0MSw3IEBAIEVYUE9SVF9TWU1CT0wo ZHJtX2F0b21pY19oZWxwZXJfY3J0Y19kdXBsaWNhdGVfc3RhdGUpOwo+ICB2b2lkIF9fZHJtX2F0 b21pY19oZWxwZXJfY3J0Y19kZXN0cm95X3N0YXRlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAg CQkJCQkgICAgc3RydWN0IGRybV9jcnRjX3N0YXRlICpzdGF0ZSkKPiAgewo+IC0JaWYgKHN0YXRl LT5tb2RlX2Jsb2IpCj4gLQkJZHJtX3Byb3BlcnR5X3VucmVmZXJlbmNlX2Jsb2Ioc3RhdGUtPm1v ZGVfYmxvYik7Cj4gKwlkcm1fcHJvcGVydHlfdW5yZWZlcmVuY2VfYmxvYihzdGF0ZS0+bW9kZV9i bG9iKTsKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKF9fZHJtX2F0b21pY19oZWxwZXJfY3J0Y19kZXN0 cm95X3N0YXRlKTsKPiAgCj4gLS0gCj4gMi42LjIKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3 YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=