From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: drm: Bogus WARN() in drm_atomic_helper_update_legacy_modeset_state() ? Date: Mon, 16 Nov 2015 17:30:22 +0100 Message-ID: <20151116163022.GF16848@phenom.ffwll.local> References: <20151110150102.GP963@e106497-lin.cambridge.arm.com> <20151110165615.GB27962@ulmo> <20151111160942.GS963@e106497-lin.cambridge.arm.com> <20151112121655.GA31019@ulmo> <20151112135711.GB963@e106497-lin.cambridge.arm.com> <20151112162801.GC3913@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE25B6E18D for ; Mon, 16 Nov 2015 08:30:26 -0800 (PST) Received: by wmww144 with SMTP id w144so126982842wmw.0 for ; Mon, 16 Nov 2015 08:30:25 -0800 (PST) Content-Disposition: inline In-Reply-To: <20151112162801.GC3913@ulmo> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: Liviu Dudau , lkml , DRI devel List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBOb3YgMTIsIDIwMTUgYXQgMDU6Mjg6MDFQTSArMDEwMCwgVGhpZXJyeSBSZWRpbmcg d3JvdGU6Cj4gT24gVGh1LCBOb3YgMTIsIDIwMTUgYXQgMDE6NTc6MTFQTSArMDAwMCwgTGl2aXUg RHVkYXUgd3JvdGU6Cj4gPiBPbiBUaHUsIE5vdiAxMiwgMjAxNSBhdCAwMToxNjo1NVBNICswMTAw LCBUaGllcnJ5IFJlZGluZyB3cm90ZToKPiA+ID4gT24gV2VkLCBOb3YgMTEsIDIwMTUgYXQgMDQ6 MDk6NDJQTSArMDAwMCwgTGl2aXUgRHVkYXUgd3JvdGU6Cj4gPiA+ID4gT24gVHVlLCBOb3YgMTAs IDIwMTUgYXQgMDU6NTY6MTVQTSArMDEwMCwgVGhpZXJyeSBSZWRpbmcgd3JvdGU6Cj4gPiA+ID4g PiBPbiBUdWUsIE5vdiAxMCwgMjAxNSBhdCAwMzowMTowM1BNICswMDAwLCBMaXZpdSBEdWRhdSB3 cm90ZToKPiA+ID4gPiA+ID4gSGVsbG8sCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBXaGVuIGJv b3RpbmcgbXkgSnVubyBib2FyZCB3aXRoIHRoZSBIRExDRCBkcml2ZXIgdGhhdCBJIGhhdmUgY29u dmVydGVkIHRvCj4gPiA+ID4gPiA+IGF0b21pYyBvcGVyYXRpb25zIEknbSBnZXR0aW5nIHRoZSBm b2xsb3dpbmcgd2FybmluZzoKPiA+ID4gPiA+IAo+ID4gPiA+ID4gUGVyaGFwcyB5b3UgY2FuIHBy b3ZpZGUgcG9pbnRlcnMgdG8gdGhlIHNvdXJjZSBjb2RlLCB0aGF0IG1pZ2h0IG1ha2UgaXQKPiA+ ID4gPiA+IGVhc2llciBmb3IgcGVvcGxlIHRvIHNwb3Qgd2hhdCdzIGdvaW5nIHdyb25nLgo+ID4g PiA+ID4gCj4gPiA+ID4gPiBUaGllcnJ5Cj4gPiA+ID4gCj4gPiA+ID4gSGkgVGhpZXJyeSwKPiA+ ID4gPiAKPiA+ID4gPiBJIGhhdmUganVzdCBwdXNoZWQgdG8gdGhlIG1haWxpbmcgbGlzdHMgbXkg cGF0Y2ggc2VyaWVzLiBbMV0gWzJdCj4gPiA+ID4gCj4gPiA+ID4gSWYgeW91IHdhbnQgdG8gY2hl Y2tvdXQgdGhlIGNvZGUgSSBhbHNvIGhhdmUgYSBicmFuY2ggaGVyZToKPiA+ID4gPiAKPiA+ID4g PiBnaXQ6Ly9naXQ6Ly9saW51eC1hcm0ub3JnL2xpbnV4LWxkIHRlc3RpbmcvaGRsY2QKPiA+ID4g Cj4gPiA+IE9rYXksIHNvIGlmIEkgdW5kZXJzdGFuZCBjb3JyZWN0bHkgeW91J3JlIHVzaW5nIHRo ZSB0ZGE5OTh4IGFzIGVuY29kZXIvCj4gPiA+IGNvbm5lY3RvciBhdHRhY2hlZCB0byB5b3VyIG5l dyBIRExDRCBkcml2ZXIuIEkgdGhpbmsgdGhlIHByb2JsZW0gaXNuJ3QKPiA+ID4gc28gbXVjaCB0 aGF0IG5vdGhpbmcgaGFzIHNldCB1cCB0aGUgQ1JUQyBmb3IgdGhlIGVuY29kZXIsIGJ1dCByYXRo ZXIKPiA+ID4gdGhhdCB0aGUgdGRhOTk4eCBlbmNvZGVyIHRyaWVzIHRvIHN0YXRpY2FsbHkgYXNz b2NpYXRlIHRoZSBlbmNvZGVyIHdpdGgKPiA+ID4gdGhlIGNvbm5lY3Rvci4gV2hpbGUgdGhhdCBt aWdodCBiZSBjb3JyZWN0IGluIHRoYXQgaXQgcmVwcmVzZW50cyB0aGUKPiA+ID4gaGFyZHdhcmUg c3RhdGUgKGkuZS4gdGhlcmUgaXMgbm8gd2F5IHRvIHBoeXNpY2FsbHkgcm91dGUgaXQgYW55d2hl cmUKPiA+ID4gZWxzZSksIHRoZSBEUk0gbG9naWNhbCBzdGF0ZSBpcyB0aGF0IGl0J3Mgbm90IGNv bm5lY3RlZCB1bnRpbCBhIGNvbXBsZXRlCj4gPiA+IHBpcGVsaW5lIGhhcyBiZWVuIHNldCB1cCwg aW4gd2hpY2ggY2FzZSBhIENSVEMgd291bGQgaGF2ZSBiZWVuIGFzc2lnbmVkCj4gPiA+IHRvIHRo ZSBlbmNvZGVyLgo+ID4gPiAKPiA+ID4gSWYgeW91ciBzZXR1cCB3ZXJlIHdvcmtpbmcgY29ycmVj dGx5IHlvdSdkIG5ldmVyIHJlYWNoIHRoZSBXQVJOX09OCj4gPiA+IGJlY2F1c2UgdGhlCj4gPiA+ IAo+ID4gPiAJaWYgKGNvbm5lY3Rvci0+ZW5jb2Rlcikgewo+ID4gPiAKPiA+ID4gY29uZGl0aW9u YWwgKG9uIGxpbmUgNjczIGluIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jKSB3 b3VsZAo+ID4gPiBoYXZlIGV2YWx1YXRlZCB0byBmYWxzZSBhbHJlYWR5LCBzaW5jZSBsb2dpY2Fs bHkgdGhlcmUnZCBiZSBubyBlbmNvZGVyCj4gPiA+IGFzc29jaWF0ZWQgd2l0aCB0aGUgY29ubmVj dG9yIHlldC4KPiA+IAo+ID4gWW91ciBhbmFseXNpcyBpcyBzcG90IG9uIGFuZCBtYXRjaGVzIG15 IGNvbmRpdGlvbnMuIEhvd2V2ZXIgLi4uCj4gPiAKPiA+ID4gCj4gPiA+IERvZXMgdGhlIHBhdGNo IGJlbG93IGhlbHA/IExldCBtZSBrbm93IGFuZCBJIGNhbiBwcm9kdWNlIGEgcHJvcGVyIHBhdGNo Lgo+ID4gPiAKPiA+ID4gVGhpZXJyeQo+ID4gPiAKPiA+ID4gLS0tID44IC0tLQo+ID4gPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2kyYy90ZGE5OTh4X2Rydi5jIGIvZHJpdmVycy9ncHUv ZHJtL2kyYy90ZGE5OTh4X2Rydi5jCj4gPiA+IGluZGV4IDg5NmI2YWFmOGM0ZC4uOGIwYTQwMjE5 MGViIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTJjL3RkYTk5OHhfZHJ2LmMK PiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2kyYy90ZGE5OTh4X2Rydi5jCj4gPiA+IEBAIC0x NDUzLDcgKzE0NTMsNiBAQCBzdGF0aWMgaW50IHRkYTk5OHhfYmluZChzdHJ1Y3QgZGV2aWNlICpk ZXYsIHN0cnVjdCBkZXZpY2UgKm1hc3Rlciwgdm9pZCAqZGF0YSkKPiA+ID4gIAlpZiAocmV0KQo+ ID4gPiAgCQlnb3RvIGVycl9zeXNmczsKPiA+ID4gIAo+ID4gPiAtCXByaXYtPmNvbm5lY3Rvci5l bmNvZGVyID0gJnByaXYtPmVuY29kZXI7Cj4gPiAKPiA+IHdoaWxlIHRoaXMgcGF0Y2ggaGVscHMg KG5vIFdBUk4oKSBwcmludGVkKSBJJ20gbm90IHN1cmUgdGhpcyBpcyB0aGUgcmlnaHQgZml4Lgo+ ID4gVERBOTk4eCBpcyBhbHNvIHVzZWQgYnkgYXJtYWRhIERSTSBkcml2ZXIgd2hpY2ggaGFzIG5v dCBiZWVuIGNvbnZlcnRlZCAoeWV0KSB0bwo+ID4gYXRvbWljIG1vZGVzZXR0aW5nLiBBbmQganVk Z2luZyBieSB0aGUgY29kZSBhbmQgY29tbWVudCBvZiBkcm1fY29ubmVjdG9yX2dldF9lbmNvZGVy KCkKPiA+IGluIGRybV9jcnRjLmMsIGhhdmluZyBhY2Nlc3MgdG8gdGhlIGVuY29kZXIgdGhyb3Vn aCB0aGUgY29ubmVjdG9yIGlzIHRoZSBub24tYXRvbWljCj4gPiB3YXkgb2YgZG9pbmcgdGhpbmdz Ogo+ID4gCj4gPiBzdGF0aWMgc3RydWN0IGRybV9lbmNvZGVyICpkcm1fY29ubmVjdG9yX2dldF9l bmNvZGVyKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IpCj4gPiB7Cj4gPiAJLyogRm9y IGF0b21pYyBkcml2ZXJzIG9ubHkgc3RhdGUgb2JqZWN0cyBhcmUgc3luY2hyb25vdXNseSB1cGRh dGVkIGFuZAo+ID4gCSAqIHByb3RlY3RlZCBieSBtb2Rlc2V0IGxvY2tzLCBzbyBjaGVjayB0aG9z ZSBmaXJzdC4gKi8KPiA+IAlpZiAoY29ubmVjdG9yLT5zdGF0ZSkKPiA+IAkJcmV0dXJuIGNvbm5l Y3Rvci0+c3RhdGUtPmJlc3RfZW5jb2RlcjsKPiA+IAlyZXR1cm4gY29ubmVjdG9yLT5lbmNvZGVy Owo+ID4gfQo+ID4gCj4gPiBUbyBtZSwgaXQgbG9va3MgbGlrZSB0aGUgV0FSTigpIGlzIGJvZ3Vz IHdoZW4gdGhlIGF0b21pYyBtb2Rlc2V0dGluZyBpcyB1c2VkIGluCj4gPiBkcm1fYXRvbWljX2hl bHBlcl91cGRhdGVfbGVnYWN5X21vZGVzZXRfc3RhdGUoKS4gRWl0aGVyIHdlIGFja25vd2xlZGdl IHRoYXQgdGhlICJsZWdhY3kiCj4gPiBjb2RlIHNldHMgdGhlIGNvbm5lY3RvciBpbiB0aGUgZW5j b2RlciBzdHJ1Y3R1cmUgYmVmb3JlIGNvbXBsZXRlIHBpcGVsaW5lIGlzIHNldHVwCj4gPiBhbmQg d2UgcmVtb3ZlIHRoZSBXQVJOKCksIG9yIHdlIGZpbmQgYSBiZXR0ZXIgd2F5IG9mIGRldGVjdGlu ZyB0aGF0IHNvbWUgc29ydCBvZiBtaXhlZAo+ID4gc3VwcG9ydCBpcyBpbiBwbGFjZSAoaS5lLiBh dG9taWMgYW5kIG5vbi1hdG9taWMgYXdhcmUgY29kZSBydW5uaW5nKSBhbmQgd2UgY2xlYW4gdXAK PiA+IGluIGEgd2F5IHRoYXQgaXMgY29tcGF0aWJsZSB3aXRoIGJvdGggd29ybGRzLgo+IAo+IEkg dGhpbmsgdGhlIHByb2JsZW0geW91J3JlIHNlZWluZyBoZXJlIGlzIHNwZWNpZmljYWxseSBjYXVz ZWQgYnkgZHJpdmVycwo+IHNldHRpbmcgdXAgdGhlIGNvbm5lY3Rvci0+ZW5jb2RlciBleHBsaWNp dGx5LiBUaGVyZSBzaG91bGQgYmUgbm8gcmVhc29uCj4gdG8gZG8gdGhhdC4gVGhlIERSTSBjb3Jl IHdpbGwgYXV0b21hdGljYWxseSBkbyB0aGF0IHdoZW4gc2V0dGluZyB1cCBhCj4gZGVmYXVsdCBj b25maWd1cmF0aW9uLCBvciBhcyBhIHJlc3VsdCBvZiB1c2Vyc3BhY2Ugc2V0dGluZyB1cCB0aGUg d2FudGVkCj4gY29uZmlndXJhdGlvbi4gWW91J3JlIGFsc28gbGlrZWx5IG9ubHkgc2VlaW5nIHRo aXMgdGhlIGZpcnN0IHRpbWUgYXJvdW5kCj4gYW5kIHN1YnNlcXVlbnQgY2FsbHMgd2lsbCBub3Qg dHJpZ2dlciB0aGlzIGFueW1vcmUgYmVjYXVzZSBhdCB0aGF0IHBvaW50Cj4gdGhlIGNvcmUgd2ls bCBoYXZlIHJlc2V0IGNvbm5lY3Rvci0+ZW5jb2RlciB0byBOVUxMIGFzIHBhcnQgb2YgdGVhcmlu Zwo+IGRvd24gdGhlIHBpcGVsaW5lLgo+IAo+IFRvIGNvcnJvYm9yYXRlIHRoYXQsIHRoZSBUZWdy YSBkcml2ZXIgZG9lc24ndCB0cmlnZ2VyIHRoaXMgV0FSTl9PTigpIGFuZAo+IGFsc28gbmV2ZXIg c2V0cyB1cCB0aGUgY29ubmVjdG9yLT5lbmNvZGVyIG1hbnVhbGx5LiBUaGUgc2FtZSBpcyBwcm9i YWJseQo+IHRydWUgZm9yIG1hbnkgb3RoZXIgZHJpdmVycyB0aGF0IGhhdmUgYWxyZWFkeSBiZWVu IGNvbnZlcnRlZC4gVGhhdCBzYWlkLAo+IGZyb20gYSBicmllZiBsb29rIGl0IHNlZW1zIGxpa2Ug bWFueSBtb3JlIGRyaXZlcnMgZ2V0IHRoaXMgd3JvbmcgYW5kIG1heQo+IHJ1biBpbnRvIHRoaXMg V0FSTiB3aGVuIHRoZXkgZ2V0IGNvbnZlcnRlZCB0byBhdG9taWMuCgpUaGllcnJ5J3MgYW5hbHlz aXMgaXMgc3BvdC1vbiwgZHJtX2Nvbm5lY3Rvci0+ZW5jb2RlciBzaG91bGRuJ3QgZXZlciBiZQpz ZXQgYnkgZHJpdmVzIHdobyBlaXRoZXIgdXNlIGF0b21pYyBoZWxwZXJzIG9yIHRoZSBvbGQgbGVn YWN5IGNydGMKaGVscGVycy4gV2hpY2ggaXMgZXZlcnlvbmUgKG5vdyB0aGF0IGk5MTUgbW92ZWQg ZnJvbSBpdCdzIG93biBtb2Rlc2V0IGNvZGUKdG8gdXNpbmcgYXRvbWljIGhlbHBlcnMpLgoKUmV2 aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+IG9uIHRoZSBh Ym92ZSB0ZGEgcGF0Y2gKaWYgd3JhcHBlZCBpbiBhbiBhcHByb3ByaWF0ZSBjb21taXQgbWVzc2Fn ZS4KLURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29y cG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK